From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GAc8DiIVs17SeQAA0tVLHw (envelope-from ) for ; Wed, 06 May 2020 19:50:58 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id ENwaCC4Vs145GgAAB5/wlQ (envelope-from ) for ; Wed, 06 May 2020 19:51:10 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7282A940FBC for ; Wed, 6 May 2020 19:51:06 +0000 (UTC) Received: from localhost ([::1]:58646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWQ4Q-0006Ti-Sb for larch@yhetil.org; Wed, 06 May 2020 15:51:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWQ4M-0006TV-Oq for guix-patches@gnu.org; Wed, 06 May 2020 15:51:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57936) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jWQ4L-0004gI-NL for guix-patches@gnu.org; Wed, 06 May 2020 15:51:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jWQ4L-0002JG-K5 for guix-patches@gnu.org; Wed, 06 May 2020 15:51:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40994] patch#40994 Programs With Movie Titles (PWMT) Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 06 May 2020 19:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40994 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Raghav Gururajan , Brice Waegeneire Cc: 40994@debbugs.gnu.org Received: via spool by 40994-submit@debbugs.gnu.org id=B40994.15887946228825 (code B ref 40994); Wed, 06 May 2020 19:51:01 +0000 Received: (at 40994) by debbugs.gnu.org; 6 May 2020 19:50:22 +0000 Received: from localhost ([127.0.0.1]:41247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWQ3i-0002IH-6O for submit@debbugs.gnu.org; Wed, 06 May 2020 15:50:22 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:41673) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWQ3g-0002I0-G4 for 40994@debbugs.gnu.org; Wed, 06 May 2020 15:50:21 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 768A64E1; Wed, 6 May 2020 15:50:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 06 May 2020 15:50:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=h4ZydI0HSG1l9kaL+FZ97wjrbQ NguQ7UQdqnbOqsVGY=; b=PFLmFyfuEXY8UCVcn8RN98QFqDik0UzOaQye2oKYSK M2teiQNNJ7huwO+RYhV1+usaCXd/lLi6aQ34YV1EkVRVImkT2rxVduYVrfWDeiJN kgZIUyLqoI7gMAyP7TTqJFGOBwEazsX3im4CpAusKcSVKLt2WU2QYDlyjHef7j2f db484U4/bLn88E11aJxCoySzo903uZ4K2XVAa7EcuxED12TOg96gVB6O3GObT0AU ceiQF151lpZuuABbMX6NkVNxgi1sVBHGtp2aMR8kDc9lIMowk3SfZ2m1eDGyh8xF lEgqozHOcfUsziv6YCehGgvbJ55ABcBnhOgaG8zZuSyA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=h4ZydI 0HSG1l9kaL+FZ97wjrbQNguQ7UQdqnbOqsVGY=; b=W7YSBiWovzzr3IVlgfAVTp VRILvfcM8BZrYzt9ipvAcii2QwQSCU03YcDIapdqkykZZ2Q5XBjci24aP6j3t2Go PYAVRJClBM3+BgfE9Zy9LorvE4SPXXnzGwBgiil6QoGNyfoySI34pbRf2Nb3BGm+ OuBSfjBNLYDklkv/sY+6ZF2WS2Om6iWZHmFhySUpNHMe1eq69aGxJtWwkv39m/RG ZeBRrqbIYCyDKVWaerMwfn1qwqQejNIefZyIeum1DONJ2gvQFAVeXQZsruQO3KSz bcrajRN2BCOD1z//XF+FnqNEWZk1Oav8h00kPUp8HizfLoSP5W51PWJEcuP84kdg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrjeekgddufeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhgffffkgggtsehgtderredtredtnecuhfhrohhmpeforghrihhu shcuuegrkhhkvgcuoehmsggrkhhkvgesfhgrshhtmhgrihhlrdgtohhmqeenucggtffrrg htthgvrhhnpedtvdfggeevgeeivdffueejiedttedvkedtudfggfdtgeefiedtieekffdu gfeuffenucfkphepkeegrddvtddvrdeikedrjeehnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhgsrghkkhgvsehfrghsthhmrghilhdrtgho mh X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 41F943280065; Wed, 6 May 2020 15:50:13 -0400 (EDT) From: Marius Bakke In-Reply-To: <20200503002240.3c2bf6a3.raghavgururajan@disroot.org> References: <76c18088643dcab9d395a0f9760d3a74@waegenei.re> <20200502120901.36d80711.raghavgururajan@disroot.org> <20200503002240.3c2bf6a3.raghavgururajan@disroot.org> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Wed, 06 May 2020 21:50:11 +0200 Message-ID: <87a72k4zd8.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 X-Spam-Score: -2.01 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=fastmail.com header.s=fm2 header.b=PFLmFyfu; dkim=fail (rsa verify failed) header.d=messagingengine.com header.s=fm2 header.b=W7YSBiWo; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fastmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Scan-Result: default: False [-2.01 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.49689726770534]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; FREEMAIL_FROM(0.00)[fastmail.com]; DWL_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.11), country: US(-0.00), ip: 2001:470:142::17(-0.50)]; R_DKIM_REJECT(1.00)[fastmail.com:s=fm2,messagingengine.com:s=fm2]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; DKIM_TRACE(0.00)[fastmail.com:-,messagingengine.com:-]; MAILLIST(-0.20)[mailman]; SIGNED_PGP(-2.00)[]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; TAGGED_FROM(0.00)[larch=yhetil.org]; FROM_NEQ_ENVFROM(0.00)[mbakke@fastmail.com,guix-patches-bounces@gnu.org]; ARC_NA(0.00)[]; URIBL_BLOCKED(0.00)[disroot.org:email]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; HAS_LIST_UNSUB(-0.01)[]; RCVD_COUNT_SEVEN(0.00)[10]; FORGED_SENDER_MAILLIST(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[fastmail.com : SPF not aligned (relaxed),none] X-TUID: VDkNewLFwmgI --=-=-= Content-Type: text/plain Hi! Raghav Gururajan writes: > Here, I have attached another patch-set for modifying stuffs. :-) I have added another set of nit-picks! :-) > From 30042d73a58f90971cd6c37bf56269bd3abb2533 Mon Sep 17 00:00:00 2001 > From: Raghav Gururajan > Date: Sat, 2 May 2020 22:28:44 -0400 > Subject: [PATCH 08/14] gnu: girara: Update package definition. > > * gnu/packages/pwmt.scm (girara): > [source][method]: Changed from git-fetch to url-fetch; and > remove file-name field. > [arguments]<#:glib-or-gtk?>: New argument. > [arguments]<#:configure-flags>[-Dnotify]: New flag. > [native-inputs]: New input. > [inputs]: New inputs. > [propagated-inputs]: Removed. > [synopsis]: Updated. > [description]: Updated. I know it's a lot to ask, but it would be great if you could split this up in multiple patches, one per logical change. I.e. this one patch would be better as a series like: Raghav Gururajan (7): gnu: girara: Download tarball instead of git source. gnu: girara: Wrap with Glib variables. gnu: girara: Add notification support. gnu: girara: Build and install documentation. gnu: girara: Do not propagate GTK+. gnu: girara: Enable more features. gnu: girara: Update synopsis & description. That makes it possible to revert some of these changes in case of problems without undoing the whole thing, and also makes reviewing easier. I'm also skeptical about some of these (why is #:glib-or-gtk? necessary for this library, why does GTK+ no longer need to be propagated, and what are all those new inputs for?). By lumping everything together it's difficult to reason about these changes. > From 7e3558dda412d33fffb7bb0668886f1ede3d14c8 Mon Sep 17 00:00:00 2001 > From: Raghav Gururajan > Date: Sat, 2 May 2020 23:29:28 -0400 > Subject: [PATCH 09/14] gnu: zathura: Update package definition. > > * gnu/packages/pwmt.scm (zathura): > [arguments]<#:glib-or-gtk?>: New argument. > [native-inputs] sphinx-rtd-theme>: New inputs. Same here, what do these inputs do? > [inputs] libseccomp>: New inputs. And these? > [propagated-inputs]: Removed. > [synopsis]: Updated. > [description]: Updated. ISTM this could be split into at least four different patches. > From 345a2b2ffc04c99fdfc3785ac6d19f053afd1b90 Mon Sep 17 00:00:00 2001 > From: Raghav Gururajan > Date: Sat, 2 May 2020 23:42:49 -0400 > Subject: [PATCH 10/14] gnu: zathura-ps: Update package definition. > > * gnu/packages/pwmt.scm (zathura-ps): > [arguments]<#:glib-or-gtk?>: New argument. Why does this plugin package need #:glib-or-gtk?. > [inputs]: New inputs. It's strange that all of these packages require almost the exact same set of inputs. Perhaps they should be propagated somewhere? > [synopsis]: Updated. > [description]: Updated. This should also be a separate patch. I think you catch my drift here, can you send an updated series? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl6zFPMACgkQoqBt8qM6 VPoFcAgAlXd5PowbqJHqQZ9y2WDCOndKJiPCCah2xV1GquLmA6S0cnZ4hikZYCUS ArzLl/9vjTkA6zDdEnHIiywPJerTwdrI5gpgIQ+7H/bhB+Os3SH0eR+MJkjuGlGt 2PH7J9dxC7Pqe/gMlxB1ZAL5uCPAeno6PTpolIRigEznxUiRXxTVu/M8047xQmUU Tli4IXx/2LAl2WLcUrYDC8K9kpkXLmuU8dBahnDmzak8S6j2Nqv1sl1NSWqekZc2 7uWO+ULXE5yFsRHKJftsa9aWb4vcYxaCvAngzWrCzEvW4ZWpc1t87IpmSWv6sB9E 1IRFeDn87X2kRiek42WCQZm2lFoMhg== =eg5S -----END PGP SIGNATURE----- --=-=-=--