From: Mathieu Othacehe <m.othacehe@gmail.com>
To: Stefan <stefan-guix@vodafonemail.de>
Cc: 41011@debbugs.gnu.org
Subject: [bug#41011] [PATCH] gnu: grub: Support for network boot via tftp/nfs.
Date: Sun, 10 May 2020 10:20:28 +0200 [thread overview]
Message-ID: <87a72gi4kz.fsf@gmail.com> (raw)
In-Reply-To: <9AAFEFF4-8ACE-4C95-975F-67C3F4FDAF81@vodafonemail.de> (Stefan's message of "Fri, 1 May 2020 22:32:44 +0200")
Hello Stefan,
This patch does not apply here. Could you rebase it on top of master?
> -
> - ;; Intel and EFI systems need to be switched into graphics mode, whereas
> - ;; most other modern architectures have no other mode and therefore
> - ;; don't need to be switched.
> -
> - ;; XXX: Do we really need to restrict to x86 systems? We could imitate
> - ;; what the GRUB default configuration does and decide based on whether
> - ;; a user provided 'gfxterm' in the terminal-outputs field of their
> - ;; bootloader-configuration record.
> - (if (string-match "^(x86_64|i[3-6]86)-" system)
> - (format #f "
> + (format #f "
> set gfxmode=~a
> insmod all_video
> - insmod gfxterm~%" gfxmode)
> - "")))
> + insmod gfxterm~%"
> + (string-join
> + (grub-gfxmode (bootloader-theme config))
> + ";")))
Why not enable graphic mode only if 'gfxterm' is provided in
terminal-outputs fields, like suggested by the comment?
> + (efi-bootloader-link (string-append "boot"
> + (match arch
> + ("i686" "ia32")
> + ("x86_64" "x64")
> + ("armhf" "arm")
If cross-building for "arm-linux-gnueabihf", arch will be "arm" and
won't match anything here.
> + (catch 'system-error
> + (lambda () (delete-file efi-bootloader-link))
> + (lambda _ #f))
You can use "false-if-exception" here I think.
> + (symlink #$efi-bootloader
> + efi-bootloader-link)
> + (catch 'system-error
> + (lambda () (delete-file store-link))
> + (lambda _ #f))
Same here.
> +(define* (grub-efi-net-bootloader #:key (target #f) (efi-subdir #f))
#f if implicit if omitted.
> + (let ((target (or target "boot"))
> + (efi-subdir (or efi-subdir "efi/boot")))
It would be better to keep grub-efi-net-bootloader as a variable, like
all other bootloaders. You could default configuration-file to
"boot/efi/boot/grub.cfg" instead?
Thanks,
Mathieu
next prev parent reply other threads:[~2020-05-10 8:20 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 20:32 [bug#41011] [PATCH] gnu: grub: Support for network boot via tftp/nfs Stefan
2020-05-10 8:20 ` Mathieu Othacehe [this message]
2020-05-10 21:13 ` Stefan
2020-05-18 21:43 ` Stefan
2020-05-21 15:07 ` Stefan
2020-05-21 18:40 ` Stefan
2020-05-23 8:10 ` Mathieu Othacehe
2020-05-24 0:22 ` Stefan
2020-05-23 8:02 ` Mathieu Othacehe
2020-05-24 10:18 ` Stefan
2020-05-24 11:00 ` Danny Milosavljevic
2020-05-24 13:09 ` Stefan
2020-05-24 13:42 ` Danny Milosavljevic
2020-05-24 13:58 ` Danny Milosavljevic
2020-05-24 17:06 ` Stefan
2020-05-24 16:47 ` Stefan
2020-06-06 13:30 ` Stefan
2020-06-06 13:33 ` Stefan
2020-06-06 17:37 ` Danny Milosavljevic
[not found] ` <46CD97B3-9994-4AB7-AA7D-4DE39AB7A238@vodafonemail.de>
2020-06-09 13:44 ` Danny Milosavljevic
2020-06-09 14:25 ` Stefan
2020-06-11 4:21 ` Maxim Cournoyer
2020-06-11 11:36 ` Stefan
2020-06-11 13:07 ` Maxim Cournoyer
2020-06-11 13:19 ` Danny Milosavljevic
2020-06-12 14:41 ` Stefan
2020-06-14 18:56 ` Maxim Cournoyer
2020-06-11 23:43 ` [bug#41820] [PATCH] file-systems: Add record type <nfs-share> for a file system device Stefan
2020-06-20 13:52 ` Stefan
2020-06-12 0:06 ` [bug#41011] [PATCH] gnu: grub: Support for network boot via tftp/nfs Stefan
2020-06-14 19:09 ` Maxim Cournoyer
2020-06-17 13:12 ` Stefan
2020-09-05 11:25 ` Stefan
2020-09-06 13:07 ` Stefan
2020-09-06 14:35 ` Danny Milosavljevic
2020-09-06 15:14 ` Danny Milosavljevic
2020-09-07 22:59 ` Stefan
2020-09-08 22:37 ` Danny Milosavljevic
2020-09-13 17:46 ` [bug#41011] [PATCH] gnu: grub: Support for network boot via TFTP Stefan
2020-09-14 6:59 ` Efraim Flashner
2020-09-15 20:28 ` Stefan
2020-09-16 7:51 ` Efraim Flashner
2020-09-19 17:54 ` Stefan
2020-09-20 11:47 ` Stefan
2020-09-20 11:56 ` Stefan
2020-09-26 10:52 ` Stefan
2020-09-26 10:54 ` Stefan
2020-09-26 16:13 ` Danny Milosavljevic
2020-09-27 10:50 ` Stefan
2020-09-27 10:51 ` Stefan
2020-09-27 11:47 ` Danny Milosavljevic
2020-09-14 12:34 ` Danny Milosavljevic
2020-09-15 22:10 ` Danny Milosavljevic
2020-09-27 11:57 ` bug#41011: " Stefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a72gi4kz.fsf@gmail.com \
--to=m.othacehe@gmail.com \
--cc=41011@debbugs.gnu.org \
--cc=stefan-guix@vodafonemail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).