From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uHMKM73X515TagAA0tVLHw (envelope-from ) for ; Mon, 15 Jun 2020 20:19:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 0GzkLr3X5165SQAAB5/wlQ (envelope-from ) for ; Mon, 15 Jun 2020 20:19:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CD4C7940A68 for ; Mon, 15 Jun 2020 20:19:08 +0000 (UTC) Received: from localhost ([::1]:53232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkvZS-0004t8-GL for larch@yhetil.org; Mon, 15 Jun 2020 16:19:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkvZO-0004su-4f for guix-patches@gnu.org; Mon, 15 Jun 2020 16:19:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36014) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jkvZN-0005Sk-Qd for guix-patches@gnu.org; Mon, 15 Jun 2020 16:19:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jkvZN-0000Ns-M5 for guix-patches@gnu.org; Mon, 15 Jun 2020 16:19:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#39258] [PATCH 2/4] ui: Use string matching with literal search strings. Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 15 Jun 2020 20:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39258 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 39258@debbugs.gnu.org, zimoun Received: via spool by 39258-submit@debbugs.gnu.org id=B39258.15922523261455 (code B ref 39258); Mon, 15 Jun 2020 20:19:01 +0000 Received: (at 39258) by debbugs.gnu.org; 15 Jun 2020 20:18:46 +0000 Received: from localhost ([127.0.0.1]:47560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkvZ8-0000NP-Az for submit@debbugs.gnu.org; Mon, 15 Jun 2020 16:18:46 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:47076) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkvZ4-0000ND-Ke for 39258@debbugs.gnu.org; Mon, 15 Jun 2020 16:18:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XTjt+hL6kTgRtgDdRGuFat1EXlW6tKcxy5xWcfA8ysE=; b=f5Odcm9OWeOjxnPoMgE8ILZXW /47MNizWrCMuL3jqkHOi+ZUU2vRoj+Dcq+0Ps8Sz/n8tEl2WHBtVzhPN1MI+s8UlUAiWK6Qo6Dfn1 009N+KfykymAAebw3vjVoQh6nzAJi5cmnBUwdonF6Y6A+yvXkN23O5I+xfuAIFwXbk68U=; Received: from [192.168.2.1] (helo=steel) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jkvYz-001RD6-1b; Tue, 16 Jun 2020 01:48:37 +0530 From: Arun Isaac In-Reply-To: <87ftayzrqi.fsf@gnu.org> References: <20200601000030.7443-1-arunisaac@systemreboot.net> <20200601000030.7443-3-arunisaac@systemreboot.net> <87y2owmyf3.fsf@gnu.org> <87ftayzrqi.fsf@gnu.org> Date: Tue, 16 Jun 2020 01:48:31 +0530 Message-ID: <87a714nkvc.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=systemreboot.net header.s=default header.b=f5Odcm9O; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -2.01 X-TUID: lCmmqdzJ/cpW --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >> So, shall I push the remaining patches (patches 1, 3, 4) after applying >> the change you suggested for patch 1 (use of if versus cond)? > > Yes, definitely! Done! >>>> * guix/scripts/package.scm (process-query): Make search query a regexp= only if >>>> it is not a literal search string. >>>> * guix/ui.scm (relevance): Use string matching with literal search str= ings and >>>> regexp matching with regexp search strings. >>> >>> How does this affect performance? > > (To be clear, I=E2=80=99m referring specifically to this patch.) Oh, I misunderstood. Here are the results specifically comparing patch 2 against the latest master (that includes the patches 1, 3 and 4 I just pushed). All readings are on a warm cache. |----------------------------------+--------+-------| | query | before | after | |----------------------------------+--------+-------| | guix search strategy game | 2.1 | 1.7 | | guix search strategy game caesar | 1.8 | 1.5 | |----------------------------------+--------+-------| --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAl7n15cACgkQLiXui2GA K7NgJgf/YrTf2gVKPTV6D930QUmTCTHK7+62b4y5WuOU5UxZWcgizs6iZD3AoVq8 E39md5kiA7qECfA+YFfBIEA9LgRLdlRYyKm4+WWdDIdbEaFiYAyiVw3hA5seu4/n 7wPgK7tQTU0vv5yi7ovG2aIezkkw/9TOATEJRerKIlzK/TsThpBBCftnxiIHJ9z9 2WD5wfxh7UHGBbRMQ5mkPIfmx1UVLoRBAdeFU+vCZ/CWOwh6uU8VwFYWEV9tmYM/ 0hVqS8LowgmzytBPn+G5sbI6+hffMAvHJXkJoesazrQLxnQWYW3ew1Y/ogYbeOBa LqkYT9uXy3+EqfqoPETsYwCus/DWfg== =92VK -----END PGP SIGNATURE----- --=-=-=--