From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 4BJpEoQLe1/qSQAA0tVLHw (envelope-from ) for ; Mon, 05 Oct 2020 12:03:16 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uMUKDoQLe1/ENgAAB5/wlQ (envelope-from ) for ; Mon, 05 Oct 2020 12:03:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A65F49404E1 for ; Mon, 5 Oct 2020 12:03:15 +0000 (UTC) Received: from localhost ([::1]:47836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPPCz-0003lE-OY for larch@yhetil.org; Mon, 05 Oct 2020 08:03:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPPCo-0003jC-0a for guix-patches@gnu.org; Mon, 05 Oct 2020 08:03:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36631) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kPPCn-0002SE-Nk for guix-patches@gnu.org; Mon, 05 Oct 2020 08:03:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kPPCn-00088h-Ki for guix-patches@gnu.org; Mon, 05 Oct 2020 08:03:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43769] [PATCH v2 1/2] guix-install.sh: Add symbolic links for supported shell completions. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 05 Oct 2020 12:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43769 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: Tobias Geerinckx-Rice , 43769@debbugs.gnu.org Received: via spool by 43769-submit@debbugs.gnu.org id=B43769.160189934531240 (code B ref 43769); Mon, 05 Oct 2020 12:03:01 +0000 Received: (at 43769) by debbugs.gnu.org; 5 Oct 2020 12:02:25 +0000 Received: from localhost ([127.0.0.1]:48177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPPCD-00087o-FT for submit@debbugs.gnu.org; Mon, 05 Oct 2020 08:02:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPPC9-00087Z-CH for 43769@debbugs.gnu.org; Mon, 05 Oct 2020 08:02:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57233) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPPC3-0002Of-9T; Mon, 05 Oct 2020 08:02:15 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=35020 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kPPC2-0004jw-Ek; Mon, 05 Oct 2020 08:02:15 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201002173537.12045-1-zimon.toutoune@gmail.com> <20201003184447.9542-1-zimon.toutoune@gmail.com> <87pn5z9lb5.fsf@nckx> <87h7r95c1a.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 14 =?UTF-8?Q?Vend=C3=A9miaire?= an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 05 Oct 2020 14:02:13 +0200 In-Reply-To: (zimoun's message of "Mon, 5 Oct 2020 11:23:22 +0200") Message-ID: <87a6x03mpm.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: nZcAojE4+tW9 zimoun skribis: > On Mon, 5 Oct 2020 at 10:09, Ludovic Court=C3=A8s wrote: >> Tobias Geerinckx-Rice skribis: >> >> > Why bother the user with this? We don't ask before installing >> > /etc/profile.d/guix.sh, or enabling the daemon, and we shouldn't >> > offer similar meaningless choices just for the sake of it. >> >> Yeah, I think we can install completions without asking (but still >> printing a line about it.) > > As we talked with nckx yesterday on IRC, from my point of view, it is > impolite to install stuff behind the user. Like Tobias wrote, the script is already doing that. (It=E2=80=99s also widespread practice these days: favor ease of use and installation speed over fine-grained user control.) > Well, to be concrete, I suggest either: a) add a comment in the > Warning Note in the manual saying that /etc/profile.d and shell > competitions will be installed or b) ask a global question in > guix-install.sh about these. WDYT? I think it=E2=80=99s fine to just drop the completion files in the right pl= ace: it=E2=80=99s what users expect. But we should still have an INFO line sayi= ng these are being installed, as a matter of transparency. Thanks, Ludo=E2=80=99.