From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id f3EuFhpVe18UfAAA0tVLHw (envelope-from ) for ; Mon, 05 Oct 2020 17:17:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id oLhjERpVe1+yGgAAB5/wlQ (envelope-from ) for ; Mon, 05 Oct 2020 17:17:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 69B3E940414 for ; Mon, 5 Oct 2020 17:17:13 +0000 (UTC) Received: from localhost ([::1]:59802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPU6o-0000tS-NA for larch@yhetil.org; Mon, 05 Oct 2020 13:17:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51756) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPU6g-0000s2-HM for guix-patches@gnu.org; Mon, 05 Oct 2020 13:17:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38889) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kPU6g-0004jH-8n for guix-patches@gnu.org; Mon, 05 Oct 2020 13:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kPU6g-00067Z-5l for guix-patches@gnu.org; Mon, 05 Oct 2020 13:17:02 -0400 Subject: bug#43494: [PATCH v2 4/4] services: guix: Add guix-build-coordinator-queue-builds-service-type. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Mon, 05 Oct 2020 17:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 43494 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 43494-done@debbugs.gnu.org Mail-Followup-To: 43494@debbugs.gnu.org, mail@cbaines.net, mail@cbaines.net Received: via spool by 43494-done@debbugs.gnu.org id=D43494.160191819123486 (code D ref 43494); Mon, 05 Oct 2020 17:17:02 +0000 Received: (at 43494-done) by debbugs.gnu.org; 5 Oct 2020 17:16:31 +0000 Received: from localhost ([127.0.0.1]:50433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPU6B-00066j-BY for submit@debbugs.gnu.org; Mon, 05 Oct 2020 13:16:31 -0400 Received: from mira.cbaines.net ([212.71.252.8]:48358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPU68-00066V-7g for 43494-done@debbugs.gnu.org; Mon, 05 Oct 2020 13:16:29 -0400 Received: from localhost (92.41.184.114.threembb.co.uk [92.41.184.114]) by mira.cbaines.net (Postfix) with ESMTPSA id 4A31F27BBE8; Mon, 5 Oct 2020 18:16:27 +0100 (BST) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 15edbad6; Mon, 5 Oct 2020 17:16:24 +0000 (UTC) References: <20200919101059.8930-1-mail@cbaines.net> <20200919101059.8930-4-mail@cbaines.net> <87y2kl5cg8.fsf@gnu.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines In-reply-to: <87y2kl5cg8.fsf@gnu.org> Date: Mon, 05 Oct 2020 18:16:22 +0100 Message-ID: <87a6x01tll.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: UxKl1IOcxYmL --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi Chris, > > Sorry for the delay. Patches 1=E2=80=933 LGTM! One minor comment on pat= ch 4: > > Christopher Baines skribis: > >> * gnu/services/guix.scm (): >> New record type. >> (guix-build-coordinator-queue-builds-configuration, >> guix-build-coordinator-queue-builds-configuration?, >> guix-build-coordinator-queue-builds-configuration-package, >> guix-build-coordinator-queue-builds-configuration-user, >> guix-build-coordinator-queue-builds-coordinator, >> guix-build-coordinator-queue-builds-configuration-systems, >> guix-build-coordinator-queue-builds-configuration-system-and-targets, >> guix-build-coordinator-queue-builds-configuration-guix-data-service, >> guix-build-coordinator-queue-builds-configuration-processed-commits-file, >> guix-build-coordinator-queue-builds-shepherd-services, >> guix-build-coordinator-queue-builds-activation, >> guix-build-coordinator-queue-builds-account): New procedures. >> (guix-build-coordinator-queue-builds-service-type): New variable. > > [...] > >>=20=20 >> +@defvar {Scheme Variable} guix-build-coordinator-queue-builds-service-t= ype >> +Service type for the >> +guix-build-coordinator-queue-builds-from-guix-data-service script. Its >> +value must be a @code{guix-build-coordinator-queue-builds-configuration} >> +object. >> +@end defvar > > Could you add a paragraph right above this explaining what this service > is about? > >> +(define guix-build-coordinator-queue-builds-service-type >> + (service-type >> + (name 'guix-build-coordinator-queue-builds) >> + (extensions >> + (list >> + (service-extension shepherd-root-service-type >> + guix-build-coordinator-queue-builds-shepherd-se= rvices) >> + (service-extension activation-service-type >> + guix-build-coordinator-queue-builds-activation) >> + (service-extension account-service-type >> + guix-build-coordinator-queue-builds-account))) >> + (description >> + "Run the Guix Build Coordinator queue builds script."))) > > Likewise it=E2=80=99d be great if you could add a few works here. > > OK to push with these changes, thank you! I've tried to add some clarity in the places you mention. I'm still very tempted to make a separate repository/package for the queue builds from Guix Data Service script... I'm not quite decided yet though. Anyway, thanks for taking another look. I've gone ahead and pushed these patches as c14714cbbfe9239410aec2ed73282192a64fbbdc. I did tweak the package definition a bit though to move closer to being able to cross-compile it (you can now if you tweak the inputs). Thanks again, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl97VOZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XelCRAAi3Ihs57Jxpd29ZfQX/6QqK8LTMWGs8dQ juPk6/Yl0DzaxcEeuzf+TPR0t/zuDCzucv9g0+bx4ohPTN08MPoGT6y+tdY1zDNh 7MxSYiLiM8IOLxDwPoB6LoFTyUcsV3EJNbfrdf3fN3IEwTd8y9HOBrRuCT46lRNc 03ku7yL44JhiHotzg1YWY+si2y/OAAPb4s0iP7Chx9ppLdvyqANcV0leuVJrtP3y itb23Gb9BCmSfFobEeI3xo4se6LsXqpYj8fq3kGipC4DCoWkZiA99gW4UiY3C4+h d2zmElR4+x2lcAQD2Z8SLWK/5bej1iWeJ7q8OvuAgRJS6LlDTkxxI73m8frqnui0 EGZGonG+UrXmsM9h/Pp7aIQU+C5rDu7u3NqmG+WeeDjgJTD5vorkpKhMwDfeH6sL BSsMWiUvEpwWMx2MqYOZSo3qn8wIb/HfUFAZNNrWhasCygOTWaKOgm5IdfVbSENO wxve8VPF6UG26diVc/1OaDBmMdao7+L9eU+CHD/J/U9xVcRBGPdZ8ATFJfKTOUnT myusPwsdTYNM1AAdZFVev0sOrRhmW6lWh117n8ideJ68w4ldpK9s70Ln+IfTPbUx jKlSiKn0dYOui61oag0EFwJrm3uWJEBggLd7TUC9Gp+tZwpDuFsYJCIULHkJeXC9 sWHkqe4RtGo= =pTf2 -----END PGP SIGNATURE----- --=-=-=--