From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id MNZoJ+hXhV94ZwAA0tVLHw (envelope-from ) for ; Tue, 13 Oct 2020 07:31:52 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id mIxEI+hXhV+QKgAAbx9fmQ (envelope-from ) for ; Tue, 13 Oct 2020 07:31:52 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0E2379403CA for ; Tue, 13 Oct 2020 07:31:52 +0000 (UTC) Received: from localhost ([::1]:56226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSEmk-0005Fe-Q2 for larch@yhetil.org; Tue, 13 Oct 2020 03:31:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSEm0-0004iS-Fg for guix-patches@gnu.org; Tue, 13 Oct 2020 03:31:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33473) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kSElz-0004mE-04 for guix-patches@gnu.org; Tue, 13 Oct 2020 03:31:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kSEly-0000yw-8Z for guix-patches@gnu.org; Tue, 13 Oct 2020 03:31:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43809] [PATCH v2] gnu: emacs-tuareg: Update to 2.2.0-0.ccde45b. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 13 Oct 2020 07:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43809 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: 43809@debbugs.gnu.org Received: via spool by 43809-submit@debbugs.gnu.org id=B43809.16025742373732 (code B ref 43809); Tue, 13 Oct 2020 07:31:02 +0000 Received: (at 43809) by debbugs.gnu.org; 13 Oct 2020 07:30:37 +0000 Received: from localhost ([127.0.0.1]:45016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSElY-0000y8-Vs for submit@debbugs.gnu.org; Tue, 13 Oct 2020 03:30:37 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:55959) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSElX-0000xs-5d for 43809@debbugs.gnu.org; Tue, 13 Oct 2020 03:30:35 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id B638FC0015; Tue, 13 Oct 2020 07:30:28 +0000 (UTC) From: Nicolas Goaziou References: <20201005072342.17369-1-zimon.toutoune@gmail.com> <20201008222532.19034-1-zimon.toutoune@gmail.com> Date: Tue, 13 Oct 2020 09:30:27 +0200 In-Reply-To: <20201008222532.19034-1-zimon.toutoune@gmail.com> (zimoun's message of "Fri, 9 Oct 2020 00:25:32 +0200") Message-ID: <87a6wq60rw.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: ZFJvkxKeMny6 Hello, zimoun writes: > * gnu/packages/ocaml.scm (emacs-tuareg): Update to 2.2.0-0.ccde45b. Thank you. > + ;; Last upstream release on Sept., 14th, 2018, since then "Package cl > + ;; deprecated" or 'lexical-binding' and others had been fixed. > + (let ((commit "ccde45bbc292123ec20617f1af7f7e19f7481545")) > + (package > + (name "emacs-tuareg") > + (version (git-version "2.2.0" "0" commit)) I suggest to bind "0" to `revision' instead of hard-coding it here. Otherwise, LGTM. > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/ocaml/tuareg") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "1yxv4bnqarilnpg5j7wywall8170hwvm0q4xx06yqjgcn8pq1lac")))) > + (build-system gnu-build-system) I assume emacs-build-system is not an option, right? Regards, -- Nicolas Goaziou