From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 43809@debbugs.gnu.org
Subject: [bug#43809] [PATCH v2] gnu: emacs-tuareg: Update to 2.2.0-0.ccde45b.
Date: Tue, 13 Oct 2020 09:30:27 +0200 [thread overview]
Message-ID: <87a6wq60rw.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20201008222532.19034-1-zimon.toutoune@gmail.com> (zimoun's message of "Fri, 9 Oct 2020 00:25:32 +0200")
Hello,
zimoun <zimon.toutoune@gmail.com> writes:
> * gnu/packages/ocaml.scm (emacs-tuareg): Update to 2.2.0-0.ccde45b.
Thank you.
> + ;; Last upstream release on Sept., 14th, 2018, since then "Package cl
> + ;; deprecated" or 'lexical-binding' and others had been fixed.
> + (let ((commit "ccde45bbc292123ec20617f1af7f7e19f7481545"))
> + (package
> + (name "emacs-tuareg")
> + (version (git-version "2.2.0" "0" commit))
I suggest to bind "0" to `revision' instead of hard-coding it here.
Otherwise, LGTM.
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/ocaml/tuareg")
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "1yxv4bnqarilnpg5j7wywall8170hwvm0q4xx06yqjgcn8pq1lac"))))
> + (build-system gnu-build-system)
I assume emacs-build-system is not an option, right?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-10-13 7:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 7:23 [bug#43809] [PATCH 0/1] gnu: emacs-tuareg: Update to 2.2.0-0.ccde45b zimoun
2020-10-05 7:25 ` [bug#43809] [PATCH 1/1] " zimoun
2020-10-07 19:43 ` Nicolas Goaziou
2020-10-08 22:28 ` zimoun
2020-10-08 22:25 ` [bug#43809] [PATCH v2] " zimoun
2020-10-13 7:30 ` Nicolas Goaziou [this message]
2020-10-13 8:34 ` zimoun
2020-10-13 9:36 ` Nicolas Goaziou
2020-10-13 10:53 ` zimoun
2020-10-19 7:58 ` zimoun
2020-10-19 15:20 ` Nicolas Goaziou
2020-10-19 18:34 ` zimoun
2020-10-19 20:48 ` bug#43809: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6wq60rw.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=43809@debbugs.gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).