From: Arun Isaac <arunisaac@systemreboot.net>
To: Niklas Eklund <niklas.eklund@posteo.net>, 44798-done@debbugs.gnu.org
Subject: bug#44798: [PATCH] gnu: Add emacs-embark
Date: Tue, 24 Nov 2020 00:15:09 +0530 [thread overview]
Message-ID: <87a6v7syiy.fsf@systemreboot.net> (raw)
In-Reply-To: <8736118q70.fsf@posteo.net>
Thanks for the patch! I pushed to master with the following minor edits.
> + ;; There are no tagged releases upstream on gitlab, instead we are using
> + ;; the most recent commit.
I think you meant github, not gitlab.
> + (let ((commit "dc20b4e53c4ce1ad91100dfeb093115f2cc0b210")
> + (revision "0"))
> + (package
> + (name "emacs-embark")
> + (version (git-version "0.6" revision commit))
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/oantolin/embark")
> + (commit commit)))
> + (sha256
> + (base32 "1jrvdlwip7zll5ixlnk9l0apr8hj60ysqfc47q3k4hhfyl9rawbq"))
> + (file-name (git-file-name name version))))
> + (build-system emacs-build-system)
> + (propagated-inputs
> + `(("emacs-avy" ,emacs-avy)))
> + (home-page "https://github.com/oantolin/embark")
> + (synopsis "Emacs Mini-Buffer Actions Rooted in Keymaps")
I capitalized only the first letter of the first word---Emacs. I
downcased the rest.
> + (description
> + "This package provides a command embark-act (and a variant
> +embark-act-noexit), to execute actions on the top minibuffer completion
> +canidate: the one that would be chosen by minibuffer-force-complete")
I started the string "This package..." on the same line as description,
and added a period after minibuffer-force-complete.
prev parent reply other threads:[~2020-11-23 18:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-22 13:40 [bug#44798] [PATCH] gnu: Add emacs-embark Niklas Eklund
2020-11-23 18:45 ` Arun Isaac [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6v7syiy.fsf@systemreboot.net \
--to=arunisaac@systemreboot.net \
--cc=44798-done@debbugs.gnu.org \
--cc=niklas.eklund@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).