unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Greg Hogan <code@greghogan.com>
Cc: 45727@debbugs.gnu.org
Subject: [bug#45727] [PATCH] gnu: folly: Update to 2021.01.04.00.
Date: Tue, 19 Jan 2021 15:59:21 +0100	[thread overview]
Message-ID: <87a6t5ht12.fsf@gnu.org> (raw)
In-Reply-To: <CA+3U0ZnMy7UBTU8DQi7P5VtKueSHQPUq=7saNFnBesXcx5_4CQ@mail.gmail.com> (Greg Hogan's message of "Fri, 8 Jan 2021 07:19:34 -0500")

Hi Greg,

Greg Hogan <code@greghogan.com> skribis:

> I went to build folly against core-updates and the link failed due to
> missing dependencies on libicu*. This patch also updates the folly version.
>
>
>>From e710c98a2f5beef9d8640bf3618ae20bd12c12f7 Mon Sep 17 00:00:00 2001
> From: Greg Hogan <code@greghogan.com>
> Date: Thu, 7 Jan 2021 21:54:37 +0000
> Subject: [PATCH] gnu: folly: Update to 2021.01.04.00.
>
> * gnu/packages/cpp.scm (folly): Update to 2021.01.04.00.
> [propagated-inputs]: Add icu4c.

If there’s a reason to propagate ICU4C, could you state it in a comment?
Otherwise, can we just move it to ‘inputs’?

Apart from that it LGTM, and it’s applicable to ‘master’.

Could you send an updated patch?

Thanks,
Ludo’.




  reply	other threads:[~2021-01-19 15:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08 12:19 [bug#45727] [PATCH] gnu: folly: Update to 2021.01.04.00 Greg Hogan
2021-01-19 14:59 ` Ludovic Courtès [this message]
2021-01-26 21:55   ` Greg Hogan
2021-01-26 22:31     ` Ludovic Courtès
2021-01-26 21:57   ` Greg Hogan
2021-01-26 22:41     ` bug#45727: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6t5ht12.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=45727@debbugs.gnu.org \
    --cc=code@greghogan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).