From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KLihI2c7iGCHxgAAgWs5BA (envelope-from ) for ; Tue, 27 Apr 2021 18:27:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id QNFMH2c7iGAqXQAAB5/wlQ (envelope-from ) for ; Tue, 27 Apr 2021 16:27:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DC05ADFFC for ; Tue, 27 Apr 2021 18:27:18 +0200 (CEST) Received: from localhost ([::1]:52916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbQYP-00043O-Uz for larch@yhetil.org; Tue, 27 Apr 2021 12:27:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbQYA-00042p-Mb for guix-patches@gnu.org; Tue, 27 Apr 2021 12:27:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39184) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lbQYA-0007V3-4M for guix-patches@gnu.org; Tue, 27 Apr 2021 12:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lbQY9-0007P7-W7 for guix-patches@gnu.org; Tue, 27 Apr 2021 12:27:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48059] [PATCH] gnu: python-libtmux: Fix build by removing tests broken by tmux update Resent-From: Edouard Klein Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 27 Apr 2021 16:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48059 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice Cc: 48059@debbugs.gnu.org, edouard@hex.lan X-Debbugs-Original-Cc: 48059@debbugs.gnu.org, guix-patches@gnu.org, Edouard Klein Received: via spool by submit@debbugs.gnu.org id=B.161954079028421 (code B ref -1); Tue, 27 Apr 2021 16:27:01 +0000 Received: (at submit) by debbugs.gnu.org; 27 Apr 2021 16:26:30 +0000 Received: from localhost ([127.0.0.1]:50730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbQXe-0007OL-FE for submit@debbugs.gnu.org; Tue, 27 Apr 2021 12:26:30 -0400 Received: from lists.gnu.org ([209.51.188.17]:53848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbQXY-0007O2-PD for submit@debbugs.gnu.org; Tue, 27 Apr 2021 12:26:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54886) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbQXY-0003lZ-GS for guix-patches@gnu.org; Tue, 27 Apr 2021 12:26:24 -0400 Received: from sender4-op-o11.zoho.com ([136.143.188.11]:17104) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbQXU-0007Hj-6r for guix-patches@gnu.org; Tue, 27 Apr 2021 12:26:22 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1619540775; cv=none; d=zohomail.com; s=zohoarc; b=MAvM8s6IOvPPg074d3+t8AxLWPyEnAXb/oslKDkjwiD9tiYhAP0bklCHYpyfy4wom1EbwCRpXItX5MFO835xdowcyo68PfH7+MQiETmZhseYtbs7kkJoF/353yv+p7H6M9HQfwCnxyoTp8+dPWIPGO1POBPMYXmgWQoeLd7akmI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619540775; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=g0GOWgVjvRWjSp6CCHyP6/OEHrr3mrtnEZsG/ZKMV3k=; b=hwZW7cWHSnQRvphhJSohtolhnBNgGn67xXVJkgXuNtRNxeGvxE8WTZ+j4sbV55TgFdtaF2GKXwz559GQ8Yl6wDW+MUeqeZ6qdaa7bsw0DdPqoYhTYvlWkoXNV2D1MWU4aLzB4PBs1DTJeqX8gAnae/4F1m0u6YrxBm5oOS6+aow= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=rdklein.fr; spf=pass smtp.mailfrom=edou@rdklein.fr; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1619540775; s=zoho; d=rdklein.fr; i=edou@rdklein.fr; h=References:From:To:Cc:Subject:In-reply-to:Message-ID:Date:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=g0GOWgVjvRWjSp6CCHyP6/OEHrr3mrtnEZsG/ZKMV3k=; b=QpP1GCXKk3eK2AUfvzG2ooc8ZerrhPCbdQEmGuSh+NqHijVNCl3zn6Fnb1Fh+UM5 2yATr2SlTUngiQDFcA5rYeXgUHEUVS8hJjeYTj2bEEpVp/vGJb4gJcXOoT6FwHFlUOx nFa8BBIXVcsHpUbiICfwFOwxpTx5guOscDDv6hVM= Received: from hex (lfbn-idf3-1-808-29.w90-3.abo.wanadoo.fr [90.3.133.29]) by mx.zohomail.com with SMTPS id 1619540770172436.02078773440644; Tue, 27 Apr 2021 09:26:10 -0700 (PDT) References: <20210427132000.176985-1-edk@beaver-labs.com> <8735vbsv7j.fsf@nckx> User-agent: mu4e 1.4.15; emacs 27.2 From: Edouard Klein In-reply-to: <8735vbsv7j.fsf@nckx> Message-ID: <87a6pjofuv.fsf@rdklein.fr> Date: Tue, 27 Apr 2021 18:24:24 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.188.11; envelope-from=edou@rdklein.fr; helo=sender4-op-o11.zoho.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619540839; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=g0GOWgVjvRWjSp6CCHyP6/OEHrr3mrtnEZsG/ZKMV3k=; b=gQguVZVAoh6Ogzc48HwnHJ4dWDpkaK1PTYhj7oC9okHfxD3ipT5b8XPx036Be2PRwmgI4c Y206RI7KMS9ZO2t1nC9j2m00xRUeYZmiENg3GgWnO5t2sJJC6T4Nx7yurPXHMVxa/y0Ge+ WJd8xK8IeCIZbtatIaJogACMHG1/VoInmEfIO2AIAjVgIuyJSFzlR6I1Pc+eS3tjFvZhlO Cf6LSyG/g5Hw35skGj+tMIYmZamkL+BZSA7q+r1WPMdQ6vXhoPD6CMYfnVtc6A8GXrzebS wgD71s5E4LxkNRoJ1GjNnz7f38adxJGVgha+rNjrtAGVJFvtSfH2e3G1t2nMug== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1619540839; a=rsa-sha256; cv=fail; b=KAmqPfQIeBY/vtStDIicUVzDIu3c0JZc/OzyfViwDhEKYLKs00ePoe5Ezq2ezrqEpSvG7k 5oZ/GcP/WxgvUVVKDOgtZbde1/B7S812qnlC4oty1wUlyYK7ED5Kcrdu4anOWL68kt5Hqx J/9T+xln/RZHXaUunuAX3e4/xIemcpsSdNHDbQNbcJfBQLaFVjqtkcDqZsgZFXe0TL7Fwk v7pM+StV42wRIIN4/XjnPLHVlBmdClgT9g28drt9w5Bpc7cemRKBuM3wSPBz1B4dq+f3AA wGPhukUv1VkUiXyjq0HUHJQgV4KP5win8ilr0yR9dOGCiZHixfyyjsmJRrrGLw== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=none ("invalid DKIM record") header.d=rdklein.fr header.s=zoho header.b=QpP1GCXK; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -0.45 Authentication-Results: aspmx1.migadu.com; dkim=none ("invalid DKIM record") header.d=rdklein.fr header.s=zoho header.b=QpP1GCXK; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: DC05ADFFC X-Spam-Score: -0.45 X-Migadu-Scanner: scn0.migadu.com X-TUID: IOAn2sLRDUoB Tobias Geerinckx-Rice writes: > Edouard, > > Edouard Klein =E5=86=99=E9=81=93=EF=BC=9A >> tmux update from 3.1c to 3.2 breaks two tests in this package by quoting= the >> returned value of a tmux call. No harm done, a fix upstream is unlikely. > > Hm... why's that? Does upstream not support their own test suite? > The issue I opened last year about the two other tests failing is still unresolved https://github.com/tmux-python/libtmux/issues/281 There seems to be little ongoing development: https://github.com/tmux-python/libtmux/commits/master My suspicion is that the maintainer is using debian or another slow distro that still use tmux 2, which I believe make the test pass (at leat it did when I tested it last year) https://packages.debian.org/buster/tmux There is no way in Python to specify which version of tmux this is supposed to run against. This is one of the strength of GNU Guix :) So: - the change in behaviour between tmux 2 and 3 is not important enough to be noticeable in any of my use cases, - I have little time, - the maintainer upstream is likely using tmux 2,=20 all-in-all, this makes me say that an upstream fix is unlikely because I can't write it myself and nobody else is likely to, either. > Thanks! > Thank you for maintaining Guix :) > T G-R