From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ILx2DPP+j2DCEQAAgWs5BA (envelope-from ) for ; Mon, 03 May 2021 15:47:31 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 0BANCPP+j2CrJAAAbx9fmQ (envelope-from ) for ; Mon, 03 May 2021 13:47:31 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 87E8D1A93C for ; Mon, 3 May 2021 15:47:30 +0200 (CEST) Received: from localhost ([::1]:46002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldYv3-0002GT-N5 for larch@yhetil.org; Mon, 03 May 2021 09:47:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldYud-0002GD-Nn for guix-patches@gnu.org; Mon, 03 May 2021 09:47:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34950) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ldYuc-0002z0-DA for guix-patches@gnu.org; Mon, 03 May 2021 09:47:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ldYuc-0004cR-Bw for guix-patches@gnu.org; Mon, 03 May 2021 09:47:02 -0400 Subject: bug#48165: [PATCH] nls: Do not update po files on first make invocation. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Mon, 03 May 2021 13:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 48165 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: 48165-done@debbugs.gnu.org Mail-Followup-To: 48165@debbugs.gnu.org, maxim.cournoyer@gmail.com, julien@lepiller.eu Received: via spool by 48165-done@debbugs.gnu.org id=D48165.162004961617743 (code D ref 48165); Mon, 03 May 2021 13:47:02 +0000 Received: (at 48165-done) by debbugs.gnu.org; 3 May 2021 13:46:56 +0000 Received: from localhost ([127.0.0.1]:46496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldYuV-0004c7-Qh for submit@debbugs.gnu.org; Mon, 03 May 2021 09:46:56 -0400 Received: from mail-qv1-f49.google.com ([209.85.219.49]:35471) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldYuT-0004c0-Mo for 48165-done@debbugs.gnu.org; Mon, 03 May 2021 09:46:54 -0400 Received: by mail-qv1-f49.google.com with SMTP id q6so1406630qvb.2 for <48165-done@debbugs.gnu.org>; Mon, 03 May 2021 06:46:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=0pGWH9Hijvja2IqMpz28Yw6y1SSlDLQdScmwQsTY4rQ=; b=CVU8Ha/3JyWQL4c4gMChHS/fYlQld1qEPSgWnMrVg0xYKKR5lt1RBc9SMZRzU4D27r 5AVADUhgbaZI3Gjqq2/1KP4SIo/WDw4dIky6n+I0jn/20DBZFp+e7fYkB9JNdwdJ5o5p tYgLcWuciyhyt/kbxhxH4SoN9onxl2Hx6Ex+vk7PHhc67u/osww4yv6wOAxd/AC8FfmV Bv/V1rUR9pTNppUoows6z8pb+3QMUWbLSgAisqG1tvgnXCq1dV2DHM7qYOq3RWcY2sgk P3PV5WsSXFGSsmZMZFgBhDZRXAtgj4pVzVkPc66YSi4q4VX+4R4QU3AIDOeEt5zl/EvA AyGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=0pGWH9Hijvja2IqMpz28Yw6y1SSlDLQdScmwQsTY4rQ=; b=COo8ScRVZKESr5MBoR0JzRFwI8IlhiwfGCp9YGWKS2x49WALXrlzUjlUFdQSrLc57m cyAlB4VFlvfbndYDkPCw14gTMsKYgba4XCTF59k1tIz/PVUsXEbVQCTtQlENeV/seHhv mo4eTJeyMIMc+JsBR2ryb0bYbbn7gA3W2C/fjlQ4gxqBLzpOE1l8SZ3Qu/OKBOJDm9+K hnXwgYlDCWfdMebJLeDbUXlNRvpMuZnrWm83951wwGLyjjUl1JgDOmb9h7PA2zie8mci 5y50ZXDjSYC4A33WRN6kjjzTtEizIK66MKa8b0+Kj6yk58p6H6C4iS77FizAdJ8XtXye 1yWA== X-Gm-Message-State: AOAM533NVLnjpcMRdkHd4lfcFzXPRjs6f7Z8tEjR0rSQyVE/T7TPnn6R lJCml3zSabSq5pGaQ3CR7VpY24SIDwA= X-Google-Smtp-Source: ABdhPJyJNjzo4aH1ptohZRasPzb68KwF8QNuDxgJazfUvVjmiNbRvp64Rkemu1OsxFTlYDWHMB1Q8g== X-Received: by 2002:a0c:c446:: with SMTP id t6mr9804818qvi.3.1620049608055; Mon, 03 May 2021 06:46:48 -0700 (PDT) Received: from hurd (dsl-10-134-43.b2b2c.ca. [72.10.134.43]) by smtp.gmail.com with ESMTPSA id r1sm9105515qtt.3.2021.05.03.06.46.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 May 2021 06:46:47 -0700 (PDT) From: Maxim Cournoyer References: <20210502222305.56a357f1@tachikoma.lepiller.eu> Date: Mon, 03 May 2021 09:46:46 -0400 In-Reply-To: <20210502222305.56a357f1@tachikoma.lepiller.eu> (Julien Lepiller's message of "Sun, 2 May 2021 22:23:05 +0200") Message-ID: <87a6pcnd4p.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620049650; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=0pGWH9Hijvja2IqMpz28Yw6y1SSlDLQdScmwQsTY4rQ=; b=Hbnyj/C8ByFvHynijE0K2P+YB+dezTcRYeVnxydDRiqDX4CZlkt6tj4hNgJFeeyTY9UKcA CrZvTqyhaYvMsJ9yCkvwOGpB3sksCpVTlC0l7ZgkWQRID231qNulejsanQ2EUmy/zsPXpa Zx7RBs3/zqUxAHj07rGuaxl2lgi1oGXTSTmoUdQK8ZijM5hC6h5XCsAZ0UCmYL39Z0lPoV eyxP8HFz2KTbsSTZQLFP89RtLXp5C79cux8JwmCrWSB1/iJ5UFdPRYi4XBdcV3xTSydI0s w/bf8iHAVjr7bU8sbcpRkLKarqtJsUHjpewDgW3zs+4MuGvmYkNrgsDDVbvM0A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620049650; a=rsa-sha256; cv=none; b=SlDL7xek1O6l7V34joL722yrFCPkE7yLqMGz7aM1/JNE2ovkcDA/QRgfq6DOZQaa915xAy xguuyZroWVb97ry1NQMMFw++Fodbn8sucxAwmfWvUC/G12i4bxDKLu7GMAZ9zvLqcIUGuM f+TFgC0lzzX+342sFFIVmdr6Es8xzyVpZFcp+GlXVx5N4auizXrmi7JsK27UDSGcWjD8N+ 57YR2O4W2Jn/yVdoXHKVTEFXiest6VEKTRSmaAM42ZJObKuI/LHoJk9Py3GEGN1uEZ8l/c MvPMCo1Ks0iq5nvWRWxem+dZh1qg8+yPjXwUloogpfvUPq9r0Ucxee2Q8a26BA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b="CVU8Ha/3"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.36 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b="CVU8Ha/3"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 87E8D1A93C X-Spam-Score: -1.36 X-Migadu-Scanner: scn0.migadu.com X-TUID: cDvIwQuyw6Jv Hi Julien! Julien Lepiller writes: > Hi Guix, > > As you probably know, after the first make in a clean checkout of the > guix repository, po files are dirty and we advertise to run "git > checkout po" to get them clean again. This was caused by the gettext > generated makefile that wanted to build the mo (compiled po) files, and > these po files depend on the pot that needs to be generated. > > In newer versions of gettext (at least 0.19.1 from 4 years ago), there > is an option, PO_DEPENDS_ON_POT that I set to "no", so this patch > updates the minimal gettext version to 0.19.1 and makes use of that > variable, that removes the dependency from the po files to the pot file. > > This means that when make tries to generate the mo files, it can do so > immediately, without needing to generate the pot file nor update the po > files that depended on the pot. > > As this patch updates the minimal requirement for gettext to 0.19.1, > I'm not sure what's the impact. This is a version from 4 years ago > (0.18.1 was from 6 years ago). We currently have gettext 0.20.1, and > debian jessie has 0.19.3, so I don't think this change will negatively > affect our users: > > - developpers should already use guix environment guix which provides a > good version. > - packagers of guix on other distros might have a harder time, but even > debian seems to have a recent enough version > > WDYT? It seems even RHEL 8 is using 0.19; I don't think it'll cause a problem. Thank you for this nice improvement! I've merged it to the version-1.3.0 branch. Closing. Maxim