unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Alexandr Vityazev <avityazev@posteo.org>
Cc: 48817-done@debbugs.gnu.org
Subject: bug#48817: [PATCH] gnu: Add emacs-kibit-helper.
Date: Sat, 05 Jun 2021 13:52:33 +0200	[thread overview]
Message-ID: <87a6o4edfi.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87im2ud6nv.fsf@posteo.net> (Alexandr Vityazev's message of "Thu,  03 Jun 2021 20:39:32 +0000")

Hello,

Alexandr Vityazev <avityazev@posteo.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-kibit-helper): New variable.

Thank you. I applied your patch, with the changes mentioned below. 

> +(define-public emacs-kibit-helper
> +  (let ((version "0.1.1")
> +        (revision "0")
> +        (commit "16bdfff785ee05d8e74a5780f6808506d990cef7"))

I targeted exact "0.1.1" release instead.  The commit you use is just
three commits above it, which only apply to the README file.

> +      (synopsis
> +       "Conveniently use the Kibit Leiningen plugin from Emacs")

I removed the "conveniently" buzzword.

> +      (description
> +       "Provides functions that make it easy to work with the Kibit
> +Leiningen plugin for detecting and improving non-idiomatic
> +Clojure source code, from within GNU Emacs. ")

The description must use full sentences, so I reworded it a bit. Also,
there was a trailing white space at its end.

Regards,
-- 
Nicolas Goaziou




      reply	other threads:[~2021-06-05 11:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03 20:39 [bug#48817] [PATCH] gnu: Add emacs-kibit-helper Alexandr Vityazev
2021-06-05 11:52 ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6o4edfi.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=48817-done@debbugs.gnu.org \
    --cc=avityazev@posteo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).