From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cCSzCF4N1GDERAAAgWs5BA (envelope-from ) for ; Thu, 24 Jun 2021 06:43:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id GJFhBF4N1GDEVgAAB5/wlQ (envelope-from ) for ; Thu, 24 Jun 2021 04:43:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 727C029355 for ; Thu, 24 Jun 2021 06:43:09 +0200 (CEST) Received: from localhost ([::1]:50642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lwHCm-00074Z-HZ for larch@yhetil.org; Thu, 24 Jun 2021 00:43:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwHCg-00074I-0X for guix-patches@gnu.org; Thu, 24 Jun 2021 00:43:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58876) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lwHCf-0003py-PD for guix-patches@gnu.org; Thu, 24 Jun 2021 00:43:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lwHCf-0002TA-O4 for guix-patches@gnu.org; Thu, 24 Jun 2021 00:43:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49082] [PATCH] guix: gexp: Make UTF-8 a default port encoding in mixed-text-file Resent-From: Andrew Tropin Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 24 Jun 2021 04:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49082 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 49082-done@debbugs.gnu.org Received: via spool by 49082-done@debbugs.gnu.org id=D49082.16245097299414 (code D ref 49082); Thu, 24 Jun 2021 04:43:01 +0000 Received: (at 49082-done) by debbugs.gnu.org; 24 Jun 2021 04:42:09 +0000 Received: from localhost ([127.0.0.1]:42189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwHBp-0002Rm-IQ for submit@debbugs.gnu.org; Thu, 24 Jun 2021 00:42:09 -0400 Received: from mail-lf1-f42.google.com ([209.85.167.42]:35730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwHBo-0002Qn-2x for 49082-done@debbugs.gnu.org; Thu, 24 Jun 2021 00:42:08 -0400 Received: by mail-lf1-f42.google.com with SMTP id u13so8010614lfk.2 for <49082-done@debbugs.gnu.org>; Wed, 23 Jun 2021 21:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=JmXdPhiY+IF4hfKHKLIKl0Zxbs2gT4rpoxfjuR6Gyuc=; b=pWfcVpvLr9dVrPjvq4aHjsTze67rqOkngOWhcaysqIlHocb9etz2qgLhXVIBunPN0C 7+eAqcHagCWzXqO9T0uKwhsnssXjNTP99+DQx1K2RL7BmNq++KxkaOvORhd+uIGRuUFh TAdqc3Y69vKbjarcqO2FJ1g4NEMSgNTUblaiVNznonslCKFr++pOZteTBQdLMx4jwK4B vojgT/zxl1Sz7rIPIIYLMU2uqr56xKLONiFhyrFtCoY/1hdoy/0wlzW9rUZruoLEXnAU 1sQns7rpgYsEU2G63Hrn5LW4OKzF+itHX20pCNZAwZpDys4aYe0R6uBGUnNTG/993AvZ NvCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=JmXdPhiY+IF4hfKHKLIKl0Zxbs2gT4rpoxfjuR6Gyuc=; b=ONuPdg8li8M1zl110fuCrbsu/DvDtaRQd8N9czcrBB8u2jdgGXEiRx5gCq3yWO977J ReumqQfhiYmU8CcIUzJ/hD56LNEz0oDabD25u2J3bwjpyaQArTcrmof82jybWbkFZy+k 2KzmuVX6Ndckdp4EN5hXPbvZKV0r7ZaZC36E/GfU0hZ5WOHBgXjcDfWiz/+x0ThT7I69 1WuNqH788sjh4kwLJA56EJCbIBGL28VkSVDxXBKRIgkV6FA08+PccFsPVDcQNe02ei7Q bnVTBdao4iL7NdkLjsATyvs7/3zYvilBtaDv1JUnwMhF2T/WjnpfiU04Q2YeHtVVPWgh WCdw== X-Gm-Message-State: AOAM530x7aqp92sbi9DBqNMCmeh90uvs0FZsnvC0tq3DtXMTDxMAlktV AS5Lih6iPnZn48OUSIOUObUTAN5ioQaMwQ== X-Google-Smtp-Source: ABdhPJwpJEwG+EHd/pBD1UUYxMEgPvRGX/gnDHsuyp6ZvNT/V40xdTkwL8R4jJsRTkyqVFw7HSnw/w== X-Received: by 2002:a05:6512:1381:: with SMTP id p1mr2335325lfa.367.1624509721639; Wed, 23 Jun 2021 21:42:01 -0700 (PDT) Received: from ixy ([109.252.117.164]) by smtp.gmail.com with ESMTPSA id u3sm97791lft.236.2021.06.23.21.42.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Jun 2021 21:42:00 -0700 (PDT) From: Andrew Tropin In-Reply-To: <875yy4uupe.fsf@gnu.org> References: <87bl836bdy.fsf@trop.in> <875yy4uupe.fsf@gnu.org> Date: Thu, 24 Jun 2021 07:41:58 +0300 Message-ID: <87a6nfoovd.fsf@trop.in> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624509789; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=JmXdPhiY+IF4hfKHKLIKl0Zxbs2gT4rpoxfjuR6Gyuc=; b=WEFnKYvnaMeOHuWDFThdvSX3XMdv1MG8Y1TUKc3hcTfv7W3cYH1HQG0FdmC3xBo3NmBEVR RhRGjBBLEviCRslddsm7cNA5EzNqES2cH0lf9TGnRWOX9t1UhW8QcTWcSNTWJ8F87sAyRg +7AgE5CKaWfg1R4Ub55cBOIC5TvmRFODmVC2+htsPonmJKuNer2/ZLogLjxDOccIImZbYv j7W7N4UsyPx68GU/CySsiWJo21hiq8odt/sjlB/3S5ZUigKM2y8ZFR0Jhvi8Ff+h6wQPFZ SPs/HmHmFATEm0AmhRCMpZf+YHpZzLqR5k6/HKvsBsW2lHtTKlDcf9kHYTLK6g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624509789; a=rsa-sha256; cv=none; b=SZPFw1GW6a3E2ibuJeZsJ1hSFlb9dFmzMN5pQpVRueMzgZCfzc06yr2nDXF1PygCP238zV FXDnc/YHyOmEHkoJFkR2Cs6gxpRNtMpu/eX2+F2yau4uYjuGY4toesIzzHqZ1qxbQL+0Q1 HjmMu9PdlROfRuLAvuTwy7zWns1UzNenDDFWLk/oTDeblKw8qjgV1tBt8Ivmg2jMdUKZGU HPqkFPHdI6042U3/apTypa+B8p7wsWVHJCYs4/XNheaq2++fNCDxpSNAAIU8kID59j2SZn tGeYs7turAJQWOKzUt7jONdu0fm5rkVm5J03s1xLgM2jTqzjWhPzsoLUtq05kw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop-in.20150623.gappssmtp.com header.s=20150623 header.b=pWfcVpvL; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.43 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop-in.20150623.gappssmtp.com header.s=20150623 header.b=pWfcVpvL; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 727C029355 X-Spam-Score: -1.43 X-Migadu-Scanner: scn1.migadu.com X-TUID: TbcBXx5I9cvK Ludovic Court=C3=A8s writes: > Hi, > > Andrew Tropin skribis: > >> guix/gexp.scm (mixed-text-file): It's necessary because if some UTF-8 sy= mbols >> appear in configuration, resulting file in the store will contain ? inst= ead of >> it. > > Good catch! Applied as 1f3d7b45349d43e5cc02594083e0cd44ef730992. Thank you very much!) > Please look how I modified the commit log, in line with our conventions > and previous entries for this file. > >> (define build >> (gexp (call-with-output-file (ungexp output "out") >> (lambda (port) >> + (set-port-encoding! port "UTF-8") > > Leo is right that we=E2=80=99d often write: > > (parameterize ((%default-port-encoding "UTF-8")) > (call-with-output-file =E2=80=A6)) > > because it=E2=80=99s marginally cleaner (the port is created with the rig= ht > encoding from the start). In this case it doesn=E2=80=99t matter much th= ough. Got it, I thought Leo meant to wrap (mixed-text-file ...) into parametrize, which probably won't work, because gexp will be avaluated in different environment. Sorry for missunderstanding!) Leo, Ludo, thank you for explanation! > Thank you! > > Ludo=E2=80=99.