unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Dhruvin Gandhi via Guix-patches via <guix-patches@gnu.org>
Cc: 49273-done@debbugs.gnu.org, Dhruvin Gandhi <contact@dhruvin.dev>
Subject: bug#49273: [PATCH 1/1] gnu: Add emacs-rustic.
Date: Fri, 02 Jul 2021 09:16:00 +0200	[thread overview]
Message-ID: <87a6n5w5hr.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20210629132935.10068-1-contact@dhruvin.dev> (Dhruvin Gandhi via Guix-patches via's message of "Tue, 29 Jun 2021 18:59:35 +0530")

Hello,

Dhruvin Gandhi via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-rustic): New variable.

Thank you.

I applied your patch with the following changes:

> +(define-public emacs-rustic
> +  (let ((commit "bbf129cd128105de51b6c242b2551094b8d8987d")
> +        (revision "0"))

I added a comment explaining why we're not using a specific tag here.

> +           (add-before 'check 'set-without-cask
> +             (lambda _
> +               (setenv "WITHOUT_CASK" "1")
> +               #t)))))

I removed the #t here.
> +      (home-page "https://github.com/brotzeit/rustic")
> +      (synopsis "Rust development environment for Emacs")
> +      (description "Rustic is a fork of rust-mode.
> +
> +Differences with rust-mode:
> +@itemize
> +@item flycheck integration
> +@item cargo popup
> +@item multiline error parsing
> +@item translation of ANSI control sequences through xterm-color
> +@item async org babel
> +@item custom compilation process
> +@item rustfmt errors in a rust compilation mode
> +@item automatic LSP configuration with eglot or lsp-mode
> +@item optional rust inline documentation
> +@item etc.
> +@end itemize\n")

I slightly reworded the description so it includes full sentences, with
proper capitalization, and no newline character at its end.

Regards,
-- 
Nicolas Goaziou




      reply	other threads:[~2021-07-02  7:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-29 13:25 [bug#49273] [PATCH 0/1] gnu: Add emacs-rustic Dhruvin Gandhi via Guix-patches via
2021-06-29 13:29 ` [bug#49273] [PATCH 1/1] " Dhruvin Gandhi via Guix-patches via
2021-07-02  7:16   ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6n5w5hr.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=49273-done@debbugs.gnu.org \
    --cc=contact@dhruvin.dev \
    --cc=guix-patches@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).