unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 49425@debbugs.gnu.org
Subject: [bug#49425] [PATCH] guix-install.sh: Prompt for configuring substitutes discovery.
Date: Tue, 06 Jul 2021 16:44:48 +0200	[thread overview]
Message-ID: <87a6mzqz6n.fsf@gnu.org> (raw)
In-Reply-To: <20210705234903.21244-1-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Mon, 5 Jul 2021 19:49:03 -0400")

Hi,

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> +# Configure substitute discovery according to user's preferences.
> +# $1 is the installed service file to edit.
> +configure_substitute_discovery() {
> +if grep -q -- '--discover=no' "$1" && \
> +        prompt_yes_no "Would you like to enable automatic substitute \
> +discovery? (yes/no)"; then
> +    sed -i 's/--discover=no/--discover=yes/' "$1"
> +fi
> +}

Indentation is off, compared to the other functions.

Should the message say a bit more, similar to that in (gnu installer
newt substitutes)?

Otherwise LGTM!

Note that someone running “yes | ./guix-install.sh” will now have
substitutes enabled (whereas it’s off by default in
<guix-configuration>).  I suppose that’s fine though.

Thanks,
Ludo’.




  parent reply	other threads:[~2021-07-06 14:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-05 23:49 [bug#49425] [PATCH] guix-install.sh: Prompt for configuring substitutes discovery Maxim Cournoyer
2021-07-06  8:38 ` zimoun
2021-07-06 14:40   ` Ludovic Courtès
2021-07-06 16:16     ` Maxim Cournoyer
2021-07-06 14:44 ` Ludovic Courtès [this message]
2021-07-08  3:58   ` bug#49425: " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6mzqz6n.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=49425@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).