unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: Attila Lendvai <attila@lendvai.name>
Cc: 50565@debbugs.gnu.org
Subject: [bug#50565] [PATCH] services: tlp: added start-charge-thresh-bat0 & co. to the config
Date: Tue, 21 Sep 2021 14:02:30 +0000	[thread overview]
Message-ID: <87a6k658nd.fsf@gnu.org> (raw)
In-Reply-To: <20210913110030.1817-1-attila@lendvai.name> (Attila Lendvai's message of "Mon, 13 Sep 2021 13:00:30 +0200")


Hello,

> +  (start-charge-thresh-bat0
> +   (maybe-non-negative-integer 'disabled)
> +   "Percentage when battery 0 should begin charging.")
> +
> +  (stop-charge-thresh-bat0
> +   (maybe-non-negative-integer 'disabled)
> +   "Percentage when battery 0 should stop charging.")
> +
> +  (start-charge-thresh-bat1
> +   (maybe-non-negative-integer 'disabled)
> +   "Percentage when battery 1 should begin charging.")
> +
> +  (stop-charge-thresh-bat1
> +   (maybe-non-negative-integer 'disabled)
> +   "Percentage when battery 1 should stop charging.")

It would be nice if you could document those new fields in the "TLP
daemon" section of the doc/guix.texi file.

Note that the commit message should also respect the conventions
specified here:
https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html.

Could you send an updated version :)?

Thanks,

Mathieu




  reply	other threads:[~2021-09-21 14:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13 11:00 [bug#50565] [PATCH] services: tlp: added start-charge-thresh-bat0 & co. to the config Attila Lendvai
2021-09-21 14:02 ` Mathieu Othacehe [this message]
2021-09-23  6:09 ` [bug#50565] [PATCH] services: tlp: Added config variables for battery charging Attila Lendvai
2022-02-02  9:43 ` bug#50565: [PATCH] services: tlp: added start-charge-thresh-bat0 & co. to the config Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6k658nd.fsf@gnu.org \
    --to=othacehe@gnu.org \
    --cc=50565@debbugs.gnu.org \
    --cc=attila@lendvai.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).