From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0ETyEYfbVGG/AgAAgWs5BA (envelope-from ) for ; Wed, 29 Sep 2021 23:32:55 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id aOZnDYfbVGH3dgAAbx9fmQ (envelope-from ) for ; Wed, 29 Sep 2021 21:32:55 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 810E612CD5 for ; Wed, 29 Sep 2021 23:32:53 +0200 (CEST) Received: from localhost ([::1]:59310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVhC8-00045k-N5 for larch@yhetil.org; Wed, 29 Sep 2021 17:32:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37276) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVh9P-0001Qp-Jb for guix-patches@gnu.org; Wed, 29 Sep 2021 17:30:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38958) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mVh9O-0001O5-32 for guix-patches@gnu.org; Wed, 29 Sep 2021 17:30:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mVh9N-0007kq-Ul for guix-patches@gnu.org; Wed, 29 Sep 2021 17:30:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50072] [PATCH WIP 0/4] Add upstream updater for git-fetch origins. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 29 Sep 2021 21:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50072 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sarah Morgensen Cc: 50072@debbugs.gnu.org Received: via spool by 50072-submit@debbugs.gnu.org id=B50072.163295097629755 (code B ref 50072); Wed, 29 Sep 2021 21:30:01 +0000 Received: (at 50072) by debbugs.gnu.org; 29 Sep 2021 21:29:36 +0000 Received: from localhost ([127.0.0.1]:50504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVh8j-0007jb-4C for submit@debbugs.gnu.org; Wed, 29 Sep 2021 17:29:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVh8T-0007ip-Jo for 50072@debbugs.gnu.org; Wed, 29 Sep 2021 17:29:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46104) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVh8O-0000Yo-5Y; Wed, 29 Sep 2021 17:29:00 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=36424 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVh8N-0006vB-Ns; Wed, 29 Sep 2021 17:29:00 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <8d1ae518b23fac5b15812a30b11df1c360ab3fbf.1629068119.git.iskarian@mgsn.dev> <87fsui80dd.fsf_-_@gnu.org> <86k0jti1r4.fsf@mgsn.dev> Date: Wed, 29 Sep 2021 23:28:57 +0200 In-Reply-To: <86k0jti1r4.fsf@mgsn.dev> (Sarah Morgensen's message of "Mon, 06 Sep 2021 18:59:59 -0700") Message-ID: <87a6jv6pgm.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632951173; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=xllEWwZQlJ6yNvIx5SQzi+XUWa+pWnIXhHvauKgelYM=; b=UMhMcey4mX4ljRWnvIt0CBmPMTNrMvC8qFKIjVNqwWoLYedr54pcp72vlzUqyx7ja87bcn PuNTlA6HIr5+JuFht5IMUxaQ+C/+qHomEGow4jKsrY/EGzVtRZknQL/UWLzEAC9yewvOvP 4tnXWqeJc9TPvDR7ZBibOeFM44hcE9fHR65JhdPe8E+QjciWIK6+aihk+qlk8O26ZSFPgq dzxTTQs7bkl76fCw4W+FAi/TJsq7140dier6KyKKWtmj8B+gGBBAkK+PuzIwWFiK1avcxH TfEArfaj25H69RCxB2YDpZyw4OlR3h711Q21tuHyzYPFiQMPX0C7PlAvL5M0ww== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632951173; a=rsa-sha256; cv=none; b=T36SlXjjFRI66l5xOJJPb2dHyJMZSuwr6h1KL9Kt++Bu4kvFvxIxWcdWBkTJm54Vp/5Rb3 oRW3fCkl8UeY8s50Ilm7ETW5Tam0LYOUmo80IxJeb+339v2p6XziYLuOYj+r6PWBBs+po8 wQFJymOM5XPnLdWOZjEk1CsH6VM5oCceUODO7XFuweEwuYpaTbvqbG373PrDJ5vOi/wXsC Nc7iKk3UCoce4hYbW3HH07X+GupDu47/wvvQ6INFRew8zuPOmp+UgqiIwOQdfqcWcky+rG zbM4zLQ5D8lqN+Z9gKO8VnuzY1aPH3IW1ZcdtCy19qclEorAKRP1+yLMsjuWDQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.90 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 810E612CD5 X-Spam-Score: -2.90 X-Migadu-Scanner: scn0.migadu.com X-TUID: Ad1pUOqIvKj9 Hi Sarah, I just noticed I hadn=E2=80=99t answered this message=E2=80=A6 Sarah Morgensen skribis: > Ludovic Court=C3=A8s writes: [...] >> Sarah Morgensen skribis: >> >>> * guix/git-download.scm (checkout-to-store): New procedure. >>> * guix/upstream.scm (guess-version-transform) >>> (package-update/git-fetch): New procedures. >>> (%method-updates): Add GIT-FETCH mapping. >> >> This LGTM. > > Thanks. WDYT about pre-emptively adding support for non-url URIs as > well? That is, > > 1. change "urls" in to "uri" > > 2. in 'git-fetch' > > a) if the upstream-source-uri is a git-reference, just use it as-is > rather than guessing the tag > > b) if it's not, return an 'upstream-source' with a git-reference URI=20 > > 3. update 'upstream-source-compiler' to work for git-reference URIs. > > If there are no objections, I think I'll make those changes and send > that as a proper patch. That sounds like a good idea. We=E2=80=99ll need to check users of =E2=80=98upstream-source-urls=E2=80=99 & co. and see whether/how they can d= eal with generalized =E2=80=9CURIs=E2=80=9D. That said, perhaps it can come after this patch series, which I think was mostly waiting on =E2=80=98package-definition-location=E2=80=99 initial= ly? Thanks, Ludo=E2=80=99.