From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GDOgCkQu42EOMQEAgWs5BA (envelope-from ) for ; Sat, 15 Jan 2022 21:27:48 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id mEIoB0Qu42FSfwAAauVa8A (envelope-from ) for ; Sat, 15 Jan 2022 21:27:48 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E796131FE2 for ; Sat, 15 Jan 2022 21:27:47 +0100 (CET) Received: from localhost ([::1]:43320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8peN-0006hm-1Y for larch@yhetil.org; Sat, 15 Jan 2022 15:27:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53468) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8pcj-0004w3-CP for guix-patches@gnu.org; Sat, 15 Jan 2022 15:26:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49084) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8pcf-0006I4-Sk for guix-patches@gnu.org; Sat, 15 Jan 2022 15:26:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n8pcf-00037x-OH for guix-patches@gnu.org; Sat, 15 Jan 2022 15:26:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53279] [PATCH] gnu: Add emacs-dtache Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 15 Jan 2022 20:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53279 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Niklas Eklund Cc: 53279@debbugs.gnu.org Received: via spool by 53279-submit@debbugs.gnu.org id=B53279.164227831511960 (code B ref 53279); Sat, 15 Jan 2022 20:26:01 +0000 Received: (at 53279) by debbugs.gnu.org; 15 Jan 2022 20:25:15 +0000 Received: from localhost ([127.0.0.1]:41987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8pbv-00036q-HF for submit@debbugs.gnu.org; Sat, 15 Jan 2022 15:25:15 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:50265) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8pbt-00036X-Mc for 53279@debbugs.gnu.org; Sat, 15 Jan 2022 15:25:14 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 9D6DE20004; Sat, 15 Jan 2022 20:25:06 +0000 (UTC) From: Nicolas Goaziou References: <87pmotpfam.fsf@posteo.net> <87czktkr40.fsf@posteo.net> <877db13p1e.fsf@posteo.net> Date: Sat, 15 Jan 2022 21:25:05 +0100 In-Reply-To: <877db13p1e.fsf@posteo.net> (Niklas Eklund's message of "Sat, 15 Jan 2022 17:08:13 +0000") Message-ID: <87a6fw3fxa.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642278467; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=nI5RnW3l3yX97YDU1VLqRYICyusfmOkFkFRo7ztxsaE=; b=GWtOahwpfqyfQbkvUaNLNkL4q5p0DIesUeswBCafDq3SbUtQCAVTQZY9JXlpm+X5cIzs6S aezdxVzhaKp4peu3BoAbkntSVVHtmaRvo0oPRt9B/iLpg3w7Km0sXEkh6E7g9n7nJ/2Gw6 Mbh9UdyovZ6+4Z52M17ZPg/igVF+/ozYZQi26HaTPMOcJ7JH1BvBV/LZO6G4jJtiBHlGpR 6Oga5P12OQbp+uGZsnkw/TWx4HItKzo8AUn1l0+nkjm2sOHaP+Vvz67dx+hPmlEx5uR7TH o1DbdwJ4I/GCFzUSA9kKdUx9yUtnoSnnOu76ABU0Zq+WxVkFmzRH3Lzwild2yg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642278468; a=rsa-sha256; cv=none; b=gKlBHjpVwDy9IgD5ZWELGLWw1mejOfTHT/OfapOtjiGWIJuVw19j2S5RVjjXCnMwSt9EJe Dm1ybfs6Vfdq3G1o/gvYEZhhHoFd6yGmxfXgVds6rRb/hs5ujTWrv7u1CqKqnDND+vTvCh xaEu/ndvrYtPoZvjmPQMIzDNqtoxEfQnzRDR1A1Pa83G0uINRbu6udb1vpXgrI9obCrhr5 yL1Km+14t8d39VZdTZ7FuKCLVasTjBfal+49ua/7/ue86Q4vlqMABI2QXhB7EBET02OsqS 8NpzaBZ94jm3RcpzQ2i2+v2nz+saILwPokPNoVFFzcOEqk4gQcdPM/Jk4EbNAA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.22 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E796131FE2 X-Spam-Score: -3.22 X-Migadu-Scanner: scn1.migadu.com X-TUID: qLoWHN9O6hG5 Hello, Niklas Eklund writes: > +(define-public emacs-dtache > + (package > + (name "emacs-dtache") > + (version "0.3") Thank you. > + (native-inputs (list emacs-ert-runner)) > + (inputs (list dtach)) Nitpick: native-inputs and inputs are usually located after arguments and build-system. Adding "dtach" to input is insufficient. You also need to set `dtache-dtach-program' so it points to the dtach program provided as an input. Likewise, you also need to set `dtache-shell-program' so it points to the bash from the package inputs. For example, you can do the first step with the following phase: --8<---------------cut here---------------start------------->8--- (add-after 'unpack 'locate-dtach (lambda* (#:key inputs #:allow-other-keys) (make-file-writable "dtache.el") (emacs-substitute-variables "dtache.el" ("dtache-dtach-program" (search-input-file inputs "/bin/dtach"))))) --8<---------------cut here---------------end--------------->8--- > + (arguments > + `(#:test-command '("ert-runner") > + #:phases > + ,#~(modify-phases %standard-phases > + (add-before 'install 'install-dtache-env > + (lambda _ > + (let ((bin (string-append #$output "/bin"))) > + (mkdir-p bin) > + (copy-file "dtache-env" > + (string-append bin "/dtache-env")))))))) You can simplify the arguments further: --8<---------------cut here---------------start------------->8--- (arguments (list #:test-command #~(list "ert-runner") #:phases #~(modify-phases %standard-phases (add-before 'install 'install-dtache-env (lambda _ (install-file "dtache-env" (string-append #$output "/bin"))))))) --8<---------------cut here---------------end--------------->8--- Could you send an updated patch? Regards, -- Nicolas Goaziou