From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6HwLIVYlmWIfUQEAbAwnHQ (envelope-from ) for ; Thu, 02 Jun 2022 23:02:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id gHYHIFYlmWKq5wAAG6o9tA (envelope-from ) for ; Thu, 02 Jun 2022 23:02:14 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2ACDC2566 for ; Thu, 2 Jun 2022 23:02:14 +0200 (CEST) Received: from localhost ([::1]:51970 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nwrxM-0004qk-VQ for larch@yhetil.org; Thu, 02 Jun 2022 17:02:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54868) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwrxC-0004nl-NI for guix-patches@gnu.org; Thu, 02 Jun 2022 17:02:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60797) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nwrxC-0001Fb-EO for guix-patches@gnu.org; Thu, 02 Jun 2022 17:02:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nwrxC-0005OW-C8 for guix-patches@gnu.org; Thu, 02 Jun 2022 17:02:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55231] [PATCH v1] initrd: Allow extra search paths with =?UTF-8?Q?=E2=80=98initrd-extra-module-paths=E2=80=99?= Resent-From: Brian Cully Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 02 Jun 2022 21:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55231 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 55231@debbugs.gnu.org, Brian Cully Received: via spool by 55231-submit@debbugs.gnu.org id=B55231.165420370820713 (code B ref 55231); Thu, 02 Jun 2022 21:02:02 +0000 Received: (at 55231) by debbugs.gnu.org; 2 Jun 2022 21:01:48 +0000 Received: from localhost ([127.0.0.1]:54694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwrwx-0005O1-OA for submit@debbugs.gnu.org; Thu, 02 Jun 2022 17:01:47 -0400 Received: from coleridge.kublai.com ([166.84.7.167]:53889 helo=mail.spork.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwrww-0005Nt-6F for 55231@debbugs.gnu.org; Thu, 02 Jun 2022 17:01:46 -0400 Received: from ditto (ool-18b8e9e7.dyn.optonline.net [24.184.233.231]) by mail.spork.org (Postfix) with ESMTPSA id B6F9F8A3D; Thu, 2 Jun 2022 17:01:45 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=spork.org; s=dkim; t=1654203705; bh=G8bKO2ASmDtPbUgOW5zLtjWZqrpAcqYfsJe89vmDIKw=; h=References:From:To:Cc:Subject:Date:In-reply-to; b=E0/mJKF6Omgj5wsi7IpIU9g9bsnmprvxOpFVQebbVN0j6WYfQgkcsP3jJN+NJYWWn Jz1ocImneBgb5jqDf6Aqh4PV6YWHSpJhtCFYl4o795DwOg+DUOqlLhZ/8YiDMWzF8u uSLHjTtkahE6H0Eq23fmK9mlMZe6VXrcTAlcPWB0= References: <87wnf3pv87.fsf@ditto.jhoto.spork.org> <2053c4ab42dfe2719cfc377934ac2fb9bcb500a9.1653160364.git.bjc@spork.org> <87ilpkwf8x.fsf_-_@gnu.org> User-agent: mu4e 1.6.10; emacs 28.1 Date: Thu, 02 Jun 2022 16:40:36 -0400 In-reply-to: <87ilpkwf8x.fsf_-_@gnu.org> Message-ID: <87a6aug4p2.fsf@ditto.jhoto.spork.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Brian Cully X-ACL-Warn: , Brian Cully via Guix-patches From: Brian Cully via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654203734; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=55/o6hcnRwO5aml+WjcAx37sR0RtHUhey2Hj/wnerZ0=; b=OMwrvqf+gABRd557CIwhcM0NwUztV4+907yxbmg0eCvfdupXsfp11EVvCp8S0biUnZVyZ6 LT6Apd8e4L7t5J0UN8CPeduZ43JflbKCnt0CaLGSPP/GrsLrJIdmR5sF/7tOzJenHtumam NHMvAw6J3MLE9rAuDNIqAwA6YEUv4azZd3FSskX6NwZFFEfUvz4aL45Vd1WHg40KH5BDSR C0BHZzCW5P0t9mOgOyqIClRkAQC5/SQmt9TnjdGWmkYjCugl3p5vU2ZOU1KZWKi4SQZfHe hGK2AWN+vsIFsR1IZ2ngPQdSDiYmYBupvZfR5FwNVyxBFk2wvRe5LbtMpAATWg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654203734; a=rsa-sha256; cv=none; b=V/tlH0c3NR2cHG+NCV7GwiIxD4xEC0dvo8LrZtuMNdDw4DCXQdRRh3kHud+9uZWgv1uRev tmVmlWoWVbqokC84ky5N1Ic66ocx4rNm1pbGDYeXcNQLSXImyGhvPqxlrZOcLrrbYGgrtr E7z3kqD5S8TKIdmueSU9yCarG3O4lgsNGJ8br1djhHx1N/2ZFqiaWZ3gLLWGhCg5OyvHvt +RVhnk8QKqq58gsEFN0xbiCgXxtWNypmpjvF/r3RJOrFr/Gwdb2WepCQeMyf2+y9fLSTOa KgVpNM7kqKNvU3pEKK+1GCSMlcvUL3iThcNnEanUkk106jGWoo6ezkItc79jAg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=spork.org header.s=dkim header.b="E0/mJKF6"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.53 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=spork.org header.s=dkim header.b="E0/mJKF6"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2ACDC2566 X-Spam-Score: -3.53 X-Migadu-Scanner: scn1.migadu.com X-TUID: CAkq2jzzOEj5 Ludovic Court=C3=A8s writes: > I wonder if we could reuse the =E2=80=98kernel-loadable-modules=E2=80=99 = field=20 > for this > purpose instead of introducing a new field. We=E2=80=99d need to pass=20 > it to the > initrd procedures and have them search in there in addition to=20 > the > kernel package, pretty much like this patch already does=20 > actually. This sounds like it could be made to work as you suggest. My=20 feeling is that the two contexts are slightly different, though,=20 as the Linux modules are a superset of the initrd modules, so I=E2=80=99d=20 prefer not to mix them as it might be confusing to people who are=20 used to other Linux distros where the initrd modules are called=20 out separately. I admit I=E2=80=99m probably being silly here, and don=E2= =80=99t=20 have any serious objection in principle. > Nitpick: the GNU convention is to use =E2=80=9Cpath=E2=80=9D to denote = =E2=80=9Csearch=20 > paths=E2=80=9D, > and other =E2=80=9Cfile=E2=80=9D, =E2=80=9Cfile name=E2=80=9D, or similar= . In this case, that=E2=80=99d=20 > be > =E2=80=9Ckernel module=E2=80=9D or =E2=80=9CLinux module=E2=80=9D. I struggled with this a fair amount, actually. What these=20 file-likes actually represent is an element of a search path, even=20 if they come in the odd form of a file-like object, which is why I=20 used =E2=80=98path=E2=80=99. =E2=80=98file=E2=80=99 seems wrong, as it impl= ies (to me) that it=E2=80=99s=20 the =E2=80=98initrd-extra-module-files=E2=80=99 option itself that would in= clude=20 the module, rather than the =E2=80=98initrd-modules=E2=80=99 option. Of course, all this goes away if we just reuse=20 =E2=80=98kernel-loadable-modules=E2=80=99 as an additional input, rather th= an=20 adding another option, so that=E2=80=99s a distinct mark in favor of doing= =20 that. When I get some time (hopefully soon!) I=E2=80=99ll try to thread=20 =E2=80=98kernel-loadable-modules=E2=80=99 through instead and see how far I= can=20 get with that approach. Do you think the documentation for it will=20 need to be updated to specify that it=E2=80=99s also used as a search path= =20 for initrd building? Or maybe the better option is to update the=20 documentation for =E2=80=98initrd-modules=E2=80=99 to say that it uses=20 =E2=80=98kernel-loadable-modules=E2=80=99 as input? -bjc