From: "Ludovic Courtès" <ludovic.courtes@inria.fr>
To: "Paul A. Patience" <paul@apatience.com>
Cc: 56257-done@debbugs.gnu.org, Ontje.Luensdorf@dlr.de
Subject: bug#56257: [PATCH] fenics: Do not use mpirun for tests
Date: Wed, 03 Aug 2022 12:04:50 +0200 [thread overview]
Message-ID: <87a68lve0t.fsf_-_@gnu.org> (raw)
In-Reply-To: <87mtdnu4af.fsf@apatience.com> (Paul A. Patience's message of "Tue, 05 Jul 2022 12:43:10 +0000")
Hi,
(Sorry for the delay.)
"Paul A. Patience" <paul@apatience.com> skribis:
> Ludovic Courtès writes:
>> Good question. Paul, do you remember the reasons for doing so?
>
> If I'm the Paul you're referring to, it would be better to CC me in the
> future, as I'm not subscribed to the list and only intermittently check
> it (which happens more often when I'm submitting patches).
I actually Cc’d Paul Garlick, but maybe Debbugs ate the Cc: field?
> I'm no expert in MPI and pytest, but it does seem that pytest_mpi [1] is
> recommended when combining the two, and there are no instances of
> @pytest.mark.mpi in the fenics repository.
> Further, running pytest tests under MPI is accomplished with [2]:
>
> mpirun -n 2 python -m pytest --with-mpi
>
> In other words, it seems as if the current tests are repeated in
> parallel, as Ontje discovered.
>
> The patch looks good to me.
Alright, applied.
Thanks!
Ludo’.
prev parent reply other threads:[~2022-08-03 10:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 11:24 [bug#56257] [PATCH] fenics: Do not use mpirun for tests Ontje.Luensdorf
2022-07-04 10:18 ` Ludovic Courtès
2022-07-05 12:43 ` Paul A. Patience
2022-08-03 10:04 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a68lve0t.fsf_-_@gnu.org \
--to=ludovic.courtes@inria.fr \
--cc=56257-done@debbugs.gnu.org \
--cc=Ontje.Luensdorf@dlr.de \
--cc=paul@apatience.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).