unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: 57345@debbugs.gnu.org
Subject: [bug#57345] [PATCH] Add gnupg to propagated-inputs of trezor-agent
Date: Thu, 01 Sep 2022 10:51:27 +0200	[thread overview]
Message-ID: <87a67jqxqt.fsf@elephly.net> (raw)
In-Reply-To: <oamh7oxIpfduEsGj0C875PjRnOZQr49eMY9S2AZdH4h4T5wwhwD_cOAsSZXDGlTn2rGP3751cdC6uLsdswY4PhgAa1js_xzDh3XgVdIFFdo=@protonmail.com>

Hi Marek,

thanks for your patch.  This looks like a good fix of the problem.

Propagation is generally used sparingly, when there is no other option.
We try to avoid it when possible, because it can lead to unexpected
conflicts, e.g. when a user has a particular version of gnupg installed
in their profile and then installs trezor-agent with a more recent
version of Guix it would abort with a conflict error as it cannot
install two variants of gnupg into the same Guix profile.

I wonder if we can avoid propagation here.  We could, for example, look
up gnupg in PATH (so that a user’s installation of gnupg is preferred)
and fall back to an explicit gnupg from the inputs (not
propagated-inputs).  This would require minor patching of trezor-agent.

What do you think?

-- 
Ricardo




  reply	other threads:[~2022-09-01  9:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-22 19:03 [bug#57345] [PATCH] Add gnupg to propagated-inputs of trezor-agent guix-patches--- via
2022-09-01  8:51 ` Ricardo Wurmus [this message]
2022-09-05  5:49 ` guix-patches--- via
2022-09-05  9:25   ` Efraim Flashner
2022-09-05 11:26     ` guix-patches--- via
2022-09-06 13:06       ` guix-patches--- via
2022-09-06 15:41         ` Maxime Devos
2022-09-06 15:39       ` Maxime Devos
2022-09-06 15:44       ` Maxime Devos
2022-09-06 15:48   ` Maxime Devos
2022-09-09 19:55     ` guix-patches--- via
2022-10-11 14:44 ` [bug#57345] (No Subject) Attila Lendvai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a67jqxqt.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=57345@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).