From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 2NdQBPwMM2P2AwEAbAwnHQ (envelope-from ) for ; Tue, 27 Sep 2022 16:47:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id OF44BPwMM2NhrAAAauVa8A (envelope-from ) for ; Tue, 27 Sep 2022 16:47:24 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8DEA12B09B for ; Tue, 27 Sep 2022 16:47:23 +0200 (CEST) Received: from localhost ([::1]:52064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odBrm-0002r7-82 for larch@yhetil.org; Tue, 27 Sep 2022 10:47:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46598) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odAHj-00015l-GJ for guix-patches@gnu.org; Tue, 27 Sep 2022 09:06:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54287) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1odAHi-0002w7-UT for guix-patches@gnu.org; Tue, 27 Sep 2022 09:06:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1odAHi-0004H1-FA for guix-patches@gnu.org; Tue, 27 Sep 2022 09:06:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57540] [PATCH] Please rebase (was: Add ocaml-elpi (a dependency of coq-mathcomp-analysis)) Resent-From: Garek Dyszel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 27 Sep 2022 13:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57540 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun , Julien Lepiller Cc: 57540@debbugs.gnu.org Received: via spool by 57540-submit@debbugs.gnu.org id=B57540.166428395916418 (code B ref 57540); Tue, 27 Sep 2022 13:06:02 +0000 Received: (at 57540) by debbugs.gnu.org; 27 Sep 2022 13:05:59 +0000 Received: from localhost ([127.0.0.1]:53365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odAHe-0004Gf-Ra for submit@debbugs.gnu.org; Tue, 27 Sep 2022 09:05:59 -0400 Received: from knopi.disroot.org ([178.21.23.139]:35462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odAHc-0004GR-Jo for 57540@debbugs.gnu.org; Tue, 27 Sep 2022 09:05:58 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id F0AD44C357; Tue, 27 Sep 2022 15:05:54 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with UTF8SMTP id 64toCPiUoTva; Tue, 27 Sep 2022 15:05:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1664283880; bh=ICsO5MuEolENnDM0r+gvpWiDVTgdChsSs1FLjTp+UGI=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=XVu8Wxi1hjntkINVIJinQbMQOT9vo25xMKFJ6x8vUCX/4P+z2FhvCp+spRkUulzmO AWx5IxOPSCgF8Yi7hZcecjtomypaFwi3PUCkWF24V5nLJFMEZWFrwK7yGTsDsjQkpH djyVXoMZCAufkLgUAUYkrZwb9EH+KdfzqLwp5+6WOc2blGOWdDt4Lk21dyranU2xj9 Igi/Hy6JW19QU+aDdB4IsNooQAO0s1Uap7IGk5G+b636Szn8gelx/qt5tjlTc+F3a/ QWsUuzAb/GUcbA3fEQ3ZqCyn0MqVmX8BS9FeenEMNJRjL50KKlYiQQ7g57itw9PASD hWHNMagiOvuSg== In-Reply-To: <86sfkew017.fsf_-_@gmail.com> References: <79d544f7d8ba64b631a6f0f1d2ef0b08@disroot.org> <87sfl3vxws.fsf@disroot.org> <86sfkew017.fsf_-_@gmail.com> Date: Tue, 27 Sep 2022 09:04:33 -0400 Message-ID: <87a66l9dem.fsf@disroot.org> Mime-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Garek Dyszel X-ACL-Warn: , Garek Dyszel via Guix-patches From: Garek Dyszel via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664290043; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Ptymn99qKWPl03aIghRSL4EdwbaIRqPmqaGG6LveBFU=; b=guURYyzMnAqH6CQxeE89URfTDCqVbkagyAo2NifKepuzrxaBdjxNzaW4D8HyOzytnKvxry xpYCK6psMxapFDElNTOD1oyBGXoDldy+WKR4lHLn97Zs10OIm57OL0b/VQEoaV+JR5aYzX zTden7QQgYiYk/U6+1mXN8qsqoT7qQ4OYkQdl76Q15TaFHZy2jbBoe38TcfoAoNGYEClpG eNGba3c/W4StJotRFsyejXNs3BZxm6iLntt27EYSL0zYejMr9Dl+MqZdTTnnxVbq4ySgQZ oQVtmz3SMwZ8waMs/l9ucV645edOwAeXWySZ0hxQkiVAcvkDLKoLyzvGLaItnw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664290043; a=rsa-sha256; cv=none; b=qnKR/DIX3Q+cKq1vRAf9dMqdTdmSRJZF42ZaHv2p81jS3VwQlenbXG7tlwMZi4Ph/yYB9w 4f0T+n/ERD8yKuiQJnsUICW+REG24XJRcE/lVARYJWX67zN8VJ+/sPtu9c5rYUd8Evz9lK SaB4/nYwfk8CVpeI/jarN5ObBAoOX07Mf4mb1nNKCv5R8ZLNh0NlKf5kEYXgyIo2FgpIyX TpapwWfagEwYkGYdawnJhSoNm0UgQ5ejTgRj+wNClMxoRDG1LkrLvd/BMfc/vVHiPf9+Lc RvB3L+sJnqlIyjTePddQhSQ0yrEPOQELzQeVC4fA3ar5y60Fyg4+GnWQsCnWEQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=XVu8Wxi1; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.34 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=XVu8Wxi1; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8DEA12B09B X-Spam-Score: -1.34 X-Migadu-Scanner: scn1.migadu.com X-TUID: QK2bMFWW3ShA Hi Julien and simon, I planned to write back yesterday but had to run out the door unexpectedly. At 18:52 2022-09-26 UTC+0200, zimoun wrote: > For instance the series reads, ... where the logic about the order is > not obvious The logic was essentially adding dependencies in reverse order. I started with the package that I wanted to build (coq-mathcomp-analysis), and added the dependencies as I found they were needed. I'll stick with committing dependencies in forward order (committing dependencies before packages) from now on. > I have tried to clean the mess but I give up for now. :-) It would be > much easier if the series provides, > > 1. the Git commit against which revision these patches apply (see the > option --base of git-format-patch) > > 2. the correct dependency order of the patches Probably it would also be easier to start over from the new master branch and recommit the remaining packages in the proper order. If I don't have another major interruption, I will send out a new set of commits, in the correct order, formatted with --base, before or by Friday. Excluding those packages which were already pushed to master, of course :) At 20:39 2022-09-24 UTC+0200, Julien Lepiller wrote: > No need to repeat the license here. Also, this means that the license > should be lgpl2.1+, instead of plain lgpl2.1. Ah, seems like I was getting lost in package-ception there and didn't check over the descriptions too rigorously. I'll keep this in mind when preparing the next patchset for this thread. > For python packages, I see you add python to the inputs. Why is that? > The python-build-system already provides python. I had been getting errors of the form "python3 was not found on the PATH" during the 'configure' phase of some python packages, even though the python-build-system was being used. I added python to everything to avoid such errors, but forgot to remove it for packages where it was not really needed. If I can find the first package that produced that error, I'll submit a bug report for it with the precise error quoted. > It looks like python-jsonschema-next (4.5.1) does not have any > dependent, so updating this package instead might be better than > adding a new one, wdyt? I found evidence to the contrary, I think. With graphviz installed, I ran $ guix graph python-jsonschema > /tmp/py-js-deps.dot $ gc -n /tmp/py-js-deps.dot which says that there are 186 nodes, or (186 - 1) = 185 packages dependent on python-jsonschema-next. If you prefer viewing it as an image, $ dot /tmp/py-js-deps.dot > /tmp/py-js-deps.png $ feh /tmp/py-js-deps.png shows all 185 packages originating from the node named "python-jsonschema@4.5.1". Maybe for now we could add this transitional python-jsonschema-4.15 to build coq-mathcomp-analysis, and remove it in a subsequent patchset? I don't want to tie this patch up unnecessarily. If I have malformed patches now with only 20 packages,... well, let's just say I don't know if I want to see the results just yet, if I'll need to rebuild 185 :) -- Garek