From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id QGGIJsqQOWOwRQAAbAwnHQ (envelope-from ) for ; Sun, 02 Oct 2022 15:23:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id GKOSJcqQOWNmTQEAG6o9tA (envelope-from ) for ; Sun, 02 Oct 2022 15:23:22 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 304FD479 for ; Sun, 2 Oct 2022 15:23:22 +0200 (CEST) Received: from localhost ([::1]:53540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oeywD-0005Vd-8L for larch@yhetil.org; Sun, 02 Oct 2022 09:23:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55832) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oeyvv-0005RZ-5P for guix-patches@gnu.org; Sun, 02 Oct 2022 09:23:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47433) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oeyvu-0004Vf-Tz for guix-patches@gnu.org; Sun, 02 Oct 2022 09:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oeyvu-0008O6-H9 for guix-patches@gnu.org; Sun, 02 Oct 2022 09:23:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57963] [PATCH v4 2/2] home: fontutils: Support user's fontconfig. Resent-From: Taiju HIGASHI Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 02 Oct 2022 13:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57963 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: liliana.prikler@gmail.com Cc: ludo@gnu.org, 57963@debbugs.gnu.org, andrew@trop.in Received: via spool by 57963-submit@debbugs.gnu.org id=B57963.166471697332213 (code B ref 57963); Sun, 02 Oct 2022 13:23:02 +0000 Received: (at 57963) by debbugs.gnu.org; 2 Oct 2022 13:22:53 +0000 Received: from localhost ([127.0.0.1]:46511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeyvk-0008NV-V8 for submit@debbugs.gnu.org; Sun, 02 Oct 2022 09:22:53 -0400 Received: from mail-pj1-f50.google.com ([209.85.216.50]:36801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeyvj-0008NG-Rb for 57963@debbugs.gnu.org; Sun, 02 Oct 2022 09:22:52 -0400 Received: by mail-pj1-f50.google.com with SMTP id e11-20020a17090a77cb00b00205edbfd646so13116256pjs.1 for <57963@debbugs.gnu.org>; Sun, 02 Oct 2022 06:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=taiju-info.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date; bh=TcVbQ3k9QuvaUSRvLXmFjZkOD+rAy6LoAlkUknLs060=; b=v9je8QeSS8tO2mpuBqY03BPmvjh3YrZzl5P4fEwB6FYBRkixPQuFvZnbIoN8ko7qZT D70TzwXr/D4j2bN4VW8PCWGnjQj0q1GKNOPW1C/+Ztv0RKt9bntGz4BwKg1Il+r+rPx9 RjO3gU5MwnowneYoyvNHRci1PhZ3TctR0O6fAnqpjfrj3Nd3b+5hfwdELjIK7o0b7pYU CT/W01ba1dvThKZnM5HEyPDd6Lyd/jkYtTy2yd4L8HLrUGxPgdhs9YXP5F/axjnpGO4K WHpATSLQl7OkhT7Ji6h/9L+jmtXiKvadwb0sGEzWoUbk5ffQFS5FUvw87x7+w40Uabns LtLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date; bh=TcVbQ3k9QuvaUSRvLXmFjZkOD+rAy6LoAlkUknLs060=; b=YntA2EW4GyIb2G086Fb2tqSfmFOXM1lHjkqK30yn81iol0WZ33bLE7Ud5Dm8L71Urx ATuOlDHyFBBRoG9ZH4x2VoaysyggjlANO7NgpE5FjPZgchK4Ey43iL7gxsnmYOFz/X2l o/f2OfTVcX7CgvUcYTCRK8uFBXvt4ZmEKf0IjVFg/RkXNAynp1IcK+bAK6lz+Og3q+qr WFbU9qR0oG2OfhlfGQpxHmV2wRMZkjkRuYAi3T/CEll/ziLKDJfSTyW63/oiMr3hv+rj nWo/zlq/donk56vRDCwOltxcNMsA2gwTOeyz5YWuCxTufSOTklWxFGnTSwYoNxsn85H+ 4dMg== X-Gm-Message-State: ACrzQf1pmiCc0bFGpCAdGNbMNUqPoIZS1Z5UHpOwCjucZpt0CRsjEi9y V8+GCWg2bI7XmzAgjRjt1xrfUA== X-Google-Smtp-Source: AMsMyM7Xu4XvmXS1fwbt243Q624xPB6865sQFiKnYTBYTZFEE8LZ1cHu2VIlWzdgqeFNcvZwc5lseA== X-Received: by 2002:a17:90a:d14a:b0:203:7b4b:6010 with SMTP id t10-20020a17090ad14a00b002037b4b6010mr7513607pjw.237.1664716966145; Sun, 02 Oct 2022 06:22:46 -0700 (PDT) Received: from Taix ([240b:253:ec40:2400:b7d1:436e:2d61:e925]) by smtp.gmail.com with ESMTPSA id pj1-20020a17090b4f4100b001eee8998f2esm8380324pjb.17.2022.10.02.06.22.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Oct 2022 06:22:45 -0700 (PDT) From: Taiju HIGASHI References: <20220929143633.28844-1-higashi@taiju.info> <20220929143633.28844-2-higashi@taiju.info> <3e28e656526b901a3fd099d1cd180528f24e15e7.camel@gmail.com> <87o7uvrdt4.fsf@taiju.info> <6155f2126a6725979ee51079c0d90f5d00c31e1c.camel@gmail.com> Date: Sun, 02 Oct 2022 22:22:42 +0900 In-Reply-To: <6155f2126a6725979ee51079c0d90f5d00c31e1c.camel@gmail.com> (liliana prikler's message of "Sat, 01 Oct 2022 18:14:51 +0200") Message-ID: <87a66eqs0t.fsf@taiju.info> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664717002; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=TcVbQ3k9QuvaUSRvLXmFjZkOD+rAy6LoAlkUknLs060=; b=Wp6/XgHkNjIH3FfiM4/DHglcbpMBiEC1epx4hGXhN+YG9ccDSSQDM3cjUrEssisqd0UIl3 qy2YOMGjOMCXgN0YFIzvIGsCy3oThC5VtPm3TpCgrU8UL7HARPritQqdUrQnwLhl68oMNy 2EUuMYpgwtXjQ7EItTGLu5lETBf+PUqxzhzxcyXMQAGF2QLzrfaSQpmJgNsVPNdiiIRiZX XgER/nC0iU/PJRS+QkgdM5rQ7oh7bu6ChMephOgfnvRouJx0Q2jkYW8F82RcQPrBkEwicM kNDCH4cKMx7Hi+bxygNHuYOX3IpedsSNwr8rE69mh4/rCz9y/pinClYBzZ8i7Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664717002; a=rsa-sha256; cv=none; b=d/vcWQcDxcpJQjr31hv+Iay91aC5wkD/8uo6luRfPtsUkOerr/OwqojcqJzZBGtsUm9EOy HZjRso6XULKsUTu/e+UdK7GoVfIslFtWyQnzw1ng3qIvjfKSI06reUtazQuvRZ/LFR6dBK ekfz6EOhZCFXFE3uzus801Gia7Z85QpMldc7f48AeMgv+0aRgFVjFd1Dh/BNKrcLCcPXyD uFz60xTXjgyXubF5pq+OI0ZrUM5Q5K3JBFmzVZl8an6nV6Sj6V4zd26gbhkwrEIZODOf18 GZ2UB2Ff2wKL41uZ6MTR52ENmJHRwMj8rkLHjSbFHdJxAFi1Mdgm3eSeNCB8+g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=taiju-info.20210112.gappssmtp.com header.s=20210112 header.b=v9je8QeS; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 4.16 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=taiju-info.20210112.gappssmtp.com header.s=20210112 header.b=v9je8QeS; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 304FD479 X-Spam-Score: 4.16 X-Migadu-Scanner: scn1.migadu.com X-TUID: KCtkcKzXcUOx >> > > +(define-record-type* default-font >> > > +=A0 make-default-font >> > > +=A0 default-font? >> > > +=A0 (serif default-font-serif >> > > +=A0=A0=A0=A0=A0=A0=A0=A0 (default '()) >> > > +=A0=A0=A0=A0=A0=A0=A0=A0 (sanitize (default-font-sanitizer 'serif))) >> > > +=A0 (sans-serif defalut-font-sans-serif >> > default-font-sans-serif >> > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 (default '()) >> > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 (sanitize (default-font-san= itizer 'sans-serif))) >> > > +=A0 (monospace default-font-monospace >> > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 (default '()) >> > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 (sanitize (default-font-saniti= zer 'monospace)))) >> > Rather than having a null default and sanitizing the field as here, >> > can >> > we have an #f default and omit the field? >> > >> > Btw. I'm not sure whether making this an extra record is the right >> > idea.=A0 Wouldn't "default-(serif|sans-serif|monospace)-family" at >> > the >> > root make more sense? >> > >> > Cheers >> >> Do you mean to write as follows? >> >> --8<---------------cut here---------------start------------->8--- >> (home-environment >> =A0(packages (list font-google-noto)) >> =A0(services >> =A0 (append >> =A0=A0=A0=A0=A0 (list >> =A0=A0=A0=A0=A0=A0 (service home-bash-service-type)) >> =A0=A0=A0=A0=A0 (modify-services %home-base-services >> =A0=A0=A0=A0=A0=A0=A0 (home-fontconfig-service-type >> =A0=A0=A0=A0=A0=A0=A0=A0 config =3D> (home-fontconfig-configuration >> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 (font-director= ies >> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 (list "~/fo= nts")) >> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 (default-serif= -family "Noto Serif CJK JP") >> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 (default-sans-= serif-family "Noto Sans CJK JP") >> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 (extra-config >> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 `((match (@= (target font)) >> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= (edit (@ (mode assign) >> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0 (name antialias)) >> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0 (bool true))))))))))) >> --8<---------------cut here---------------end--------------->8--- > Yep. Feels more natural imho. I have changed the interface as you suggested in the v5 patch. Cheers, --=20 Taiju