From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yVGCBn8NUWMahQAAbAwnHQ (envelope-from ) for ; Thu, 20 Oct 2022 10:57:35 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id +OlUBX8NUWNTrgAAauVa8A (envelope-from ) for ; Thu, 20 Oct 2022 10:57:35 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 71A8EC079 for ; Thu, 20 Oct 2022 10:57:34 +0200 (CEST) Received: from localhost ([::1]:44376 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olRMr-0001jS-Cm for larch@yhetil.org; Thu, 20 Oct 2022 04:57:33 -0400 Received: from [::1] (helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olRMq-0007p8-2n for larch@yhetil.org; Thu, 20 Oct 2022 04:57:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olRMN-0007Kb-UW for guix-patches@gnu.org; Thu, 20 Oct 2022 04:57:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33867) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1olRMN-0006gt-Mx for guix-patches@gnu.org; Thu, 20 Oct 2022 04:57:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1olRMN-0006Zz-F1 for guix-patches@gnu.org; Thu, 20 Oct 2022 04:57:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58648] [PATCH 1/1] doc: contributing: Expand "Sending a Patch Series". Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 20 Oct 2022 08:57:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58648 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 58648@debbugs.gnu.org Cc: "\(" X-Debbugs-Original-To: "( via Guix-patches via" , 58648@debbugs.gnu.org Received: via spool by 58648-submit@debbugs.gnu.org id=B58648.166625621825244 (code B ref 58648); Thu, 20 Oct 2022 08:57:03 +0000 Received: (at 58648) by debbugs.gnu.org; 20 Oct 2022 08:56:58 +0000 Received: from localhost ([127.0.0.1]:32941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1olRMH-0006Z1-Ma for submit@debbugs.gnu.org; Thu, 20 Oct 2022 04:56:58 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]:40849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1olRMC-0006Xy-Bi for 58648@debbugs.gnu.org; Thu, 20 Oct 2022 04:56:53 -0400 Received: by mail-wm1-f43.google.com with SMTP id v130-20020a1cac88000000b003bcde03bd44so1786282wme.5 for <58648@debbugs.gnu.org>; Thu, 20 Oct 2022 01:56:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=JSHw0bZLj66LPAjJWXAWBgXdZQdIP0M7ANfFBtWf1yc=; b=NeLezWnR8CH6gQE43MoMdZBt+z92qPRCOTp+hHeOvEKc1KAhdItOY2zVoIeAmtdXO7 FdG4OmNty14X4COzwrpXZhIT90KYMot9MzITFlSXvKc12q9YgQ22RG/PXcb/EDf8fXc3 Am0TWY7rvfMtTBVk4kYU3sS6PEGUFsNnoHNo8v97OrDbzIuf8p+xN24zTc36RI9KAil/ mfPFpj7N+McbCV+F5V7Efy64BUmQPE2EYE/pyKnVoy8hkeAGJFN4AX3cIrT8MH29kuvm mQj4ihjNgIMMEEUv5kxsfsA97DuwqiC3oz3O4057CS5RqBaeKDRXgwoaWFBbAWVmH1QH kCUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JSHw0bZLj66LPAjJWXAWBgXdZQdIP0M7ANfFBtWf1yc=; b=acIlpX018a12UT9StgtifYBnqXnFXsC8367tclmShI6xCHvX8QRK+vCVZwZidnNMP7 aiPUmxZ7WHrHl2PAiu4XRd8TkB+TXJrlWg0JW5qy5E39evYS1CYy+23Gv9SlEqhF0S5Y P+yHmO/GFjJTlYUxUJH4+0I/F4JLP3w3Y9FY96RjC6ayvq1Jjp2CdaweAxhpNN0hNUcQ Iq39t7H/yxTKrBuXl7vfOnBH5sO5FH0+FplK4WWBr6K+U+n0v5IfSCNE4Zc4VX1/W706 RMFHr9lzgdOSeNBrtg9RZ+4T/4ovJ7ERD+FxFVStb7eWuq6dhbrKvZ2De1W4cEx0xBgw SKlw== X-Gm-Message-State: ACrzQf0Dm6DaOHJSCD1meCxrQg607saUnGjumAHvdboGbAJmLyOBC0wG pWy60807YTWNAErq5znNSdg= X-Google-Smtp-Source: AMsMyM6HPvn/klo6s1gCRxp/tMy3O/mk8X++FMffOlbUXq0KnJYUsSpYLVbBwHBKjlhd01Dp5VbieQ== X-Received: by 2002:a05:600c:3592:b0:3c6:f9db:a954 with SMTP id p18-20020a05600c359200b003c6f9dba954mr8457999wmq.170.1666256206523; Thu, 20 Oct 2022 01:56:46 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id g11-20020a5d488b000000b0022eafed36ebsm15869079wrq.73.2022.10.20.01.56.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Oct 2022 01:56:46 -0700 (PDT) From: zimoun In-Reply-To: <20221019220048.24290-1-paren@disroot.org> References: <20221019215709.24201-1-paren@disroot.org> <20221019220048.24290-1-paren@disroot.org> Date: Thu, 20 Oct 2022 10:56:25 +0200 Message-ID: <87a65qkh52.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666256254; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=JSHw0bZLj66LPAjJWXAWBgXdZQdIP0M7ANfFBtWf1yc=; b=TD0AM/8Ol4pGJZaC9bT7zpIJhTU3iNE9KEr3Xrti3Kga5VLtIYsj1+UAX/P1qGVyv4+dJL gtcNCHTQg1kY4DnO7jFR0NV9ir4IciPNHAhB14bEcxr7qE2WCA6z9gaMJHvHLTuj8Q4gfd x2E6o0CSv3R+sxBpOmfnFCc9WQ2U6j/btoJH7rNYlCc9sCcN6RCOJpjogzETwgWNpgjAzp zMv3ClkSYa8xEOKq1h7PRVEjPuDn4eFPRRokesxoa1+ZWlNFf2NIwC8a2wAYq6tR/jWUPW sqSEGHXI145oNnW+WqoyK/VNa5mrpHbNgcYa4r5dlALIzudb4axGoEbIPHNa0w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666256254; a=rsa-sha256; cv=none; b=ME5FjY+VCXvzvIbPU7QP+zOZQ+Ewzbztv0cUgu9KY0qi9cxmk/Zv4bZ98MjJv9QSu5hH/J GR8LD0UDCqaDLPsiiinE+xDJtZBH+8PWy07Xqg85Cl0HAaR49lItklubtGecSt7oRZbdz/ ujqbGk1IzOSRnKjFxmn+CgZM0nIDO1NVXbcIFYaRkaHAZ4KqlhtXjoF+AMFXWJnDsMd7XL dHEkyg/GSfZezwTMk9o56vLkn8dgPjZt3u9A2GkqY+jxt1rzKoJuUZOkfW1gjIJgCbOiuk zLR1Tv6gwFsfXH4iyCIlVMb7H8HneKRdGQo69ZdWiyy1Mo+qoPARzm9ndZuxZw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=NeLezWnR; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.07 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=NeLezWnR; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 71A8EC079 X-Spam-Score: 6.07 X-Migadu-Scanner: scn1.migadu.com X-TUID: 67GUJYBXq3lm Hi, Minor suggestions, for what they are worth. :-) On mer., 19 oct. 2022 at 23:00, "\( via Guix-patches" via wrote: > +The @code{git send-email} and @code{git format-patch} commands allow you > +to send your commits in email form to a mailing list, to be reviewed and > +applied, and they are the recommended way to submit contributions to Gui= x. > +When you send the first revision of a patch series, it's best to use > +@code{git format-patch --cover-letter}. > +@example > +$ git format-patch -$N -o outgoing --cover-letter > +@end example Here=E2=80=A6 > + > +@quotation Note > +The @code{git send-email} command is provided by the @code{send-email} > +output of the @code{git} package, i.e. @code{git:send-email}. > +@end quotation > + > +This command makes patches out of the last @var{N} commits, and writes > +them to @code{.patch} files in @code{outgoing/}, along with an automatic= ally > +generated cover letter. We can then send the cover letter to the Guix > +mailing list. =E2=80=A6or in these explanations, I would also suggest the option =E2=80= =99--base=E2=80=99; as recommended by item #1 in subsection =C2=ABSubmitting Patches=C2=BB. [...] > +At some point, the Debbugs mailer will reply to your cover letter mail > +with an acknowledgement, which contains the issue number of your patchse= t. > +You should now send the rest of the patches to this issue thread, using > +the @code{@var{ISSUE_NUMBER}@@debbugs.gnu.org} address. I agree that ISSUE_NUMBER is a better name than NNN or else. Therefore, maybe it could be worth to also tweak it in the section Teams. [...] > +The use of the @code{etc/teams.scm} script to notify the appropriate team > +members (@pxref{Teams}) is recommended when submitting patches, to maxim= ize > +the chances of your patch series being reviewed quickly. I would advertise about Teams early in this section. Maybe in the first paragraph. Cheers, simon