unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Guillaume Le Vaillant <glv@posteo.net>
To: Artyom Bologov <mail@aartaka.me>
Cc: 59193@debbugs.gnu.org
Subject: [bug#59193] [PATCH] gnu: sbcl-njson: Update to 0.2.1.
Date: Fri, 18 Nov 2022 12:47:04 +0000	[thread overview]
Message-ID: <87a64oct0l.fsf@kitej> (raw)
In-Reply-To: <87cz9k1omt.fsf@aartaka.me>


[-- Attachment #1.1: Type: text/plain, Size: 921 bytes --]

Artyom Bologov <mail@aartaka.me> skribis:

> Hello Guillaume,
>
>> The sbcl-nactivitypub package fails to build with sbcl-njson 0.2.1.
>> Could you take a look at it?
>
> Yes, see the attached patch updating sbcl-nactivitypub too!
>
> [2. Update cl-nactivitypub. --- text/x-patch; 0001-gnu-Update-cl-nactivitypub-to-0.0.3.patch]...
>
>
> Thanks,

Hi,

The sbcl-nactivitypub-0.0.3 package still fails to build.

The first error I got was: "The name NJSON/ALIASES does not designate
any package." I was able to get a bit further by applying the attached
patch to build the missing njson/aliases subsystem and adding it to
the 'depends-on' field in "nactivitypub.asd".

I then hit another error: "nactivitypub.lisp" is trying to use
a njson/aliases:truep symbol that doesn't exist. I took a look at
exported symbols of njson and njson/aliases, and I think nactivitypub
should use either njson:jtruep or njson/aliases:true.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-cl-njson-Build-extra-systems.patch --]
[-- Type: text/x-patch, Size: 988 bytes --]

From 1896223a12fb5713a12b81fb683232ddc8a06b61 Mon Sep 17 00:00:00 2001
From: Guillaume Le Vaillant <glv@posteo.net>
Date: Fri, 18 Nov 2022 13:34:32 +0100
Subject: [PATCH] gnu: cl-njson: Build extra systems.

* gnu/packages/lisp-xyz.scm (sbcl-njson)[arguments]: Add "njson/aliases" and
  "njson/cl-json" to 'asd-systems'.
---
 gnu/packages/lisp-xyz.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index 1c0100bbe4..b3abe264f0 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -22804,6 +22804,8 @@ (define-public sbcl-njson
     (build-system asdf-build-system/sbcl)
     (inputs (list sbcl-cl-json))
     (native-inputs (list sbcl-lisp-unit2))
+    (arguments
+     '(#:asd-systems '("njson" "njson/aliases" "njson/cl-json")))
     (home-page "https://github.com/atlas-engineer/njson")
     (synopsis "JSON handling framework for Common Lisp")
     (description
-- 
2.38.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

  reply	other threads:[~2022-11-18 13:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-11 12:49 [bug#59193] [PATCH] gnu: sbcl-njson: Update to 0.2.1 Artyom Bologov
2022-11-15  9:56 ` Guillaume Le Vaillant
2022-11-18 11:34   ` Artyom Bologov
2022-11-18 12:47     ` Guillaume Le Vaillant [this message]
2022-11-18 18:42       ` Artyom Bologov
2022-11-19 11:59         ` bug#59193: " Guillaume Le Vaillant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a64oct0l.fsf@kitej \
    --to=glv@posteo.net \
    --cc=59193@debbugs.gnu.org \
    --cc=mail@aartaka.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).