From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id +OgtDxQQtWNWawAAbAwnHQ (envelope-from ) for ; Wed, 04 Jan 2023 06:35:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id PusmDxQQtWNbrwAA9RJhRA (envelope-from ) for ; Wed, 04 Jan 2023 06:35:16 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 17B893C447 for ; Wed, 4 Jan 2023 06:35:15 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pCwQe-00063q-LR; Wed, 04 Jan 2023 00:35:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCwQa-00063c-6m for guix-patches@gnu.org; Wed, 04 Jan 2023 00:35:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pCwQY-0005ai-9y for guix-patches@gnu.org; Wed, 04 Jan 2023 00:35:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pCwQY-0000oN-12 for guix-patches@gnu.org; Wed, 04 Jan 2023 00:35:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59761] [PATCH 0/2] Add u-boot-ts7970-q-2g-1000mhz-c. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 04 Jan 2023 05:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59761 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ricardo Wurmus Cc: 59761@debbugs.gnu.org Received: via spool by 59761-submit@debbugs.gnu.org id=B59761.16728104873092 (code B ref 59761); Wed, 04 Jan 2023 05:35:01 +0000 Received: (at 59761) by debbugs.gnu.org; 4 Jan 2023 05:34:47 +0000 Received: from localhost ([127.0.0.1]:47324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCwQJ-0000nn-Cg for submit@debbugs.gnu.org; Wed, 04 Jan 2023 00:34:47 -0500 Received: from mail-qt1-f172.google.com ([209.85.160.172]:42921) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCwQH-0000nW-PP for 59761@debbugs.gnu.org; Wed, 04 Jan 2023 00:34:46 -0500 Received: by mail-qt1-f172.google.com with SMTP id i20so26479738qtw.9 for <59761@debbugs.gnu.org>; Tue, 03 Jan 2023 21:34:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=NXoT64m3Q/rLbk+uuylfgvpbnUNnWP+rWfHhkWICqv4=; b=cRXBteWtrX3RMJkXcR66wSLq2fKnlajvxV2xmE2qNRdE5oEey8gAzDq46AeMMAbw4H VKpun8e1wlIv8QW5VsH07Lo4Xn9apEw2ysCLDj54zbCIIHAcbG5B0Iqy40eILn42o7tL 36dKxK710YF4JhzJAczrYAThsL/DHY7zwwa0j/KVoKZTRrD/7cA96HnOJst7YSkJ4QsZ 7HH+ykUoQDSphsi9sjtPm5lDIxuDmdxiMAK8kkTJhXC2+xTP299snmpn8rTc8AFmi8Ec Rd7Yu2MkkcS0gUD+Ao8mij6qhb8KBUUVFX0SzIY6NlCBzfFvspqI0EJfpkPOslTXfW0j sCzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NXoT64m3Q/rLbk+uuylfgvpbnUNnWP+rWfHhkWICqv4=; b=T7RdVf9NaOHXv3475+nPCI7+bgm0EiGSVOJcZmVuwXv9+zvcpkw3njfSCewrYWkmq/ rLp8sEezVnbjW0Krn4XkUyCKbT0RxVFtCEt2B8LrSmXSqLHqlwfIWEgSF5ZcBRgpD+56 aa1erTckEZuB/L3FyDS4g6QajXaVJ5Qcm4L+hkq2/35dS3osSDQr8MArRuAtzlkzBVOs Ci213eHM3tOmGE0pRUsV2abUQzNskwcnhbYBZ1bbBvtQCdP0oSwOAkRyKwunKFAsym3T vWNQlxF8G5My/ppgZbejVo/JsHh3uy+affVf36XcxtEbeXICo9SHfLve8UWfN13YotUV SF3Q== X-Gm-Message-State: AFqh2krOHlRFZbi+yN2QykfY9KGSJykNGExINCas1zBkdlNNybxSeWa8 NQNesRLPriYF2EBeK7K/1eGCwAgG8C+98NkD X-Google-Smtp-Source: AMrXdXv8NpSgr7v6SGXwEFgrb7DLwTlWAfjXoBkv2+AzMjQ5YpzY+an0AJGxv8eb0Vh1DkgZ+Wfi+Q== X-Received: by 2002:ac8:544d:0:b0:3a7:fc75:22c6 with SMTP id d13-20020ac8544d000000b003a7fc7522c6mr83964390qtq.33.1672810480081; Tue, 03 Jan 2023 21:34:40 -0800 (PST) Received: from hurd (dsl-10-135-221.b2b2c.ca. [72.10.135.221]) by smtp.gmail.com with ESMTPSA id u2-20020a37ab02000000b006fc92cf4703sm22807198qke.132.2023.01.03.21.34.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jan 2023 21:34:39 -0800 (PST) From: Maxim Cournoyer References: <20221202052903.10475-1-maxim.cournoyer@gmail.com> <871qoi9f0b.fsf@elephly.net> <87ilhnvsqr.fsf_-_@gmail.com> Date: Wed, 04 Jan 2023 00:34:38 -0500 In-Reply-To: <87ilhnvsqr.fsf_-_@gmail.com> (Maxim Cournoyer's message of "Tue, 03 Jan 2023 23:17:00 -0500") Message-ID: <87a62yx3pt.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1672810516; a=rsa-sha256; cv=none; b=jdxgu6nn4ETBLgziR/U8M+eGxDT+soa1OoVNXGu84CxtMNXmyGWrgY9oQkBiUlnuY6wqf1 vyLMXhoUgzUKYT81HiXO7aWu3NJCrKsw0/2Fpf7Ftf8bEeA8MPNLreKOTd74nHXTwAojiN Disy/7k3I9WFGVozy+4RiXja08UlhAAEMSGWYu9oQbn21CaYSox8Em0hI5yZeMdIYuPBy4 ip1Lau04p1lfPk8v666WrF0EDnZZmWR/0Th3i16rVKxm5G8na5FwesqO+Fx9N9P2qcr2p5 FrBhe73uV7Y8bacFxUDhdILJM5tElYQ9XL818eOdQg6vp45A6frkjFQEaVuk+g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=cRXBteWt; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1672810516; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=NXoT64m3Q/rLbk+uuylfgvpbnUNnWP+rWfHhkWICqv4=; b=uaJeHlf6/NdzD5xFKsjk3D45ONQuSqCvlmGmg8qGoMDb9LDbgqK6za3Y5Z8BV6a32BZJ/v KprTADWF5+ohH3LOSwj2fWRGyhF1jOZidoz5NH0FX5B7QTPBIHJk16FTTKuA9hpnftQgYP uvE9E9MA+KfhLjEp4yXbWB5vCRkPp3ht34FrDYCuc+b/bzblTSuA4XlLB8l0pVXym133zM G5vQIZBYQgTiNV54I1odH9RRSHKIefFMNY/ZaHUJq3ui87GIFzO0G3YITIjDdE7d/sJkKr I6TA2dqA2K1Nj5AFQxxizMJQcFeCJDT6gqx4+LCLQP3kYv2QsQSAZOm/QGXglA== X-Spam-Score: -1.46 X-Migadu-Queue-Id: 17B893C447 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=cRXBteWt; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -1.46 X-TUID: IYzxLyKY9agR Hi, Maxim Cournoyer writes: >> For something as >> long as the replacements in this package consider using a patch file >> instead. This has the added advantage of failing the build when the >> patch cannot be applied cleanly. > > I agree that a patch would be most suitable here, especially that if > something breaks, if would likely be silent (unlikely to be caught at > build time). I'll extract this as a patch. After re-diving into the code, I opted to kept it as a substitution given it affects multiple config files in the same way, and would make a large, redundant patch. I cleaned it up per your suggestions (see v5). -- Thanks, Maxim