unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Sergiu Ivanov <sergiu.ivanov@univ-evry.fr>
Cc: 58120-done@debbugs.gnu.org, 60840-done@debbugs.gnu.org
Subject: bug#60840: [PATCH 0/3] gnu: volctl: Update to 0.9.3.
Date: Sun, 22 Jan 2023 16:28:06 -0500	[thread overview]
Message-ID: <87a62a1cpl.fsf@gmail.com> (raw)
In-Reply-To: <871qnnfqu1.fsf@univ-evry.fr> (Sergiu Ivanov's message of "Sat, 21 Jan 2023 23:45:11 +0100")

Hello,

Sergiu Ivanov <sergiu.ivanov@univ-evry.fr> writes:

> Hi again,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> [2023-01-16T18:01:59+0100]:
>>
>> Don't forget to CC my email when sending a revised v2 version with the
>> above :-).
>
> I CCed you, but Google doesn't like another quirk in my E-mail
> configuration which I don't have motivation to debug :-S
>
> I therefore sending you a small ping from my work E-mail, and I'm
> attaching the 3 updated patches just in case it is more convenient
> for you.

Thanks!  I've made cosmetic adjustments to the update commit like so:

--8<---------------cut here---------------start------------->8---
modified   gnu/packages/gtk.scm
@@ -2968,12 +2968,17 @@ (define-public volctl
            (lambda* (#:key inputs #:allow-other-keys)
              (substitute* "volctl/xwrappers.py"
                (("libXfixes.so")
-                (string-append (search-input-file inputs "/lib/libXfixes.so")))))))))
+                (string-append (search-input-file inputs
+                                                  "/lib/libXfixes.so")))))))))
     (inputs
      (list libxfixes))
     (propagated-inputs
-     (list python-click python-pycairo python-pygobject python-pyyaml
-           python-pulsectl gtk+))
+     (list python-click
+           python-pycairo
+           python-pygobject
+           python-pyyaml
+           python-pulsectl
+           gtk+))
     (home-page "https://buzz.github.io/volctl/")
     (synopsis "Per-application volume control and on-screen display")
     (description "Volctl is a PulseAudio-enabled tray icon volume control and
--8<---------------cut here---------------end--------------->8---

added a proper GNU Change Log to the commit message:

--8<---------------cut here---------------start------------->8---
gnu: volctl: Update to 0.9.3.

Fixes <https://issues.guix.gnu.org/58120>.

* gnu/packages/gtk.scm (volctl): Update to 0.9.3.
[arguments]: Update substitutions in patch-path phase and delete
trailing #t.
[inputs]: Delete pulseaudio.  Move gtk+ to...
[propagated-inputs] ... here.
--8<---------------cut here---------------end--------------->8---

and pushed the series!

Notice that in my environment, it doesn't run:

--8<---------------cut here---------------start------------->8---
$ volctl
PulseAudio connected
Warning: Could not embed Gtk.StatusIcon.
Fatal error: Could not create a status icon. Are you sure you have a working notification area?
pulseaudio disconnected
Alarm clock
--8<---------------cut here---------------end--------------->8---

although I have 'dunst' running on top of my ratpoison WM.

-- 
Thanks,
Maxim




  parent reply	other threads:[~2023-01-22 21:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-15 22:35 [bug#60840] [PATCH 0/3] gnu: volctl: Update to 0.9.3 Sergiu Ivanov
     [not found] ` <handler.60840.B.167382229432354.ack@debbugs.gnu.org>
2023-01-15 22:46   ` [bug#60840] [PATCH 1/3] gnu: volctl: Make the synopsis line shorter Sergiu Ivanov
2023-01-16 16:56     ` [bug#60840] [PATCH 0/3] gnu: volctl: Update to 0.9.3 Maxim Cournoyer
2023-01-21 22:20       ` Sergiu Ivanov
2023-01-15 22:49   ` [bug#60840] [PATCH 2/3] gnu: packages: Add python-pulsectl Sergiu Ivanov
2023-01-16 17:01     ` [bug#60840] [PATCH 0/3] gnu: volctl: Update to 0.9.3 Maxim Cournoyer
     [not found]       ` <871qnnfqu1.fsf@univ-evry.fr>
2023-01-22 21:28         ` Maxim Cournoyer [this message]
2023-01-23 17:38           ` Sergiu Ivanov
2023-01-16 17:06     ` Maxim Cournoyer
2023-01-21 22:30       ` Sergiu Ivanov
2023-01-15 22:51   ` [bug#60840] [PATCH 3/3] " Sergiu Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a62a1cpl.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=58120-done@debbugs.gnu.org \
    --cc=60840-done@debbugs.gnu.org \
    --cc=sergiu.ivanov@univ-evry.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).