unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#63021] [PATCH] gnu: Add diffpdf.
@ 2023-04-22 16:57 Olivier Dion via Guix-patches via
  2023-04-30 20:46 ` bug#63021: " Ludovic Courtès
  0 siblings, 1 reply; 3+ messages in thread
From: Olivier Dion via Guix-patches via @ 2023-04-22 16:57 UTC (permalink / raw)
  To: 63021; +Cc: Olivier Dion

* gnu/packages/pdf.scm (diffpdf): New variable.
---
 gnu/packages/pdf.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
index 17637af0f6..357fed0a61 100644
--- a/gnu/packages/pdf.scm
+++ b/gnu/packages/pdf.scm
@@ -78,6 +78,7 @@ (define-module (gnu packages pdf)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages image)
   #:use-module (gnu packages javascript)
+  #:use-module (gnu packages kde-frameworks)
   #:use-module (gnu packages lesstif)
   #:use-module (gnu packages libffi)
   #:use-module (gnu packages linux)
@@ -165,6 +166,38 @@ (define-public a4pdf
 convert data in any way.")
     (license license:asl2.0)))
 
+(define-public diffpdf
+  (let ((commit "ba68231d3d05e0cb3a2d4a4fca8b70d4044f4303"))
+    (package
+      (name "diffpdf")
+      (version "2.1.2")
+      (source
+       (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://gitlab.com/eang/diffpdf")
+             (commit commit)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1vwgv28b291lrcs9fljnlbnicv16lwj4vvl4bz6w3ldp9n5isjmf"))))
+      (build-system cmake-build-system)
+      (arguments
+       `(#:tests? #f))
+      (inputs
+       (list
+        extra-cmake-modules
+        qtbase-5
+        qttools-5
+        poppler-qt5))
+      (native-inputs
+       (list pkg-config))
+      (home-page "http://www.qtrac.eu/diffpdf-foss.html")
+      (synopsis "Compare two PDF files")
+      (description
+       "@command{diffpdf} offers three comparison modes: Words, Characters,
+and Appearance.")
+      (license license:gpl2))))
+
 (define-public extractpdfmark
   (package
     (name "extractpdfmark")
-- 
2.39.2





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#63021: [PATCH] gnu: Add diffpdf.
  2023-04-22 16:57 [bug#63021] [PATCH] gnu: Add diffpdf Olivier Dion via Guix-patches via
@ 2023-04-30 20:46 ` Ludovic Courtès
  2023-04-30 21:20   ` [bug#63021] " Olivier Dion via Guix-patches via
  0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2023-04-30 20:46 UTC (permalink / raw)
  To: Olivier Dion; +Cc: 63021-done

[-- Attachment #1: Type: text/plain, Size: 290 bytes --]

Hi,

Olivier Dion <olivier.dion@polymtl.ca> skribis:

> * gnu/packages/pdf.scm (diffpdf): New variable.

Applied with the changes below: addressing ‘guix lint’ warnings, using a
version string that matches the latest tag, and passing it through ‘guix
style’.

Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1990 bytes --]

diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
index 6eea3c68d0..ddac5537f0 100644
--- a/gnu/packages/pdf.scm
+++ b/gnu/packages/pdf.scm
@@ -168,35 +168,30 @@ (define-public a4pdf
     (license license:asl2.0)))
 
 (define-public diffpdf
-  (let ((commit "ba68231d3d05e0cb3a2d4a4fca8b70d4044f4303"))
+  (let ((commit "ba68231d3d05e0cb3a2d4a4fca8b70d4044f4303")
+        (revision "1"))
     (package
       (name "diffpdf")
-      (version "2.1.2")
-      (source
-       (origin
-       (method git-fetch)
-       (uri (git-reference
-             (url "https://gitlab.com/eang/diffpdf")
-             (commit commit)))
-       (file-name (git-file-name name version))
-       (sha256
-        (base32 "1vwgv28b291lrcs9fljnlbnicv16lwj4vvl4bz6w3ldp9n5isjmf"))))
+      (version (git-version "2.1.3.1" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://gitlab.com/eang/diffpdf")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "1vwgv28b291lrcs9fljnlbnicv16lwj4vvl4bz6w3ldp9n5isjmf"))))
       (build-system cmake-build-system)
       (arguments
        `(#:tests? #f))
-      (inputs
-       (list
-        extra-cmake-modules
-        qtbase-5
-        qttools-5
-        poppler-qt5))
-      (native-inputs
-       (list pkg-config))
+      (inputs (list qtbase-5 qttools-5 poppler-qt5))
+      (native-inputs (list pkg-config extra-cmake-modules))
       (home-page "http://www.qtrac.eu/diffpdf-foss.html")
       (synopsis "Compare two PDF files")
       (description
-       "@command{diffpdf} offers three comparison modes: Words, Characters,
-and Appearance.")
+       "@command{diffpdf} lets you compare PDF files, offering three
+comparison modes: words, characters, and appearance.")
       (license license:gpl2))))
 
 (define-public extractpdfmark

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#63021] [PATCH] gnu: Add diffpdf.
  2023-04-30 20:46 ` bug#63021: " Ludovic Courtès
@ 2023-04-30 21:20   ` Olivier Dion via Guix-patches via
  0 siblings, 0 replies; 3+ messages in thread
From: Olivier Dion via Guix-patches via @ 2023-04-30 21:20 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 63021-done

On Sun, 30 Apr 2023, Ludovic Courtès <ludo@gnu.org> wrote:
> Hi,
>
> Olivier Dion <olivier.dion@polymtl.ca> skribis:
>
>> * gnu/packages/pdf.scm (diffpdf): New variable.
>
> Applied with the changes below: addressing ‘guix lint’ warnings, using a
> version string that matches the latest tag, and passing it through ‘guix
> style’.

Thanks!  Sorry for the inconveniences!

-- 
Olivier Dion
oldiob.dev




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-05-01  5:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-22 16:57 [bug#63021] [PATCH] gnu: Add diffpdf Olivier Dion via Guix-patches via
2023-04-30 20:46 ` bug#63021: " Ludovic Courtès
2023-04-30 21:20   ` [bug#63021] " Olivier Dion via Guix-patches via

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).