From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 60369@debbugs.gnu.org
Cc: simon@josefsson.org, ludo@gnu.org
Subject: [bug#60369] [PATCH v2] gnu: Add eweouz.
Date: Wed, 03 May 2023 14:59:22 +0200 [thread overview]
Message-ID: <87a5ylvadx.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87bkm859at.fsf_-_@josefsson.org> (Simon Josefsson via Guix-patches via's message of "Sun, 05 Feb 2023 18:08:58 +0100")
Hello,
Thank you.
> + (arguments
You should use G-expressions from here:
(list
#:modules '(...)
#:imported-modules `(...)
#:configure-flags
#~(list (string-append ... (emacs:elpa-directory #$output))))
#:phases
#~(modify-phases ...)
> + (add-after 'enter-lisp-dir 'emacs-patch-variables
> + (lambda* (#:key outputs #:allow-other-keys)
This is not necessary: lambda _
> + (make-file-writable "eweouz.el")
I think you can remove this line.
> + (substitute* "eweouz.el"
> + (("\\(setq eweouz-helper-dirs '\\(")
> + (format #f "(setq eweouz-helper-dirs '(~s "
> + (string-append (assoc-ref outputs "out")
> + "/libexec/eweouz"))))))
You should use emacs:emacs-substitute-variables here.
> + (add-after 'emacs-patch-variables 'emacs-expand-load-path
> + (assoc-ref emacs:%standard-phases 'expand-load-path))
> + (add-after 'emacs-expand-load-path 'emacs-add-install-to-native-load-path
> + (assoc-ref emacs:%standard-phases 'add-install-to-native-load-path))
> + (add-after 'emacs-add-install-to-native-load-path 'emacs-install
> + (assoc-ref emacs:%standard-phases 'install))
> + (add-after 'emacs-install 'emacs-build
> + (assoc-ref emacs:%standard-phases 'build))
> + (add-after 'emacs-install 'emacs-make-autoloads
> + (assoc-ref emacs:%standard-phases 'make-autoloads)))))
> + (native-inputs
> + (list autoconf
> + automake
> + emacs-minimal
> + pkg-config))
> + (inputs
> + (list evolution-data-server))
> + (home-page "https://tracker.debian.org/pkg/eweouz")
> + (synopsis "Emacs interface to Evolution Data Server")
> + (description
> + "eweouz is an tool for looking up contacts from Evolution Data
> Server
Typo and capitalization: Eweouz is a tool...
> +from Emacs. It is similar to BBDB, except much, much simpler.")
You should separate sentences with two spaces.
> + ;; Most things are GPLv2-only although lisp/vcard.el is GPLv2+.
> + (license (list license:gpl2 license:gpl2+))))
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2023-05-03 13:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 22:47 [bug#60369] [PATCH] gnu: Add eweouz Simon Josefsson via Guix-patches via
2023-01-31 22:42 ` Ludovic Courtès
2023-02-05 17:08 ` [bug#60369] [PATCH v2] " Simon Josefsson via Guix-patches via
2023-04-28 8:35 ` Simon Josefsson via Guix-patches via
2023-05-03 12:59 ` Nicolas Goaziou [this message]
2023-05-05 9:11 ` [bug#60369] [PATCH v3] " Simon Josefsson via Guix-patches via
2023-05-08 17:24 ` bug#60369: " Nicolas Goaziou
2023-05-09 7:21 ` [bug#60369] " Simon Josefsson via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5ylvadx.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=60369@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=simon@josefsson.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).