unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Vagrant Cascadian <vagrant@debian.org>
To: Z572 <873216071@qq.com>, 64068@debbugs.gnu.org
Cc: "Ludovic Courtès" <ludo@gnu.org>,
	"Efraim Flashner" <efraim@flashner.co.il>
Subject: [bug#64068] [PATCH] gnu: Add u-boot-lichee-rv-dock.
Date: Fri, 16 Jun 2023 11:49:45 -0700	[thread overview]
Message-ID: <87a5wzb5ti.fsf@wireframe> (raw)
In-Reply-To: <tencent_3EF2C09293DA8FCDB954992CE5BF101D8F07@qq.com>

[-- Attachment #1: Type: text/plain, Size: 1295 bytes --]

On 2023-06-14, Z572 wrote:
> * gnu/packages/bootloaders.scm (u-boot-lichee-rv-dock): New variable.
> * gnu/packages/patches/u-boot-lichee-rv-dock-disable-openssl.patch: New file.
> * gnu/local.mk(dist_patch_DATA): register it.

Thanks for the patches!

This also reminds me that u-boot is falling a little behind (there is
2023.01, 2023.04 and soon 2023.07)... and while I would not want to block
adding support for this board, I would be curious if it still works with
newer u-boot versions...


> +(define-public u-boot-lichee-rv-dock
...
> +                  (search-patches
> +                   "u-boot-lichee-rv-dock-disable-openssl.patch")
> +                  ;;; rebase from %u-boot-allow-disabling-openssl-patch
> +                  (filter (negate (cut string-contains <> "openssl"))
> +                          (origin-patches (package-source base)))))

This seems a little tricky and possibly error-prone if another patch
with openssl in the name is included at a later time, it could break
this package. I almost wonder if it wouldn't be better to merge the
functionality of the two patches disabling openssl than applying a
board-specific patch?


I have not had a chance to test that this package builds; I presume you
have tested that it actually boots?


live well,
  vagrant

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2023-06-16 18:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-14 14:09 [bug#64068] [PATCH] gnu: Add u-boot-lichee-rv-dock Z572 via Guix-patches via
2023-06-16 18:49 ` Vagrant Cascadian [this message]
     [not found]   ` <87r0qauk7q.fsf@qq.com>
2023-06-17 14:25     ` Z572 via Guix-patches via
2023-07-02  2:54       ` Vagrant Cascadian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5wzb5ti.fsf@wireframe \
    --to=vagrant@debian.org \
    --cc=64068@debbugs.gnu.org \
    --cc=873216071@qq.com \
    --cc=efraim@flashner.co.il \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).