From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id EMzyHF8MkmTOSwEASxT56A (envelope-from ) for ; Tue, 20 Jun 2023 22:30:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id YG49HF8MkmRkmAAAG6o9tA (envelope-from ) for ; Tue, 20 Jun 2023 22:30:23 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D709D38DF0 for ; Tue, 20 Jun 2023 22:30:22 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qBhzJ-0004YO-PA; Tue, 20 Jun 2023 16:30:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBhzH-0004Xu-2V for guix-patches@gnu.org; Tue, 20 Jun 2023 16:30:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qBhzG-0007i9-Nw for guix-patches@gnu.org; Tue, 20 Jun 2023 16:30:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qBhzG-0006Dj-0E for guix-patches@gnu.org; Tue, 20 Jun 2023 16:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63566] [PATCH] gnu: add tcptrack Resent-From: Jelle Licht Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 20 Jun 2023 20:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63566 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jakob Kirsch , 63566@debbugs.gnu.org Cc: Jakob Kirsch Received: via spool by 63566-submit@debbugs.gnu.org id=B63566.168729298723862 (code B ref 63566); Tue, 20 Jun 2023 20:30:01 +0000 Received: (at 63566) by debbugs.gnu.org; 20 Jun 2023 20:29:47 +0000 Received: from localhost ([127.0.0.1]:59826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBhz0-0006Cn-Lf for submit@debbugs.gnu.org; Tue, 20 Jun 2023 16:29:46 -0400 Received: from mail1.fsfe.org ([217.69.89.151]:35258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBhyy-0006Cc-61 for 63566@debbugs.gnu.org; Tue, 20 Jun 2023 16:29:45 -0400 From: Jelle Licht DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fsfe.org; s=2021100501; t=1687292981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aX2K4hHxIg/zVDa8KnkqpraB3cAyaQ9TmnI/l3aNNjU=; b=hHj2VkN9l9OP2VINyu8jqh1dXIB8Eiw0Nbu3FHIzru1V3vyrEWqZur6lE5FHbx2lMRnnry BcgFqqMiwcXBA/mqb6KxT6VFkmML+0+34oGGf5Vt/Ea5jy5X8pR5DXJ/+k0Gg55G0si4Pj Fdk2KD8RfD0jzuFE3KV2KOkbICONR1g= In-Reply-To: <3e95e1934550698a5ce8b2395ac591df6c5fe9b3.1684348522.git.jakob.kirsch@web.de> References: <3e95e1934550698a5ce8b2395ac591df6c5fe9b3.1684348522.git.jakob.kirsch@web.de> Date: Tue, 20 Jun 2023 22:29:41 +0200 Message-ID: <87a5wt7u8a.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1687293023; a=rsa-sha256; cv=none; b=IKrXwBG6XLBceKbGLWixreq1SsPi7ronXh6W3n9gIMmy6nilmYdgZL7kyuoR52RAWAwbyg JmcMky3f8GTHpNDM+Mp+DosUkQMT4Ck/7lL3tFTZGOa4OFa7r0yFkBCrsAQdDAWYst2yuh FLpUE76XRTHhd9JpQs69m3/cRtSmJcWMryp5W+JFuSQwb20wLrS9PBceQSR1jqVO6wsOpu 71v1t4mPa2OqFJHRpCZukmI13+aIRjd836VftSG2oYm71uC0TF+1PJ24lL5DAuQzxFJtiR 8CmhwNfS9QlB+Zn4GW1YQlRHgW8CeVX6PG0i9nlmSBluD5DMV8V/+KZJFD7i4g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=fsfe.org header.s=2021100501 header.b=hHj2VkN9; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fsfe.org (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1687293023; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=aX2K4hHxIg/zVDa8KnkqpraB3cAyaQ9TmnI/l3aNNjU=; b=tTIrxeE/E6DWE7vpnGG0CyVYUm3k/0qDJwevIxJw6ILo2KI4HNfYz4/MofqjrgM6dHrswD Eb5S4HnVHAFG2FdAWomxlYoHCRO/dWmytqdEm2z/9MvgvfvpuDwGZqzGUBvX7t87RE7Wsb bzlfvm8Zw1HgKxD646EdS33r3vK0lQ6qKr5KxJUyz6eYDxF8PzORfV4VXucbdoGcBSq2/J /bFAOk3LVYfIY2fKnLRur/2K9gw/QgYQj/rS0lAPK5PaxYLKMJUwXU1gOOg9zI0GJIzUA+ g3Lmd4VpPKNbERcf/f29EzWFqpr74cORFd8T2M3VUWpVUbUOo4ZllMN+86561w== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=fsfe.org header.s=2021100501 header.b=hHj2VkN9; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fsfe.org (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -2.94 X-Spam-Score: -2.94 X-Migadu-Queue-Id: D709D38DF0 X-TUID: b+yszSfyu0jj Hi Jakob, Thank you for the patch! Delayed as it may be, I have some small points of order to share. We try to follow the Changelog format in commit logs, see https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html for the thorough explanation (or just have a look at commit logs for some of the other packages that were added by people). Jakob Kirsch writes: > --- > gnu/packages/admin.scm | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm > index 047b0ebcc6..0ae883e0b4 100644 > --- a/gnu/packages/admin.scm > +++ b/gnu/packages/admin.scm > @@ -4255,6 +4255,30 @@ (define-public thermald > (supported-systems '("i686-linux" "x86_64-linux")) > (license license:gpl2))) > > +(define-public tcptrack > + (package > + (name "tcptrack") > + (version "1.4.3") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/bchretien/tcptrack") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "08lh3l67wn4kq9q0nfspc7rj0jvp9dzwjgxpvqliwcif8cy5mi45"))= )) > + (build-system gnu-build-system) > + (arguments > + `(#:tests? #f)) Please add a comment explaining why tests are disabled (e.g. `; no tests') > + (inputs (list libpcap ncurses)) > + (synopsis "Display information about TCP connections") > + (description > + "A sniffer which displays information about TCP connections it > +sees on a network interface. (backup from Steve Bensons's tcptrack)") The description should contain complete sentences, if possible. How about something like this: Tcptrack is a sniffer which displays information about TCP connections it sees on a network interface. This is a fork of Steve Benson=E2=80=99s tcptrack. (Note the double spacing after the .) > + (home-page "https://github.com/bchretien/tcptrack") > + (license license:lgpl2.1))) Having looked at the source archives, I think there are a bunch of GPLv2+ licensed source files in the tarball (note the missing L). Could you perhaps open an issue so the author(s) could (re)confirm the status of these source files? The folks over at [1] also indicate the package is licensed as GPLv2+, so there may be some confusion about the licensing status of the package. Cheers, Jelle [1]: https://directory.fsf.org/wiki/Tcptrack#tab=3DOverview