From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id GPYLE0BU3mSYEAEASxT56A (envelope-from ) for ; Thu, 17 Aug 2023 19:09:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id qGPhEkBU3mS29QAAauVa8A (envelope-from ) for ; Thu, 17 Aug 2023 19:09:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B93F748E6B for ; Thu, 17 Aug 2023 19:09:19 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b="q/7RLD8m"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1692292160; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=sF6sFlj/XWsHHj48qqLmYjXG0EgiYjXYOpb/WpXY9XA=; b=hfEd2BZXcRd2xp4KZaNNA/GGGNEWHtDUIQ/mIlr6TJpiBYnmDM7hck7KdfV8SsdW5JXuH1 D7yoDLU4+cBOtJISA+1sbk6e/g2ISxYOvy1M/+XvsrilOCP4JgGZGH8nGdjZk9kaISvIKy zh5wTacNet/GiQAMW11iF01DrarchsUqHdarZfaPdCQ9FCGI5bjiohQPevGUASV44nUz4m HeU8MyJbeFjcMPgmKhAlkdquUX7VuHT700hy/lzJIUgdVQZG+Rq9kGJCQoFUYCkbY4M9U8 b0CAev7wl1he0FBUkWBwKbkwuS37Zj0ia0ZzyKvbk8hGdbwHJk6mzBnYdYDsxA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1692292160; a=rsa-sha256; cv=none; b=ZtiQIXDZP/sx9qz+fda9KNpncKjHq9loCTBUzIqjrnBJVfTn9V5KrMzC7a5oQL2xpIJzk2 60q+eU4moFOiIutTYZWfQ4Gf1d3goynq4MepccpmHBpSnW4YFlryXJRqMiLQe0rdAU5q38 9PuIjDjHfo9DkKA5myj9L/46ZaFWLcMR8I7mEOYa6V+2HmGmO31lgijMFIwnEYyhmllqX4 81kP1BHQkbSUmvYv+iEmm4MPd4arMnw7Mxcuc9AVqlPuzkAosqILCEHmpxznXU/j/93azi lyOksdga5If4lUAAMqKxhq7Zk3E6Ps3Zvii9ZkLavMky06u35Lj+9NlG08USPA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b="q/7RLD8m"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWgUe-0003Pf-Ez; Thu, 17 Aug 2023 13:09:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWgUc-0003PW-Iy for guix-patches@gnu.org; Thu, 17 Aug 2023 13:09:06 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qWgUX-0006qN-NK for guix-patches@gnu.org; Thu, 17 Aug 2023 13:09:06 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qWgUX-0006vE-JS for guix-patches@gnu.org; Thu, 17 Aug 2023 13:09:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64746] [PATCH v2 2/3] pull: Tag commit argument with 'tag-or-commit. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 17 Aug 2023 17:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64746 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Josselin Poiret , Mathieu Othacehe , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , Ricardo Wurmus , 64746@debbugs.gnu.org, Christopher Baines Received: via spool by 64746-submit@debbugs.gnu.org id=B64746.169229209126531 (code B ref 64746); Thu, 17 Aug 2023 17:09:01 +0000 Received: (at 64746) by debbugs.gnu.org; 17 Aug 2023 17:08:11 +0000 Received: from localhost ([127.0.0.1]:45465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWgTi-0006tq-La for submit@debbugs.gnu.org; Thu, 17 Aug 2023 13:08:10 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:39330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWgTf-0006tO-Hi for 64746@debbugs.gnu.org; Thu, 17 Aug 2023 13:08:09 -0400 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-3fe1b6192e8so213425e9.1 for <64746@debbugs.gnu.org>; Thu, 17 Aug 2023 10:08:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692292080; x=1692896880; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=sF6sFlj/XWsHHj48qqLmYjXG0EgiYjXYOpb/WpXY9XA=; b=q/7RLD8meezQYAd/NEnX+PLo28u/5pEpddgQ/3HqdEloFDZ93/f8AHVLRiQGHjrDKo 18qGgqrFwxrbio+DNfF+ioeeLuGfrTtvqP99gA5u3smRk1E+ilP7yWAPllW+9zpxdfdJ sqXVGynTulIGzFZSaKlGerBbbhlpGB3dxMmIFPVo0ZOdQDI3W1qzKL0nJhAlcLkPSycp FI3QJ2BnkJatq4rwr4SR/l0e1jzwOIvQsAShsg0KfNITOFKqciKDuyrFhxJ+eLAcEkid h5pO1dMfKydXcSA0WS2NSoiV1WWF47HEhpFr2stEZg59rtHfauVexmP3MZr7ZAAWkjsF QqSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692292080; x=1692896880; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sF6sFlj/XWsHHj48qqLmYjXG0EgiYjXYOpb/WpXY9XA=; b=KjTVOt3ju7P7tYuLndUS1m7v1iF2diAFo2+NmQnK2Y83iRdHCm3L6p7kkp0tIO6eVY qnxR+FjilxqivHYZPY+pdKiBNw+t1JA8NorIJ5j102Ekdk6E10b10SKJZOOtj96QMAF5 +2524F8VTATq/YNGeLZG0ZK/5sG2d4aC9bjXj5U0gmboBWz9ynxHJ0s+DgDTOV1N5Dsb siGSds+VQZlCTSmuwrAtKhz/zQuMHHP1RDhgfaxO1rsP6wdbuyJh5WKYpFGT2CgGRbbx DXi5/0WikufsH/bB5imStdB9/8yYpkERHd/gUl/ReW320Kor7vIRjnvjT2BpDjNWDB2n TuSQ== X-Gm-Message-State: AOJu0YwbG2wVrXo23BrGGoUHHHcj9umidgfI9q3oBP0S7R1BvT+713Ns D7oR+UablgE9aHX1rRb4r4w= X-Google-Smtp-Source: AGHT+IG49xFDY55KSCo/teF92jRFLdQIVQIwFgbBF/CO4uITUghhmbfE+Ji6WGoKUpvISMrRAL3FeA== X-Received: by 2002:a05:600c:3ba6:b0:3f8:efad:31ee with SMTP id n38-20020a05600c3ba600b003f8efad31eemr260478wms.2.1692292080291; Thu, 17 Aug 2023 10:08:00 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id k1-20020a5d4281000000b00317a29af4b2sm25095928wrq.68.2023.08.17.10.07.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Aug 2023 10:07:59 -0700 (PDT) From: Simon Tournier In-Reply-To: <87bkf6j02r.fsf@gmail.com> References: <340786ccd3d40c0c8906028dc20af5ae9b0aa6b9.1692128648.git.maxim.cournoyer@gmail.com> <87o7j7f2tb.fsf@gmail.com> <87bkf6j02r.fsf@gmail.com> Date: Thu, 17 Aug 2023 16:45:45 +0200 Message-ID: <87a5up4tie.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 4.31 X-Migadu-Scanner: mx2.migadu.com X-Migadu-Queue-Id: B93F748E6B X-Spam-Score: 4.31 X-TUID: B1h8Gdyi7J2/ Hi Maxim, On Wed, 16 Aug 2023 at 14:47, Maxim Cournoyer w= rote: >>> (option '("commit") #t #f >>> (lambda (opt name arg result) >>> - (alist-cons 'ref `(commit . ,arg) result))) >>> + (alist-cons 'ref `(tag-or-commit . ,arg) result))) [...] > (match ref > - (('commit . commit) > + ((or ('commit . commit) > + ('tag-or-commit . commit)) > The reason is to standardize the API of (guix pull) and (guix git), > whose procedure had a different expectation for 'ref' objects. My point is that this =E2=80=99or=E2=80=99 is useless, IIUC. Well, I have = removed it in the series fixing the annoyance with the network access of =E2=80=9Cguix time-machine=E2=80=9D. Cheers, simon