From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id OM8KDHXKJmV7CQAAauVa8A:P1 (envelope-from ) for ; Wed, 11 Oct 2023 18:16:53 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id OM8KDHXKJmV7CQAAauVa8A (envelope-from ) for ; Wed, 11 Oct 2023 18:16:53 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0965A6E275 for ; Wed, 11 Oct 2023 18:16:53 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="SH8Hy/yc"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697041013; a=rsa-sha256; cv=none; b=QA6w3wSqs8xOdMJQbP1v2wha2aOAo8Z+qPLoPwZa4nJYOvqYxCpUJYLcf7Fhy5CO8ha7AL Koxzf2wlMVZn6KGMgjnBy5w2wnsVXsdqts0fgcQWz+8BCRiAMf/bWjgAgkJoO+hjh2OMHO pPAPx4fD/ls5Cs4461o0Kb5V1P/kx1C83b6DxpdQ5Uu4pmlLix5IYEqTys6vdRExyWvF6c y8/uYJpWxOHiP3qWhGSSY5sYOYPnMC87Ac0OSaf4sZF6BDTKbcHykMyVxg/Aen67Ix6pRe liTj5uOm8fG1iqAifBp579uBFSZiyFnVjIh7C+t4vQt8u6AXlFVfutb0IxgcIQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="SH8Hy/yc"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697041013; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=lOKNXzrH0vEsxjto/WJ2mvceOOPukypQNo3OweYk58Y=; b=BZlRFikWwddMW1BDDz2+wufyc62ZpPQ5bsjklBKenwzAmOE+iDufnzw66oVjx/jnjgYh6T QE+3p1CsjSJwcfwZCOoLmisTj0/fKm1LNrybE7T8twRTHh81NPhhjR7vta74e/skhsq2hk pTIy404VTCOLV9FxnGODCsvnlxgu+3vk1NQeAH6+b1bHIeUB8f0sKkJXw+k7VdvIIwXWKM /rLtJkGhspzlbWstzo4NSqAG6LtHs86auU//jOvRGQHyAFaH+obwlGmRlgre/3vxjkUTMs 3kHZXZIeCZ2C9jNv2vEOQPyOCkFpQ/cLtUIwixO5S96PyEpKm4cQL9V4kfjP9Q== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqbt4-0005YX-Ck; Wed, 11 Oct 2023 12:16:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqbt2-0005YA-PV for guix-patches@gnu.org; Wed, 11 Oct 2023 12:16:40 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qqbt2-0001h6-HW for guix-patches@gnu.org; Wed, 11 Oct 2023 12:16:40 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qqbtO-0006n7-CE for guix-patches@gnu.org; Wed, 11 Oct 2023 12:17:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64620] [PATCH] gnu: home: Add home-emacs-service-type. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 11 Oct 2023 16:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64620 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Kierin Bell Cc: cox.katherine.e+guix@gmail.com, "\(" , Andrew Tropin , 64620@debbugs.gnu.org, Liliana Marie Prikler Received: via spool by 64620-submit@debbugs.gnu.org id=B64620.169704100926073 (code B ref 64620); Wed, 11 Oct 2023 16:17:02 +0000 Received: (at 64620) by debbugs.gnu.org; 11 Oct 2023 16:16:49 +0000 Received: from localhost ([127.0.0.1]:39899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqbtB-0006mS-HZ for submit@debbugs.gnu.org; Wed, 11 Oct 2023 12:16:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqbt6-0006m3-ST for 64620@debbugs.gnu.org; Wed, 11 Oct 2023 12:16:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqbsb-0001eM-8X; Wed, 11 Oct 2023 12:16:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=lOKNXzrH0vEsxjto/WJ2mvceOOPukypQNo3OweYk58Y=; b=SH8Hy/yc3n1c40NVCJqW pV53JHOKzzpMxlATHutFCiNrdw73cr0YhprTuvQoTzCU42lvN3d/hUCGMypUna3n9PGFxH042JvB9 LjADdEkdJrTuw0ClxzTQPRBFQk2nA1y2qkVifQcn71JbY7/JU+eJgvn7BmoRd4iKXS+PuouhQ/Ejq mRu9M/jMuhnrH5e6NYAKyFlecybY3QWoBdYCpK7F8WxGYmGR2DVyPe5eMUqrqrqY+oumjjSZ+fFOI T+1YnO69rdXEZCMRQf/YCMJd6HIA42xNWj9ockZVFvKVFulfoc7VvyNcwETP5u9WCrRWdDlQML+H3 byQiWNNERPYk6A==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <87o7iqpeou.fsf@disroot.org> (paren@disroot.org's message of "Tue, 29 Aug 2023 07:03:59 +0100") References: <0173e076aafb6ec389a7ebca5d56b7f4e8a02b6e.1689347338.git.fernseed@fernseed.me> <87il945gzu.fsf@disroot.org> <874jklyk38.fsf@fernseed.me> <873503hebs.fsf@disroot.org> <87y1huvluu.fsf@fernseed.me> <87o7iqpeou.fsf@disroot.org> Date: Wed, 11 Oct 2023 18:16:10 +0200 Message-ID: <87a5spuoc5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -3.79 X-Spam-Score: -3.79 X-Migadu-Queue-Id: 0965A6E275 X-TUID: ckwsZyHbUhEe Hello! If there=E2=80=99s consensus, I think we should go ahead with this patch se= ries. Worst that could happen is that people will think of ways to change the service in one way or another, and that=E2=80=99s fine! Two general comments: =E2=80=A2 As I wrote earlier, I think it=E2=80=99d be nice to have integr= ation tests for this, in addition to the unit tests the patch already adds. =E2=80=A2 We may want to split the patch into sizable, self-contained bit= es. For instance, the (guix read-print) changes should probably be separated out. I=E2=80=99ll provide more specific comments about the code. To Emacs team members: please review the Emacs bits of the series! Thanks, Ludo=E2=80=99.