unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: Bruno Victal <mirai@makinata.eu>, 66426@debbugs.gnu.org
Subject: [bug#66426] [PATCH 00/65] Export %default-gnu-imported-modules and %default-gnu-modules.
Date: Mon, 16 Oct 2023 11:28:25 -0400	[thread overview]
Message-ID: <87a5siy4bq.fsf@gmail.com> (raw)
In-Reply-To: <878r8a5ytu.fsf@gmail.com> (Maxim Cournoyer's message of "Tue, 10 Oct 2023 10:36:29 -0400")

Hello,

[...]

>>> People have been adding %gnu-build-system-modules to #:modules
>>> erroneously.  Not renaming that would ensure this keeps happening.
>>> Having 'imported-modules' in the name seems like it'd make things a
>>> bit easier to remember; thus, I think the proposed naming is
>>> adequate?
>> Perhaps, but I think %gnu-build-modules and %gnu-build-imported-modules
>> is better even with that reasoning.
>
> So we'd use for example %glib-or-gtk-build-imported-modules?  The
> difference is small to what I proposed (swap the leading default for an
> in-middle 'build' -- 2 characters), so I don't think your 'mouthful'
> argument holds, but I don't have much of an issue with it, except
> perhaps that 'build' is not directly attached to the module namespace,
> which is (guix build-systems gnu) for example.
>
> I still prefer my naming, but yeah, we're choosing the color of the bike
> shed :-).  If others could tip in, that may help decide, otherwise I'd
> prefer leaving it as-is.  Does that sound reasonable?

I just realized that the whole series had been sent mistakenly to
another series (seems I messed up using 'mumi send'):
<https://issues.guix.gnu.org/65924#18>.

I did spot a couple errors in that series that I've resolved locally.

If nobody has further concerns, I'll merge it later today to the
core-updates branch.

-- 
Thanks,
Maxim




  reply	other threads:[~2023-10-16 15:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1696868939.git.maxim.cournoyer@gmail.com>
2023-10-09 18:18 ` [bug#66426] [PATCH 00/65] Export %default-gnu-imported-modules and %default-gnu-modules Liliana Marie Prikler
2023-10-09 19:36   ` Maxim Cournoyer
2023-10-09 19:45     ` Liliana Marie Prikler
2023-10-10  1:31       ` Maxim Cournoyer
2023-10-10  4:14         ` Liliana Marie Prikler
2023-10-10 14:36           ` Maxim Cournoyer
2023-10-16 15:28             ` Maxim Cournoyer [this message]
2023-10-19  4:04               ` bug#66426: " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5siy4bq.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=66426@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    --cc=mirai@makinata.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).