From: "Ludovic Courtès" <ludo@gnu.org>
To: Aaron Covrig <aaron.covrig.us@ieee.org>
Cc: 65556@debbugs.gnu.org, Simon Tournier <zimon.toutoune@gmail.com>,
paren@disroot.org, Tobias Geerinckx-Rice <me@tobias.gr>,
Ricardo Wurmus <rekado@elephly.net>,
Raghav Gururajan <rg@raghavgururajan.name>,
jgart <jgart@dismail.de>, Mathieu Othacehe <othacehe@gnu.org>,
Christopher Baines <guix@cbaines.net>
Subject: [bug#65556] [PATCH] Added SiriKali
Date: Thu, 19 Oct 2023 22:07:06 +0200 [thread overview]
Message-ID: <87a5sez89h.fsf@gnu.org> (raw)
In-Reply-To: <deeb29560251c3fbefc8a895dc113e0206dc2e52.1693085004.git.aaron.covrig.us@ieee.org> (Aaron Covrig's message of "Sat, 26 Aug 2023 17:23:24 -0400")
Hi Aaron,
Sorry for the long delay!
Aaron Covrig <aaron.covrig.us@ieee.org> skribis:
> Project main page: https://mhogomchungu.github.io/sirikali/
> Project GitHub: https://github.com/mhogomchungu/sirikali
>
> Comment: SiriKali provides a user friendly GUI for managing
> encrypted folders and supports 'cloud friendly' encryption
> such as CryFS, where the encrypted contents are split across
> multiple encrypted blocks. These blocks only update as their
> respective contents are changed, allowing for easier syncing
> across network links by simplifying resumption of interrupted
> transfers and providing smaller units for differential
> transfer deltas.
The comment above should rather complement the ‘description’ field of
the package.
For the commit log, we use a peculiar convention that consists in
describing the changes in terms of files, variables, etc.:
https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html
(One of us can fix it up for you though, if needed.)
> +++ b/gnu/packages/sirikali.scm
Rather than create a new file, I’d suggest putting it in
file-systems.scm.
> + (build-system cmake-build-system)
> + (arguments
> + '(#:tests? #f ;No tests
> + #:configure-flags '("-DQT5=true" "-DCMAKE_BUILD_TYPE=RELEASE")))
You can remove “-DCMAKE_BUILD_TYPE=RELEASE” (the default is
“RelWithDebInfo”).
Could you send an updated patch?
Thanks in advance,
Ludo’.
next prev parent reply other threads:[~2023-10-19 20:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-26 21:23 [bug#65556] [PATCH] Added SiriKali Aaron Covrig via Guix-patches via
2023-10-19 20:07 ` Ludovic Courtès [this message]
2023-11-21 3:21 ` [bug#65556] [PATCH v1] gnu: Add Sirikali Aaron Covrig via Guix-patches via
2023-11-21 3:45 ` [bug#65556] [PATCH v2] " Aaron Covrig via Guix-patches via
2023-12-29 22:15 ` bug#65556: " Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5sez89h.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=65556@debbugs.gnu.org \
--cc=aaron.covrig.us@ieee.org \
--cc=guix@cbaines.net \
--cc=jgart@dismail.de \
--cc=me@tobias.gr \
--cc=othacehe@gnu.org \
--cc=paren@disroot.org \
--cc=rekado@elephly.net \
--cc=rg@raghavgururajan.name \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).