From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: rg@raghavgururajan.name, Vivien Kraus <vivien@planete-kraus.eu>,
66823@debbugs.gnu.org
Subject: [bug#66823] [PATCH gnome-team 1/4] gnu: feedbackd: Update to 0.2.1.
Date: Tue, 31 Oct 2023 09:54:41 -0400 [thread overview]
Message-ID: <87a5ryucbi.fsf@gmail.com> (raw)
In-Reply-To: <a00f5c95180d9c67cb983d8827ded2a461cd5be9.camel@gmail.com> (Liliana Marie Prikler's message of "Sun, 29 Oct 2023 18:10:34 +0100")
Hello,
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> Am Sonntag, dem 29.10.2023 um 17:32 +0100 schrieb Vivien Kraus:
>> The package now uses a “gmobile” submodule that should be included
>> as-is.
>>
>> * gnu/packages/gnome.scm (feedbackd): Update to 0.2.1.
>> [#:phases 'unpack-gmobile]: New phase.
> Should be: [#:phases]: Add ‘unpack-gmobile’. You might want to look
> into building this with an already installed gmobile; meson ought to
> support that use case.
+1, or at least...
>> Change-Id: I06521c1673efb6aea1d163410fdf3d0206b57d8a
>> ---
>> gnu/packages/gnome.scm | 21 +++++++++++++++++++--
>> 1 file changed, 19 insertions(+), 2 deletions(-)
>>
>> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
>> index a86ddc34b3..8092715795 100644
>> --- a/gnu/packages/gnome.scm
>> +++ b/gnu/packages/gnome.scm
>> @@ -12918,7 +12918,7 @@ (define-public jsonrpc-glib
>> (define-public feedbackd
>> (package
>> (name "feedbackd")
>> - (version "0.0.0+git20200527")
>> + (version "0.2.1")
>> (source (origin
>> (method git-fetch)
>> (uri (git-reference
>> @@ -12927,8 +12927,25 @@ (define-public feedbackd
>> (file-name (git-file-name name version))
>> (sha256
>> (base32
>> -
>> "1wbkzxnqjydfgjvp7vz4ghczcz740zcb1yn90cb6gb5md4n6qx2y"))))
>> +
>> "1acwpb8cgzyvzriphrb42k3d7njwcn88j66i5wz75yx2sbfaf93q"))))
>> (build-system meson-build-system)
>> + (arguments
>> + (list
>> + #:phases
>> + #~(modify-phases %standard-phases
>> + (add-after 'unpack 'unpack-gmobile
... a comment here explaining why we can't simply use gmobile as a
library (build system limitation? link to upstream issue?) is needed.
Otherwise it LGTM.
--
Maxim
next prev parent reply other threads:[~2023-10-31 13:55 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 16:44 [bug#66823] [PATCH gnome-team 0/4] Add GNOME Calls Vivien Kraus via Guix-patches via
2023-10-29 11:04 ` [bug#66823] [PATCH gnome-team 4/4] gnu: Add calls Vivien Kraus via Guix-patches via
2023-10-29 17:09 ` Liliana Marie Prikler
2023-10-31 14:21 ` Maxim Cournoyer
2023-10-29 16:32 ` [bug#66823] [PATCH gnome-team 1/4] gnu: feedbackd: Update to 0.2.1 Vivien Kraus via Guix-patches via
2023-10-29 17:10 ` Liliana Marie Prikler
2023-10-31 13:54 ` Maxim Cournoyer [this message]
2023-10-29 16:34 ` [bug#66823] [PATCH gnome-team 2/4] gnu: Add sofia-sip Vivien Kraus via Guix-patches via
2023-10-29 17:13 ` Liliana Marie Prikler
2023-10-31 14:00 ` Maxim Cournoyer
2023-10-29 16:36 ` [bug#66823] [PATCH gnome-team 3/4] gnu: Add libcallaudio Vivien Kraus via Guix-patches via
2023-10-31 14:02 ` Maxim Cournoyer
2023-10-29 20:15 ` [bug#66823] [PATCH gnome-team v2 0/6] Add GNOME Calls, slightly better Vivien Kraus via Guix-patches via
2023-10-29 11:04 ` [bug#66823] [PATCH gnome-team v2 6/6] gnu: Add calls Vivien Kraus via Guix-patches via
2023-10-31 14:43 ` Maxim Cournoyer
2023-10-29 16:32 ` [bug#66823] [PATCH gnome-team v2 2/6] gnu: feedbackd: Update to 0.2.1 Vivien Kraus via Guix-patches via
2023-10-31 14:38 ` Maxim Cournoyer
2023-10-29 16:34 ` [bug#66823] [PATCH gnome-team v2 3/6] gnu: Add sofia-sip Vivien Kraus via Guix-patches via
2023-10-29 16:36 ` [bug#66823] [PATCH gnome-team v2 4/6] gnu: Add libcallaudio Vivien Kraus via Guix-patches via
2023-10-29 18:34 ` [bug#66823] [PATCH gnome-team v2 1/6] gnu: Add gmobile Vivien Kraus via Guix-patches via
2023-10-31 14:30 ` Maxim Cournoyer
2023-10-29 19:05 ` [bug#66823] [PATCH gnome-team v2 5/6] gnu: Add libcall-ui Vivien Kraus via Guix-patches via
2023-10-31 14:40 ` Maxim Cournoyer
2023-10-31 19:36 ` [bug#66823] [PATCH gnome-team v3 0/6] Add Calls, and inform upstreams Vivien Kraus via Guix-patches via
2023-10-31 19:34 ` [bug#66823] [PATCH gnome-team v3 1/6] gnu: Add gmobile Vivien Kraus via Guix-patches via
2023-10-31 19:34 ` [bug#66823] [PATCH gnome-team v3 2/6] gnu: feedbackd: Update to 0.2.1 Vivien Kraus via Guix-patches via
2023-10-31 19:34 ` [bug#66823] [PATCH gnome-team v3 3/6] gnu: Add sofia-sip Vivien Kraus via Guix-patches via
2023-10-31 19:34 ` [bug#66823] [PATCH gnome-team v3 4/6] gnu: Add libcallaudio Vivien Kraus via Guix-patches via
2023-10-31 19:35 ` [bug#66823] [PATCH gnome-team v3 5/6] gnu: Add libcall-ui Vivien Kraus via Guix-patches via
2023-10-31 19:35 ` [bug#66823] [PATCH gnome-team v3 6/6] gnu: Add calls Vivien Kraus via Guix-patches via
2023-10-31 20:48 ` [bug#66823] [PATCH gnome-team v4 0/6] Add Calls Vivien Kraus via Guix-patches via
2023-10-31 19:34 ` [bug#66823] [PATCH gnome-team v4 1/6] gnu: Add gmobile Vivien Kraus via Guix-patches via
2023-10-31 19:34 ` [bug#66823] [PATCH gnome-team v4 2/6] gnu: feedbackd: Update to 0.2.1 Vivien Kraus via Guix-patches via
2023-11-01 3:06 ` Maxim Cournoyer
2023-11-01 11:44 ` Liliana Marie Prikler
2023-11-01 15:30 ` Vivien Kraus via Guix-patches via
2023-10-31 19:34 ` [bug#66823] [PATCH gnome-team v4 3/6] gnu: Add sofia-sip Vivien Kraus via Guix-patches via
2023-11-01 3:09 ` Maxim Cournoyer
2023-10-31 19:34 ` [bug#66823] [PATCH gnome-team v4 4/6] gnu: Add libcallaudio Vivien Kraus via Guix-patches via
2023-10-31 19:35 ` [bug#66823] [PATCH gnome-team v4 5/6] gnu: Add libcall-ui Vivien Kraus via Guix-patches via
2023-10-31 19:35 ` [bug#66823] [PATCH gnome-team v4 6/6] gnu: Add calls Vivien Kraus via Guix-patches via
2023-11-01 3:15 ` Maxim Cournoyer
2023-11-01 15:32 ` Vivien Kraus via Guix-patches via
2023-11-01 19:26 ` Maxim Cournoyer
2023-11-02 17:07 ` [bug#66823] [PATCH gnome-team v5 0/6] Waiting for Purism Vivien Kraus via Guix-patches via
2023-10-31 19:34 ` [bug#66823] [PATCH gnome-team v5 1/6] gnu: Add gmobile Vivien Kraus via Guix-patches via
2023-10-31 19:34 ` [bug#66823] [PATCH gnome-team v5 2/6] [WIP] gnu: feedbackd: Update to 0.2.1 Vivien Kraus via Guix-patches via
2023-11-02 18:08 ` Liliana Marie Prikler
2023-11-07 15:45 ` Maxim Cournoyer
2023-11-07 16:54 ` Liliana Marie Prikler
2023-10-31 19:34 ` [bug#66823] [PATCH gnome-team v5 3/6] gnu: Add sofia-sip Vivien Kraus via Guix-patches via
2023-10-31 19:34 ` [bug#66823] [PATCH gnome-team v5 4/6] gnu: Add libcallaudio Vivien Kraus via Guix-patches via
2023-10-31 19:35 ` [bug#66823] [PATCH gnome-team v5 5/6] gnu: Add libcall-ui Vivien Kraus via Guix-patches via
2023-10-31 19:35 ` [bug#66823] [PATCH gnome-team v5 6/6] gnu: Add calls Vivien Kraus via Guix-patches via
2023-11-02 18:11 ` [bug#66823] [PATCH gnome-team v5 0/6] Waiting for Purism Liliana Marie Prikler
2023-11-04 7:01 ` bug#66823: " Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5ryucbi.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=66823@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
--cc=rg@raghavgururajan.name \
--cc=vivien@planete-kraus.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).