[bug#66960] [PATCH] gnu: Add guile-algorithms

[bug#66960] [PATCH] gnu: Add guile-algorithms

[Filip Lajszczak]

Guile port of racket-algorithms

* gnu/packages/guile-xyz.scm (guile-algorithms): New variable.
---
 gnu/packages/guile-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 8f4ada7800..c408cdb71b 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -1373,6 +1373,31 @@ (define-public guile-aa-tree
 convenient nested tree operations.")
     (license license:gpl3+)))
 
+(define-public guile-algorithms
+  (package
+    (name "guile-algorithms")
+    (version "0.1")
+      (source
+        (origin
+          (method git-fetch)
+          (uri (git-reference
+                 (url "https://git@git.sr.ht/~filiplajszczak/guile-algorithms")
+                 (commit (string-append "v" version))))
+          (file-name (git-file-name name version))
+          (sha256
+            (base32
+             "0sqnica53kpxc8lmsf9aqzf3wcfjnxq4sxg0j9ka4fjh0id931qc"))))
+    (build-system gnu-build-system)
+    (native-inputs (list autoconf automake pkg-config texinfo))
+    (inputs (list guile-3.0))
+    (synopsis "Guile port of racket-algorithms")
+    (description
+     "Guile port of @url{https://docs.racket-lang.org/algorithms/index.html,
+racket-algorithms}, a package containing many useful algorithms borrowed from many
+other programming languages).")
+    (home-page "https://guile-algorithms.lajszczak.dev/")
+    (license license:gpl3+)))
+
 (define-public guile-aws
   (let ((commit "f32bea12333e1054b97ab50e58a72636edabb5b7")
         (revision "1"))
-- 
2.42.0

[bug#66960] [PATCH] gnu: Add guile-algorithms

[Mathieu Othacehe]

Hello,

> +          (sha256
> +            (base32
> +             "0sqnica53kpxc8lmsf9aqzf3wcfjnxq4sxg0j9ka4fjh0id931qc"))))

It looks like the hash is now:
0r4fgq0p8lwma4cmdjb1xy2r40wkb7rg5b0cri2cab698fmb97al.

Does it mean that the release package was updated?

> +     "Guile port of @url{https://docs.racket-lang.org/algorithms/index.html,
> +racket-algorithms}, a package containing many useful algorithms borrowed from many
> +other programming languages).")

You can remove both "many".

Thanks,

Mathieu

[bug#66960] [PATCH] gnu: Add guile-algorithms

[Filip Łajszczak]

[-- Attachment #1.1.1: Type: text/plain, Size: 974 bytes --]

On 11/25/23 18:17, Mathieu Othacehe wrote:
> 
> Hello,
> 
>> +          (sha256
>> +            (base32
>> +             "0sqnica53kpxc8lmsf9aqzf3wcfjnxq4sxg0j9ka4fjh0id931qc"))))
> 
> It looks like the hash is now:
> 0r4fgq0p8lwma4cmdjb1xy2r40wkb7rg5b0cri2cab698fmb97al.
> 
> Does it mean that the release package was updated?

It should not have been as the tag was on the same commit, but it is now 
as I moved it to include small docs change. I do not totally understand.

> 
>> +     "Guile port of @url{https://docs.racket-lang.org/algorithms/index.html,
>> +racket-algorithms}, a package containing many useful algorithms borrowed from many
>> +other programming languages).")
> 
> You can remove both "many".
> 

Yep, make sense. It was just copied from the description of the original 
racket package, but it is better less bombastic.

> Thanks,
> 
> Mathieu

Thanks for your review. Amended patch to follow.

All the best,
Filip

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3207 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

[bug#66960] [PATCH v2] gnu: Add guile-algorithms

[Filip Lajszczak]

Guile port of racket-algorithms

* gnu/packages/guile-xyz.scm (guile-algorithms): New variable.

Change-Id: I53e5b130f96ce10e52622fcdb35b9d0bbe28b108
---
 gnu/packages/guile-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 7326c1b65b..557589d2bb 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -1373,6 +1373,31 @@ (define-public guile-aa-tree
 convenient nested tree operations.")
     (license license:gpl3+)))
 
+(define-public guile-algorithms
+  (package
+    (name "guile-algorithms")
+    (version "0.1")
+      (source
+        (origin
+          (method git-fetch)
+          (uri (git-reference
+                 (url "https://git@git.sr.ht/~filiplajszczak/guile-algorithms")
+                 (commit (string-append "v" version))))
+          (file-name (git-file-name name version))
+          (sha256
+            (base32
+             "1a4ffnnhw92gqphjji5ajy3xfaqzww7xv3h8p82gkawx0rqvj5ni"))))
+    (build-system gnu-build-system)
+    (native-inputs (list autoconf automake pkg-config texinfo))
+    (inputs (list guile-3.0))
+    (synopsis "Guile port of racket-algorithms")
+    (description
+     "Guile port of @url{https://docs.racket-lang.org/algorithms/index.html,
+racket-algorithms}, a package containing useful algorithms borrowed from other
+programming languages).")
+    (home-page "https://guile-algorithms.lajszczak.dev/")
+    (license license:gpl3+)))
+
 (define-public guile-aws
   (let ((commit "f32bea12333e1054b97ab50e58a72636edabb5b7")
         (revision "1"))
-- 
2.43.0

bug#66960: [PATCH v2] gnu: Add guile-algorithms

[Mathieu Othacehe]

> * gnu/packages/guile-xyz.scm (guile-algorithms): New variable.

Applied, thanks for the v2,

Mathieu