From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:700:3204::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id KBZRIPq0k2U7bQEAkFu2QA (envelope-from ) for ; Tue, 02 Jan 2024 08:02:18 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id +EAHGvq0k2XtVAEAe85BDQ (envelope-from ) for ; Tue, 02 Jan 2024 08:02:18 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop.in header.s=key1 header.b=INLjagsN; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1704178938; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=s2DlIqSno44QxePqsPjw6pKF+41aAuCjrez+WOFVnR8=; b=lsgkZk6ljsK/4WWtGPhqjYAmtuSegfGN3MExYZ8ufBl78djDkrdlsC6gnqmEDYWfZWKUOH OdbqXw/2vH0SwRfT1HzjlvjjjWmdOvxgXAoVOdlZTZWmln2bo/3XlbTeq7L8AgQjf6WY4q NO6cwMm9F1j+VqKBxo3uxfKgpW4Xvp9Ikrl8YNtNOZ/b4gG0FbQ981OYNUr20wjO3/hth8 pbgzA5NnWb2nKPc+DjDYLv08xnuP1EEyOj1GXTiy9oGgWXwVL/NoGR21n2LhT2bmgdBYzK 4rQMjt/zvclRhgybKQDPj1dcwCob93PhsIXiywX3t3IfW3QtTRVbFWFDbfLSFQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop.in header.s=key1 header.b=INLjagsN; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1704178938; a=rsa-sha256; cv=none; b=i/2C2NRTSU+7T76/0/5vE9oIjgH4qeJCiy2Sj6Ba1RagcDUvMbKYtTXDIMeZpnHIzD1fq6 VSOANBmRWkh7YZS3gVGvJdortqPF8h8YXwe0Bn+M5dzRoQXLlpSGWUIkuNE926+AMsMzor qM0PC0v8ZjvJor1oTrCx7xOjrE+H8qNAKBZCZ106nIr0WAfqqf6dCyrwtQm4xkhpuRXXKI tL44RGWwtS+km2TSPcpOvRYSzV3F2s+qFawbcElCMCTJhYsyUDZhM8/cc2S1QVVj6CKMDU eeMS+k2hvFY+QlL7GVUd448OW4etqzJVBIEr5S8f3TxwtnQ/5yBUz21MriAlFA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3BE2D12534 for ; Tue, 2 Jan 2024 08:02:18 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rKYmo-0002ff-OG; Tue, 02 Jan 2024 02:02:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rKYmm-0002f8-LD for guix-patches@gnu.org; Tue, 02 Jan 2024 02:02:01 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rKYmm-00012R-DG for guix-patches@gnu.org; Tue, 02 Jan 2024 02:02:00 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rKYmo-0003Jt-CM for guix-patches@gnu.org; Tue, 02 Jan 2024 02:02:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68180] [PATCH 1/4] gnu: emacs: Add awk, find, sed and sh to PATH wrapper. Resent-From: Andrew Tropin Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 02 Jan 2024 07:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68180 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 68180@debbugs.gnu.org, Katherine Cox-Buday , Liliana Marie Prikler Received: via spool by 68180-submit@debbugs.gnu.org id=B68180.170417887311473 (code B ref 68180); Tue, 02 Jan 2024 07:02:02 +0000 Received: (at 68180) by debbugs.gnu.org; 2 Jan 2024 07:01:13 +0000 Received: from localhost ([127.0.0.1]:49236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rKYm1-0002yT-Dz for submit@debbugs.gnu.org; Tue, 02 Jan 2024 02:01:13 -0500 Received: from out-183.mta0.migadu.com ([91.218.175.183]:39179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rKYly-0002ql-Ls for 68180@debbugs.gnu.org; Tue, 02 Jan 2024 02:01:12 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop.in; s=key1; t=1704178865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s2DlIqSno44QxePqsPjw6pKF+41aAuCjrez+WOFVnR8=; b=INLjagsN0doJd0+Tt2ss3s07e26R9y7BwOeCzkvGmmAdHgQ7hBDeCW35qPQHeu0RudtWVy FrSBiUho0aGwPTMiS5svkQJ2ocbsN3iFCHpi5790GUzgF8Y4SXlD1o1fK2sl6QTLAsFkJ6 flOHtIC45RGRdktq5/Na5MV3XhLMCeAVkC/7bj1VG2orqhwBuyHR2Yt8SRw5xu0u4JSXJY CNQ0LMhmgqO+YELitWfRjqvJdSiJkTiu9H51XC31jZhO0cSuRBp1JabdzGZTvPinqE1Vy9 erIYrVHpb5OAaRNNHozfSstiB1hiwjB6lDS3hxio9FAX5M51QHx1o+zs7c7FsQ== In-Reply-To: <87y1d8o5cn.fsf@gmail.com> References: <6b33be06b0ea3a9aa4e29b8c8a958150cc05a7e9.camel@gmail.com> <874jfyoz84.fsf@gmail.com> <87plyl4ie1.fsf@trop.in> <87y1d8o5cn.fsf@gmail.com> Date: Tue, 02 Jan 2024 10:00:58 +0300 Message-ID: <87a5pofcd1.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Andrew Tropin X-ACL-Warn: , Andrew Tropin via Guix-patches From: Andrew Tropin via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -8.85 X-Spam-Score: -8.85 X-Migadu-Queue-Id: 3BE2D12534 X-TUID: kgbgbiACjbiP --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-01-01 21:07, Maxim Cournoyer wrote: > Hi Andrew, > > Andrew Tropin writes: > > [...] > >>>> We already have a phase to patch in the real path of /bin/sh where it's >>>> used. This appears to be an odd case that's missed. >>> >>> I appreciate exactness, but it seems fragile to rely on nobody adding >>> new references or someone catching them as new Emacs modules get added >>> or changed :-). >>> >>> My reasoning was that since Emacs already depends on bash, why not >>> ensure it'll always be found on PATH, by wrapping instead of >>> substituting. >>> >>> Does it make sense? >> >> Yep, make sense to me. I also find cases from time to time, when some >> binary or another isn't found by some elisp code. >> >> However, providing those binaries via PATH can make some code or >> programs to work, when executed from inside Emacs and not to work in the >> environment outside, which can be really confusing in some cases. >> >> A simple example, imaging we have a script: 1.sh, which contains: >> sh --version >> >> This one will work: >> guix shell emacs-with-bash --pure -- emacs --eval '(shell-command "./1.s= h")' >> >> This one will not: >> guix shell emacs-with-bash --pure -- ./1.sh >> >> That said, the idea of patching all the pathes to binaries seems better >> to me. > > I'm not sure if I got you correctly: do you prefer to wrap Emacs with > the tools it needs in PATH, or patch the references exactly in its > source, as Liliana suggested? I'm more on the "patching the references exactly" side to avoid the problem mentioned above. > > I've tried the "exact" patch suggested by Liliana in v2. I tested that > reading a manual page was possible in a containerized environment still > worked. =F0=9F=91=8D =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmWTtKsACgkQIgjSCVjB 3rCRDQ//Yn37XX7Emuy/e7ngsBOPugyBL8ocIkb8v2gArbswOud8vr2Z524fsf0r qlHdogpqrrMDsRmHBFdRLWjxYFIB15Co4W3Z1VYxS8NvEdA365bREW+ucIE9DGVI PEgo5e9vVpdK1SiNPJf+bPLYpxejT++O7P3yF6EFJ34+sBBh5dopWYdC+Tu3xkm4 V/vUkHqbpl4XGBh3IF/+ZkCgeSpOnXEk6cZ9PaJLx+YdC3wx1oe8e0PAmxqleQPd lxlJBXQofa+VHFseUn7S3+s2rCFp4ATylyzJPrwZvA8t8wcw8eU9a2Ob3wRoh64b BI0xFj7ORxFoXoHIedLCdVzRoftoKMUDPOyRXEpYzrpO3IDCofHq3P1GOYhao49f 1YZNxBKIuVSaYdZNNFkZ2xa2qJgjZXTwI7HF8HCzcTGoxMF4WPG6tPTyvcTZnTVY 6qrf5bwxztaCPr52OzFNC/eMzKWP+1vbymk9jTxs05UwJnTfS8v7ZWEd7pL0wRT5 exwGP1Y6xmI8WpLbwEFpvUaFPP8ygb38RiDtjdeTemQ3PfIr4PFX7b/Ug+UTRzOs 68+T5BYcvujWJFaK0zmdWIgC7JAqXphNO7opsedAjTsXehd78XQU3ht/yXBLHI1/ y35Ouadfkv2IpkkL1B9nX0us7j/YFQlmpIAC7jBB19PmDpRBDXM= =X7q4 -----END PGP SIGNATURE----- --=-=-=--