* [bug#68642] [PATCH] gnu: Add python-pandas-vet.
@ 2024-01-21 17:22 Troy Figiel
2024-02-05 19:11 ` Sharlatan Hellseher
2024-02-11 21:06 ` bug#68642: " Sharlatan Hellseher
0 siblings, 2 replies; 4+ messages in thread
From: Troy Figiel @ 2024-01-21 17:22 UTC (permalink / raw)
To: 68642
* gnu/packages/python-xyz.scm (python-pandas-vet): New variable.
---
gnu/packages/python-xyz.scm | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index b23108fbf4..dfd786e283 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -13876,6 +13876,31 @@ (define-public python-flake8-isort
directives.")
(license license:gpl2+)))
+(define-public python-pandas-vet
+ (package
+ (name "python-pandas-vet")
+ ;; Newer versions require flake8>=6.0.0.
+ (version "0.2.3")
+ (source
+ (origin
+ ;; No tests in the PyPI tarball.
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/deppen8/pandas-vet")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "1b3pqcargv68p2lpv72q49siq6mxfh3znxhz9vd91rp6fd6lf2cz"))))
+ (build-system pyproject-build-system)
+ (propagated-inputs (list python-attrs python-flake8))
+ (native-inputs (list python-pytest))
+ (home-page "https://github.com/deppen8/pandas-vet")
+ (synopsis "Opionated @code{flake8} plugin for @code{pandas} code")
+ (description
+ "This package provides a @code{flake8} plugin to lint @code{pandas} code
+in an opinionated way.")
+ (license license:expat)))
+
(define-public python-autoflake
(package
(name "python-autoflake")
base-commit: 121de47decc1029c06f6e46e5f06d7fefe8e85ec
--
2.42.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#68642] [PATCH] gnu: Add python-pandas-vet.
2024-01-21 17:22 [bug#68642] [PATCH] gnu: Add python-pandas-vet Troy Figiel
@ 2024-02-05 19:11 ` Sharlatan Hellseher
2024-02-05 21:12 ` Troy Figiel
2024-02-11 21:06 ` bug#68642: " Sharlatan Hellseher
1 sibling, 1 reply; 4+ messages in thread
From: Sharlatan Hellseher @ 2024-02-05 19:11 UTC (permalink / raw)
To: 68642
[-- Attachment #1: Type: text/plain, Size: 212 bytes --]
Hi,
Thank you for the patch!
I started reviewing it, it looks good. I've got question on placement:
- python-science next to pandas
or
- python-check as it is related to lint
What do you think?
Regards,
Oleg
[-- Attachment #2: Type: text/html, Size: 561 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#68642] [PATCH] gnu: Add python-pandas-vet.
2024-02-05 19:11 ` Sharlatan Hellseher
@ 2024-02-05 21:12 ` Troy Figiel
0 siblings, 0 replies; 4+ messages in thread
From: Troy Figiel @ 2024-02-05 21:12 UTC (permalink / raw)
To: 68642
Hi Oleg,
Originally I put it under python-xyz, because it is a flake8 plugin and
most if not all flake8 plugins are defined in python-xyz.
It does indeed make more sense to have all flake8-related packages in
python-check instead, since it is a linting library. python-pylint is
defined under python-check for example.
For that reason, I would also advise against putting python-pandas-vet
in python-science. I leave the final placement up to you though :-)
Best wishes,
Troy
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#68642: [PATCH] gnu: Add python-pandas-vet.
2024-01-21 17:22 [bug#68642] [PATCH] gnu: Add python-pandas-vet Troy Figiel
2024-02-05 19:11 ` Sharlatan Hellseher
@ 2024-02-11 21:06 ` Sharlatan Hellseher
1 sibling, 0 replies; 4+ messages in thread
From: Sharlatan Hellseher @ 2024-02-11 21:06 UTC (permalink / raw)
To: 68642-done
[-- Attachment #1: Type: text/plain, Size: 140 bytes --]
Hi,
I've added the package to python-check based on it's purpose.
Pushed as 579a1a8c029e97b69a7e3597ff9fd287805cf644 to master.
--
Oleg
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-11 21:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-21 17:22 [bug#68642] [PATCH] gnu: Add python-pandas-vet Troy Figiel
2024-02-05 19:11 ` Sharlatan Hellseher
2024-02-05 21:12 ` Troy Figiel
2024-02-11 21:06 ` bug#68642: " Sharlatan Hellseher
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).