unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: Christopher Baines <mail@cbaines.net>
Subject: [bug#70293] [PATCH] gnu: diffoscope: Update to 263.
Date: Tue, 09 Apr 2024 11:32:58 -0700	[thread overview]
Message-ID: <87a5m24c9x.fsf@wireframe> (raw)
In-Reply-To: <87il0qbegl.fsf@cbaines.net>

[-- Attachment #1: Type: text/plain, Size: 2365 bytes --]

On 2024-04-09, Christopher Baines wrote:
> Vagrant Cascadian <vagrant@reproducible-builds.org> writes:
>
>> On 2024-04-09, Vagrant Cascadian wrote:
>>> On 2024-04-09, Wilko Meyer wrote:
>>>> * gnu/packages/diffoscope.scm (diffoscope): Update to 263.
>>>
>>> Thanks for the update!
>>>
>>> Not a *huge* deal, but this version should have perl added to native
>>> inputs, as some tests now use "zipdetails" from perl, and are skipped if
>>> it is not present. Or does something else pull in perl?
>>
>> For a build without perl, the test coverage is:
>>
>>   638 passed, 72 skipped
>>
>> With perl added to native-inputs:
>>
>>   644 passed, 66 skipped
>>
>> That seems like a nice improvement. :)

Or at least, not a regression from diffoscope 261:

  https://ci.guix.gnu.org/build/3903616/log/raw

  644 passed, 66 skipped

:)

> Cool, I think it would be useful if we could get the test suite to log
> more as well, since 66 is still quite a few tests.

You mean log why something was skipped? Yeah, that would be
nice... maybe cranking up the verbosity on the tests suites would help,
if it doesn't generate too much noise.


For the most part there are a few things not yet packaged for guix. I
sometimes use this to hunt for additional things in need of packaging:

  guix shell --pure diffoscope $(guix shell --pure diffoscope  -- diffoscope --list-missing | awk -F packages: '/Guix/{print $2}' | tr -d , | tr ' ' '\n' | sed -e '/^$/d') python-argcomplete python-androguard python-defusedxml python-jsondiff  -- diffoscope --list-missing

Which currently outputs:

  Available-in-Arch Linux-packages: mono
  Available-in-Debian-packages: aapt, apksigcopier, apksigner, apktool, coreboot-utils, dexdump, fontforge-extras, mono-utils, oggvideotools, perl, procyon-decompiler, xmlbeans
  Available-in-FreeBSD-packages: mono
  Available-in-GNU Guix-packages:
  External-Tools-Required: aapt2, apksigcopier, apksigner, apktool, cbfstool, dexdump, dumpxsb, lipo, oggDump, otool, pedump, procyon, showttf, zipdetails
  Missing-Python-Modules: guestfs, r2pipe


Notably, I just added the mapping to get zipdetails for guix:

  https://salsa.debian.org/reproducible-builds/diffoscope/-/commit/90dd18830d9330c8fb8f87dd2ca50972574b6926

In the past I have sometimes temporarily monkey-patched such updates
until it lands in a new upstream version.


live well,
  vagrant

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2024-04-10 20:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-08 22:27 [bug#70293] [PATCH] gnu: diffoscope: Update to 263 Wilko Meyer
2024-04-09 16:36 ` Vagrant Cascadian
2024-04-09 17:40   ` Vagrant Cascadian
2024-04-09 18:03     ` Christopher Baines
2024-04-09 18:32       ` Vagrant Cascadian [this message]
2024-04-10 20:50         ` Vagrant Cascadian
2024-04-09 17:49 ` bug#70293: " Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5m24c9x.fsf@wireframe \
    --to=vagrant@reproducible-builds.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).