From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id yNNvKx03JGYHZQAAe85BDQ:P1 (envelope-from ) for ; Sat, 20 Apr 2024 23:43:57 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id yNNvKx03JGYHZQAAe85BDQ (envelope-from ) for ; Sat, 20 Apr 2024 23:43:57 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Z2IRCsdM; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1713649437; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=PBntfCOxrJIHuuOCe3/uk1k0ExSIt9o8BQbJyRz/g+Q=; b=HvJFSVAgU7PSa48A412as4sTg2Ti0hoRELRtpCALAQPXrRvadXClwLT8XY3CBI8Qh+2Lbn AaIVx6nzNtfak7OrgHuKCyDX3JNRp1Jv4wC6l4Rs5dKJlwqjIYCN+drQqKDOnNE1TdZXlo ej40AbXBiZlVlJKJO4lWqX/fAMa8YNw1W/H2mr7+dg0JxFjHb5ZtZqHRzVTNlK6FId2AgI kiT/SXrO9i75+DAKAF8C27ef6oSGD++4XHJlHs7K8ztyw6r6va+RjUJ1G5wzniXU0S4xdW MtsTHUrtro4vb3lkAVmEM2vPjoX0A17jFZV/cPIwKtNsCqr9fHh6RrskP3Accg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Z2IRCsdM; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1713649437; a=rsa-sha256; cv=none; b=ta6QoaXgDsEX0pNrSij32xHPeC0GaQN25NUc1nI/BS/Q1fm0F+idcR2Txye/MnZHB9GZge sQL40UTnze+IVGxnSqJHbFmO2kWaf2cVicUTPSWOtgW+A7lQEjiymgZk/axACBFveGV6Au vLzOuf7Qm4sYjCB6Ui2Rd9yXV0NgZIOLyan/5H/CkLKwUzXWcxDGcspDjEh6AaduzqpEl6 ED4KvanWn7r/R0jSFfhc+9MMybMgdmIvFM3DchnhP1E3MuHjNScAEWMLDM+Hth1eA9aMWZ 9dacN3K5QgmJ2gHZ3nT6yf/IysP2lD82BiOvhTkaSO40PWiVRe+CelKI1uJg5Q== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9107C7098F for ; Sat, 20 Apr 2024 23:43:57 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ryIUy-0002Os-7G; Sat, 20 Apr 2024 17:43:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ryIUv-0002OY-TN for guix-patches@gnu.org; Sat, 20 Apr 2024 17:43:49 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ryIUv-0001jw-JS for guix-patches@gnu.org; Sat, 20 Apr 2024 17:43:49 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ryIVA-0004lB-7y for guix-patches@gnu.org; Sat, 20 Apr 2024 17:44:04 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70446] [PATCH v4] gnu: webkitgtk: Add access to system locale path and to paths from GUIX_LOCPATH, LOCPATH, and LIBVA_DRIVERS_PATH to gtk sandbox in order to silence gtk locale warnings and enable hardware accelerated video. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 20 Apr 2024 21:44:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70446 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Abhishek Cherath Cc: Vivien Kraus , Liliana Marie Prikler , 70446@debbugs.gnu.org Received: via spool by 70446-submit@debbugs.gnu.org id=B70446.171364940017935 (code B ref 70446); Sat, 20 Apr 2024 21:44:04 +0000 Received: (at 70446) by debbugs.gnu.org; 20 Apr 2024 21:43:20 +0000 Received: from localhost ([127.0.0.1]:38353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryIUQ-0004f3-S1 for submit@debbugs.gnu.org; Sat, 20 Apr 2024 17:43:19 -0400 Received: from mail-qt1-x829.google.com ([2607:f8b0:4864:20::829]:42116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryIUO-0004dm-Ff for 70446@debbugs.gnu.org; Sat, 20 Apr 2024 17:43:16 -0400 Received: by mail-qt1-x829.google.com with SMTP id d75a77b69052e-436f1a770bdso29033681cf.0 for <70446@debbugs.gnu.org>; Sat, 20 Apr 2024 14:43:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713649376; x=1714254176; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PBntfCOxrJIHuuOCe3/uk1k0ExSIt9o8BQbJyRz/g+Q=; b=Z2IRCsdM17EWt7WQLs58GJCAVNrFLPfv5lkTqMgvklnYXiUja8xzOWPr5CS/zHnd+i d/RlfZJ0gBgM+dQ04+inGDWSUnJJ1fNrhxHuyPFVENGYw06OgrYzdBjkAlCOwylMz7zQ cGGBS79fy7RXXiOc0WZIr1eBJ1sAwCBGK1iFm/XPWGeSmIiebSHdSg/VbVkAALMk6e7C ZSuRU/lDwTKkCLegB8Ant4gplKOcJtiA0ktX9ABLPkmfEgxacaw2RIUupbApWjbMKvhX Lek6RFFX502uLLmH7bzP5oHoOz59i/CJup60DsHGrcUsJXfBTrSFiBJzRIRNc3PF11vA mvYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713649376; x=1714254176; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PBntfCOxrJIHuuOCe3/uk1k0ExSIt9o8BQbJyRz/g+Q=; b=bVM7IiwPomtUKtYmf3cnBDl6cuWZ8gQyc1nNPPtpnS/mRbC3nDl4oCX2Ko2/hNYwgK YVKCCGURpvvA5P1F7QM77RFH0DA3a+NlqLJZ+hoFcpUNyFBimE1JubFAj4fQBImixDwi LNLq29IDWNADyL4NJy6ZKkJ8QA+w6zooWTnXtzPMhzukCZbja7AxuwsFDAFL1NqOUHH4 vZyJT2ItOfnea/cwdWLKI3j1SWWopb4Xr6TjM/Xry2bkTxBgsofjtNfTDJiYfJXkio87 2+HdtyglNz+3AHUYkV8juHoMn7E9O/EG9MWUFHLcoWSRXdX56mSPJ8WMF6qRSv4ZD3q+ 1CdA== X-Forwarded-Encrypted: i=1; AJvYcCVMl8KZEDdAIju6GHKaGonsFbl5nbLLlRP74/v8jQTcoWLXZTfH7CpWLeii4UIy3BFg3BgLJ1W0uRSI4SfMsdOWGufyE0Y= X-Gm-Message-State: AOJu0YyoWwkyU4mQElKfWkHE60ap0WFXhVS8zt9dCKENxk/SW4U2IDLs bVfDShbKQLVpCpIf4EJaLTmk8xo/WdD6sE4LAhmbTh2hnyjwHgS9LRIDiA== X-Google-Smtp-Source: AGHT+IHWOKrxhH52P3J26LDAkhKNSKYL2AaXD7JTTagHwBw7oY8mxEn0YbhU/twADJ2W31U3kkmPcw== X-Received: by 2002:a05:622a:13d2:b0:435:9c32:ae57 with SMTP id p18-20020a05622a13d200b004359c32ae57mr10553465qtk.26.1713649375789; Sat, 20 Apr 2024 14:42:55 -0700 (PDT) Received: from hurd (dsl-10-134-76.b2b2c.ca. [72.10.134.76]) by smtp.gmail.com with ESMTPSA id k3-20020ac81403000000b00434b1f4e371sm2816771qtj.13.2024.04.20.14.42.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Apr 2024 14:42:55 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <87frvg6og1.fsf@quic.us> (Abhishek Cherath's message of "Sat, 20 Apr 2024 11:31:10 -0400") References: <34830675a6123b15bd652b2aae0922ff95d15f54.1713408724.git.abhi@quic.us> <337ee6c76e8326b875045f6c8bf54304ff017311.1713620642.git.abhi@quic.us> <1786c04febdba0477a2ec6270854a4ce7e4303f0.camel@gmail.com> <87frvg6og1.fsf@quic.us> Date: Sat, 20 Apr 2024 17:42:54 -0400 Message-ID: <87a5lniuch.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -2.06 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -2.06 X-Migadu-Queue-Id: 9107C7098F X-TUID: VrgQsC/jzzRD Hi, Abhishek Cherath writes: > Hello, > >>> Thanks [liliana.prikler@gmail.com]=C2=A0for all the help :D, I thought >>> about this a bit more and looked at all the utility stuff in >>> BubblewrapLauncher.cpp. I realized that the correct thing to do here >>> is to simply mount the LIBVA_DRIVERS_PATH paths. I'm wondering if >>> this shouldn't be part of the gstreamer default mounts even upstream? >>> along with the LOCPATH mount. >> This patch LGTM. I think submitting it upstream sans GUIX_LOCPATH >> would be a great idea =E2=80=93 that way, we'd have fewer things to patc= h. > > Sweet! I'll get on that sometime next month. > >> Is @localedir@ still needed with the bindPathVar in place? Otherwise, >> as already said, LGTM, and I'll look into forwarding it to/cherry- >> picking it from gnome-team once I got new Webkit over there (still need >> to wait for CI on that). > > Yes, it's still needed since Guix system doesn't generally set LOCPATH > (or GUIX_LOCPATH.) > > Thanks again for the review and suggestions! I just finished catching up with the thread. Great to see the review back and forth converging to an increasingly fancier solution :-). --=20 Thanks, Maxim