From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id +KSqA2jsPGYxLQEAqHPOHw:P1 (envelope-from ) for ; Thu, 09 May 2024 17:31:52 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id +KSqA2jsPGYxLQEAqHPOHw (envelope-from ) for ; Thu, 09 May 2024 17:31:52 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=LPbrj6OT; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715268711; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=gXKxEaJ2ZGfAEZv0J8qNfF0AvT3otpa9/TeoLBGkGnY=; b=gQIQcopA/I0FlZkGvvV0xtgQwFeEotaC9KYY3TssSAi6/RPJsrdXyRmbWciR30tDGWMl9Q uc1N/+zEhyLfiFBx/1vbMXCBbWC7avRDQFF09FDBkvxQjs/OrZTC+IqHgVoc0De/q3NzNY 1qDG/qyrdk6pu0Q7MPY8iDfURhRXNTD1HOS7Xxak4SVHR5HrAuL7u06h5GzyYKEtPU/NnM ETeK1kkEZseOrm+/xF5kbANsfCtoSy1FWOxtVDEprvdEazThMpK39i6A0LIhCQ4B8VD6Ve bNC6D5oc+SZ+8zepHSMyoT31P1LiFKn34BJyi6VQtjP+QRGCvDvz1jxRZTGVaQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715268711; a=rsa-sha256; cv=none; b=fpBJz9i20v/Jx4WFb/2LEOrNEpHuH63OwKvAASgASifROwORLdpND+nAYCT0Er7VToryNB YCRStg6W6LwPpimALzl8aLdkHKG0yu3w6dAZQY2Ei1mmK+JyEP9tctuioQ7LishtZa68Aq vq4b9+40FKhxyb3pTJ86QLe3B1NYJ9PbuRLvi07+HfzMRXiAuN6bfMmUBgEEw+LXbTm8sN PlW3gik60SpszQcp3S4Qz8ygZ3onU/RdCBAw44OKzO3qunXcDvaVkJAFQd+NBBHMvSTHT6 yaPx5N51i1s/vyu5IUO8oanS8heuAj1NovDpMK7xzg9EP7gcG3agXp9CDbPj3A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=LPbrj6OT; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B7737864D for ; Thu, 09 May 2024 17:31:51 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s55jh-0002jq-Nc; Thu, 09 May 2024 11:31:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s55jP-0002hB-VJ for guix-patches@gnu.org; Thu, 09 May 2024 11:30:57 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s55jA-0007sv-BV for guix-patches@gnu.org; Thu, 09 May 2024 11:30:47 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s55jZ-0004QT-Sw for guix-patches@gnu.org; Thu, 09 May 2024 11:31:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70282] [PATCH v4] gnu: gnome-shell: Wrap screencast service. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 09 May 2024 15:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70282 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Dariqq Cc: 70282@debbugs.gnu.org, Vivien Kraus , Liliana Marie Prikler Received: via spool by 70282-submit@debbugs.gnu.org id=B70282.171526865917007 (code B ref 70282); Thu, 09 May 2024 15:31:01 +0000 Received: (at 70282) by debbugs.gnu.org; 9 May 2024 15:30:59 +0000 Received: from localhost ([127.0.0.1]:55908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s55jW-0004QF-R8 for submit@debbugs.gnu.org; Thu, 09 May 2024 11:30:59 -0400 Received: from mail-qt1-x82a.google.com ([2607:f8b0:4864:20::82a]:50219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s55jT-0004Q7-7z for 70282@debbugs.gnu.org; Thu, 09 May 2024 11:30:57 -0400 Received: by mail-qt1-x82a.google.com with SMTP id d75a77b69052e-43ddbdf2439so6628121cf.0 for <70282@debbugs.gnu.org>; Thu, 09 May 2024 08:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715268623; x=1715873423; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=gXKxEaJ2ZGfAEZv0J8qNfF0AvT3otpa9/TeoLBGkGnY=; b=LPbrj6OTs6ydbnf398HmaFAgCjTWy6SEtMVNO6mXTUDDLVQzeU088WAi1dVH/srF/P 68WWMpnAEZbBtz3IIzxAlYgvyZLpgWRhk/FtOMkAx2AZFRXIBGiATvrT697EX6jkFPnF svCPxX4djYtK+uL+jWmsgj0nQxOIoUP650qkXCPt9ZJvzpVKVVivPAwKzUbop3D6vhma wFis/RTXTiytuxqzidZRtGeaWSFbMkJoTQ5SzoC2VG7cHTk96ZEogQGRDp+BcNb0wfEt X6BMpeJwFzt2CRn54O6cM7MtKdh8B24ZMwF9jEQFzfAvYYQBJ0cfjW+OGjK0EYOe7waN mJLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715268623; x=1715873423; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gXKxEaJ2ZGfAEZv0J8qNfF0AvT3otpa9/TeoLBGkGnY=; b=T2z879VsfKbsS1PI3GqdfLaBEldNnttE87a8/BW/n1DrygnLJ5eIOY25AzfxCMBozB dME9cd+CYbUzBfUPVcTv4AOU35T4ulQhr/RVqZ+mtFqV3TILVxCvlkoMz3Mnn8Xq0mdf OuivoFVaV+njnaFGfT6uHIGwmlZ9UQgWaXYWj0P/xQBV9blrvDMup8j30yQgk4po2vzB FN4GI/rs095m7OlBCQ26s9w1zj8/pMrPVShYR6jr2oVzs55UdzlpHuWxRVSb/Qlm6S7M JOvkUZMDUOm0TYyw+7vbZ/L+ykJNVb0JpAngMqgUpDPHmH/PDRuzph25ILB/3h3/LGYZ Lz4w== X-Gm-Message-State: AOJu0YzRfTenASuBvoZfoIzdV9R8XqTd9KVkOByoGXM7tJqVy4Bt29OX G0pHtS2NMWOLlKg4oRyUhtaYofIduTcN5AdqupjcwaYCWUhb7dSd X-Google-Smtp-Source: AGHT+IG4GP2qwJTuAAIOS/2ZqQtX7LCxmZZKLSle/njDC8rfYGjj0eBZ9+A1gybmFvB99ubnd77imQ== X-Received: by 2002:a05:622a:1:b0:439:8741:5208 with SMTP id d75a77b69052e-43dbf50f7femr66986811cf.23.1715268623440; Thu, 09 May 2024 08:30:23 -0700 (PDT) Received: from hurd (dsl-152-95.b2b2c.ca. [66.158.152.95]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-43df5da15f4sm8667201cf.68.2024.05.09.08.30.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 May 2024 08:30:23 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <9e607cae-97fc-4b6d-85bc-dccf58ee1f08@posteo.net> (dariqq@posteo.net's message of "Wed, 8 May 2024 21:18:04 +0000") References: <213d475bd6ad3781baf3876e89bd84c18029dc5e.1715193210.git.dariqq@posteo.net> <87cypw6q0x.fsf@gmail.com> <9e607cae-97fc-4b6d-85bc-dccf58ee1f08@posteo.net> Date: Thu, 09 May 2024 11:30:21 -0400 Message-ID: <87a5kz2eb6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -0.79 X-Spam-Score: -0.79 X-Migadu-Queue-Id: B7737864D X-Migadu-Scanner: mx11.migadu.com X-TUID: DA5EpLiAoooj Hi Dariqq, Dariqq writes: [...] >>> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm >>> index 92e35e3c5a..4bbff2a89b 100644 >>> --- a/gnu/packages/gnome.scm >>> +++ b/gnu/packages/gnome.scm >>> @@ -9408,6 +9408,7 @@ (define-public gnome-shell >>> (add-after 'install 'wrap-programs >>> (lambda* (#:key inputs #:allow-other-keys) >>> (let ((gi-typelib-path (getenv "GI_TYPELIB_PATH")) >>> + (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")) >>> (python-path >>> (string-join >>> (filter (lambda (item) >>> @@ -9427,6 +9428,19 @@ (define-public gnome-shell >>> "path => imports.gi.GIRepository.Repository." >>> "prepend_search_path(path));\n" >>> all))) >>> + ;; Screencast requires a pipewire service running >>> + ;; (i.e. as provided by home-pipewire-service-type) >>> + (substitute* (string-append #$output "/share/gnome-shell/" >>> + "org.gnome.Shell.Screencast") >>> + (("imports\\.package\\.start" all) >>> + (string-append "'" gi-typelib-path "'.split(':').forEach(" >>> + "path => imports.gi.GIRepository.Repository." >>> + "prepend_search_path(path));\n" >>> + "imports.gi.GLib.setenv('GST_PLUGIN_SYSTEM_PATH'," >>> + "[imports.gi.GLib.getenv('GST_PLUGIN_SYSTEM_PATH')," >>> + "'" gst-plugin-path "'].filter(v => v).join(':')," >>> + "true);\n" >>> + all))) >> Perhaps a simple patch would convey the change better and be easier >> to >> maintain in the future / be readily available for other distributions to >> use. > > > The simple patch that would do this is basically the patch from nixos > in v1 of this which adds a shebang line for gjs to the service > invocation files (rather than the dbus service invoking $gjs > $service). The problem then is that wrap-program changes the filename > to * .real which makes gjs unhappy. > > The people from nix circumvent this by using some js at the beginning > to reset the entrypoint to the correct value. > > One nice way around avoiding the problem would be using wrap-script > instead though that does not support gjs as interpreter (yet?) and > adding that forces a rebuild of all packages due to (guix build utils) > changing. It'd be nice to prep such support on core-updates. You can test it on master by having a (guix build utils-next) module that you explicitly use. > Maybe another comment, similiar to the one Liliana suggested earlier > in this thread, could be added at the beginning to inform about > changing to wrap script + patch instead once that is a viable option? That could be a good reminder to have, yes. -- Thanks, Maxim