From: Simon Tournier <zimon.toutoune@gmail.com>
To: Christopher Baines <mail@cbaines.net>, 71038@debbugs.gnu.org
Cc: "Josselin Poiret" <dev@jpoiret.xyz>,
"Mathieu Othacehe" <othacehe@gnu.org>,
"Ludovic Courtès" <ludo@gnu.org>,
"Tobias Geerinckx-Rice" <me@tobias.gr>,
"Ricardo Wurmus" <rekado@elephly.net>,
"Christopher Baines" <guix@cbaines.net>
Subject: [bug#71038] [PATCH 1/2] guix: store: Enable specifying the available builtin builders.
Date: Wed, 22 May 2024 12:58:12 +0200 [thread overview]
Message-ID: <87a5ki3ygr.fsf@gmail.com> (raw)
In-Reply-To: <6b9c634c024b6fd7a50d3b82edc244676a8ca8e8.1716038375.git.mail@cbaines.net>
Hi Chris,
On sam., 18 mai 2024 at 14:19, Christopher Baines <mail@cbaines.net> wrote:
> diff --git a/guix/store.scm b/guix/store.scm
> index 58ddaa8d15..0c734cdca7 100644
> --- a/guix/store.scm
> +++ b/guix/store.scm
> @@ -571,7 +571,7 @@ (define* (connect-to-daemon uri #:key non-blocking?)
>
> (define* (open-connection #:optional (uri (%daemon-socket-uri))
> #:key port (reserve-space? #t) cpu-affinity
> - non-blocking?)
> + non-blocking? assume-available-builtin-builders)
Why add the variable %assume-available-builtin-builders and default to
it?
Something like:
--8<---------------cut here---------------start------------->8---
(define %assume-available-builtin-builders
"List of builtin builders supported by the builder Guix daemon."
(list "download" "git-download"))
(define* (open-connection #:optional (uri (%daemon-socket-uri))
#:key port (reserve-space? #t) cpu-affinity
non-blocking?)
non-blocking?
(assume-available-builtin-builders %assume-available-builtin-builders))
--8<---------------cut here---------------end--------------->8---
And then default to this %assume-available-builtin-builders elsewhere in
[PATCH 2/2]. IMHO, it changes almost nothing but it would help to know
(document) what to pass as argument.
Cheers,
simon
next prev parent reply other threads:[~2024-05-22 15:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-18 13:11 [bug#71038] [PATCH 0/2] Enable specifying the available builtin builders Christopher Baines
2024-05-18 13:19 ` [bug#71038] [PATCH 1/2] guix: store: " Christopher Baines
2024-05-18 13:19 ` [bug#71038] [PATCH 2/2] guix: channels: Enable specifiying " Christopher Baines
2024-05-22 10:58 ` Simon Tournier [this message]
2024-05-26 8:10 ` [bug#71038] [PATCH 1/2] guix: store: Enable specifying the " Christopher Baines
2024-05-27 17:19 ` Simon Tournier
2024-06-11 19:26 ` Christopher Baines
2024-06-24 13:43 ` [bug#71038] [PATCH v2 " Christopher Baines
2024-06-24 13:43 ` [bug#71038] [PATCH v2 2/2] guix: channels: Enable specifiying " Christopher Baines
2024-07-04 9:17 ` Ludovic Courtès
2024-07-04 9:14 ` [bug#71038] [PATCH v2 1/2] guix: store: Enable specifying the " Ludovic Courtès via Guix-patches
2024-07-04 11:50 ` [bug#71038] [PATCH v3 1/2] guix: store: Enable specifying the " Christopher Baines
2024-07-04 11:50 ` [bug#71038] [PATCH v3 2/2] guix: channels: Enable specifiying available " Christopher Baines
2024-07-16 10:05 ` Ludovic Courtès
2024-07-16 13:13 ` Christopher Baines
2024-07-16 12:48 ` [bug#71038] [PATCH v4 1/3] guix: store: Enable specifying the " Christopher Baines
2024-07-16 12:48 ` [bug#71038] [PATCH v4 2/3] guix: channels: Enable specifiying available " Christopher Baines
2024-07-16 12:48 ` [bug#71038] [PATCH v4 3/3] inferior: Use the host built-in-builders with inferior Christopher Baines
2024-07-18 9:35 ` Ludovic Courtès
2024-07-18 13:08 ` bug#71038: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5ki3ygr.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=71038@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=guix@cbaines.net \
--cc=ludo@gnu.org \
--cc=mail@cbaines.net \
--cc=me@tobias.gr \
--cc=othacehe@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).