From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id 6CXtHerwUWaBFwAAA41jLg (envelope-from ) for ; Sat, 25 May 2024 16:08:42 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id AAUHF+rwUWZXggEA62LTzQ (envelope-from ) for ; Sat, 25 May 2024 16:08:42 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=kg8RDQC8; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1716646122; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=aXlwuPZl6ZGtegVHTKsotbis+7PTHa+Kou3ZgU5y3cg=; b=tnbKUS3nVVprnraeERyKPXwU5DL3DmEPH2IFAPiVdbklhoNs3nqpx0gGDr/QOUB1ZsuEJQ lKoWTvGPt0cBmPF4mLWbU5gH9rtKXYAGX4NGWr9/KE6s/MBkWNIj0nvlA35kSF9T4iv24e Spu6fSBo/uYQFgrYtpQIbRRgvOHfvtvLNVRrZpxIBUau++tal7Gs823HRwr+XO339B2FT7 2hmr1oWTIF7Sa07AcsySHjuEMmX4dlR+7IO1s1YhYwQEPgxJnNvr/rNNl8h2pXqxcyLpV4 MDFcqR1yLRAnn8gNwhPcsGumKlH2RyXye0tbgU+5GS4bB0zeNTFPreaeGOYAUw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=kg8RDQC8; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1716646122; a=rsa-sha256; cv=none; b=TgLFbTnkbItQB1WjTjoQDs6JNANxTY6WVEFbunBNN80PF40Xs0qaRzPpAGZ0YfrHIdd18o CPxcuXLHkL1uBTLNI85ki6030w7BsMw0cpMlzW4RTXnvvqygZEkNu0v1unWCWAIdZpCDxL mTX4epB2SHKls2LD2oybCHlE7TsYLgYwmhPyDkfRb2Q+wQxOJ0bI/nrA6jiilFd6n6LsMD wIV88yarLo8RB6kzUkO+helA7BQkPxuggg5J5Y1qm59deJOt5IAwhFCgXmVKdUlujaOlFZ wG6XwF1L1nlJNTBrtV8hckcWtVsW0d70dxASomO9jtJozvpx5mlXC7IX//CM0Q== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0C3EE76864 for ; Sat, 25 May 2024 16:08:42 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sAs40-000768-8V; Sat, 25 May 2024 10:08:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAs3w-00075g-EG for guix-patches@gnu.org; Sat, 25 May 2024 10:07:56 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sAs3v-0002EV-ST for guix-patches@gnu.org; Sat, 25 May 2024 10:07:56 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sAs42-0000EU-Co for guix-patches@gnu.org; Sat, 25 May 2024 10:08:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70499] [PATCH v2 0/3] Lint package order. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 25 May 2024 14:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70499 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Herman Rimm Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Florian Pelz , Ricardo Wurmus , Christopher Baines , 70499@debbugs.gnu.org Received: via spool by 70499-submit@debbugs.gnu.org id=B70499.1716646031747 (code B ref 70499); Sat, 25 May 2024 14:08:02 +0000 Received: (at 70499) by debbugs.gnu.org; 25 May 2024 14:07:11 +0000 Received: from localhost ([127.0.0.1]:43636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAs3D-0000Bv-3j for submit@debbugs.gnu.org; Sat, 25 May 2024 10:07:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAs3A-0000BW-UX for 70499@debbugs.gnu.org; Sat, 25 May 2024 10:07:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAs2t-00022f-FW; Sat, 25 May 2024 10:06:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=aXlwuPZl6ZGtegVHTKsotbis+7PTHa+Kou3ZgU5y3cg=; b=kg8RDQC8oruycuXGbMES c6QmhH5qIAa7tNh/HYkbp4CpOM9cxTUzfMG11e7yiOITcHsKr/BTaKSuu8KPBJ2zPvf2MIJ1cvCRI BHIYfjkH4eVn1X0BxOKtMk8VTCsXawM+sPv50jQ6VIx1VogkTFeQvug686qneLXEljjgS3emmHsEZ a5h/WZyZLiLl3/XQFp067tbUQPy2me0jgCSE2FTRwR6rPCKlL05scvb9jCKshg2YABBoPyaze4G7k 4uutxZ1RlMsVVZrMtzw07kfwDQWpZe2aYnSVvS9r7hmPahjMpKE4zCMUbDwf6Ze9RRZPBirUbX0Fa tj0wy4HwanHNhA==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: (Herman Rimm's message of "Sun, 5 May 2024 19:25:32 +0200") References: <1f19f015e714d68c84cd91618b1340365c8363bb.1713722288.git.herman@rimm.ee> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Septidi 7 Prairial an 232 de la =?UTF-8?Q?R=C3=A9volution, ?= jour du Fromental X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 25 May 2024 16:06:45 +0200 Message-ID: <87a5ke0yve.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -5.75 X-Migadu-Queue-Id: 0C3EE76864 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -5.75 X-TUID: KjtdDg69OOiK Hi Herman, Herman Rimm skribis: > I do not think 'find-unordered-packages' would be useful for e.g. guix > style, so I made a similar procedure in (guix scripts lint) instead. It > is implemented with 'fold-packages' to get package records to pass to > the 'run-checkers' procedure. So now you can use guix lint with > --whole-file to also lint the package ordering, for example: Nice. > $ guix lint -f gnu/packages/matrix.scm -n > gnu/packages/matrix.scm:161:0: python-matrix-nio@0.20.2: breaks from al= phabetical order > gnu/packages/matrix.scm:244:0: pantalaimon@0.10.5: breaks from alphabet= ical order > > However the alphabetical order lint warnings only appear once another > type of lint warning is emitted, or when end of file is reached and > linting finishes. So if few checkers are enabled, it takes a few seconds > before anything is output for large module files, like 'crates-io.scm'. > Can this be fixed easily? I=E2=80=99m not sure I understand. The alpabetical checker is part of anot= her patch set, right? (I know I=E2=80=99ve seen it, but I=E2=80=99m afraid I= =E2=80=99ve lost track of it. :-)) Anyway, we can and should discuss =E2=80=98--whole-file=E2=80=99 independen= tly of the alphabetical-order checker. > guix: Move =E2=80=98package-location ui: Make 'user-module' parameter of 'load*' optional. > scripts: lint: Add 'whole-file' option with ordering lint. This LGTM modulo minor issues: =E2=80=A2 The second patch looks unrelated to =E2=80=98--whole-file=E2=80= =99, I=E2=80=99d drop it from this series. =E2=80=A2 The third patch misses just one thing: a test in =E2=80=98tests/guix-lint.sh=E2=80=99. Could you send an updated patch series? Thanks, and apologies for the delay! Ludo=E2=80=99.