From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id CDdxIkX96mYEpwAAe85BDQ:P1 (envelope-from ) for ; Wed, 18 Sep 2024 16:18:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id CDdxIkX96mYEpwAAe85BDQ (envelope-from ) for ; Wed, 18 Sep 2024 18:18:13 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=byFe+TjN; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=ZcTWvpcr; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726676293; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=PGbi8OiqZj40Y7YAsN1XIao/ajUyuqwQov+nV+sYgyk=; b=oC+mkAO50x0dfkU2QMZZtjQfCapeHIeOFxTgRfZMDTukK7+QjHXhN49NBkp4bX2rkHsnPl I/oR9HY9bzo+1izp8TGwVgWNCt0H8al2VzlIq7D63SOObzni8BXEGuhGis+rIid6RTDXCr mr9XOCOZmY8rHJM+7sPMbQkUMjjtajTkWyzAuRLpL7HbiBOdTKO+inApJ7h/mvO45wzMkl oqzzbML4oPARrYsPaDKzT3vRD/9dIFuebg5g2MJGEYGTo3+F9bxn0cHu6rPFGyHB5i7/TP tO1+V6fQIPvUEEn3cfStNbkpa8rbRyra8vGjbDXbS+16L9SMrp1DI4URLUJ4jA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726676293; a=rsa-sha256; cv=none; b=N190pnSDm+Bp5nhpH0T3v+wqbb2M3nG+fefPki/ENIEDztvi4Ue7PJs16CEwI8yyBx7i0C ZgtnKWOFG3ZMB6xgjnJDYG8jXY3F89YcFU5m8VHddLLPkMKaNQEpr8y5CcsCNh42mzaDPx ixBzFkPlFGs/0jukmpYGZoG5Csp6WsXIobLDHM0CSQdonjcUSCcL9HBtuRO3hi4VLTMD8G 5DGXdbxPKh9gjnw4Hvmb0kc+uTKsi4VVP0xCw48D4V67Rq+kIRlyRj97HXYHsyzGaODLRL uTlEd5+2SRHS0xW5ZGBEKjRYpjWuyxuNoaWWYKF0U+4b6umXlE1jtqceE062ew== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=byFe+TjN; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=ZcTWvpcr; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3BDF16184E for ; Wed, 18 Sep 2024 18:18:13 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqxNL-0002Jz-Kg; Wed, 18 Sep 2024 12:17:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqxNE-0002Jl-CZ for guix-patches@gnu.org; Wed, 18 Sep 2024 12:17:48 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sqxND-00048o-6q for guix-patches@gnu.org; Wed, 18 Sep 2024 12:17:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=PGbi8OiqZj40Y7YAsN1XIao/ajUyuqwQov+nV+sYgyk=; b=byFe+TjNhMrVlOJGpVwrRh+QDbaXWVs1KeL5ZIaSYDkJOKLmzMGV8sLpI2YoqGAfjXL61OZAWyZFHyx9u3he1a/HyhijtqVnvVJZz0pQPfLuKwxtwUsQERag6JjVrR2+AhLaOcxaMRjq8GGJscCOfX+o9Sr3GOXT0JMNvV3viubDN2elhsNQ8ZdbY+dHkgQapyxpOLjdl7AP7EyAnKBaDTkenFuzrtJok0f6VqJUbWur9/e6K6b+4X9C6zgOtDKJz4L1frT8fu/qfAugqmYk9Ha+SRMsCgIov9AHVqrZr6LDq2FqR7CKFb7Vms7soDbXtxOyio9raDzozjWeAoIqkQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sqxNS-0005kP-DI; Wed, 18 Sep 2024 12:18:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72925] Adding JPM package for Janet Resent-From: Suhail Singh Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org, "Suhail Singh" Resent-Date: Wed, 18 Sep 2024 16:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72925 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Omar Bassam Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart , Suhail Singh Received: via spool by 72925-submit@debbugs.gnu.org id=B72925.172667627522079 (code B ref 72925); Wed, 18 Sep 2024 16:18:02 +0000 Received: (at 72925) by debbugs.gnu.org; 18 Sep 2024 16:17:55 +0000 Received: from localhost ([127.0.0.1]:59194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqxNL-0005k2-EX for submit@debbugs.gnu.org; Wed, 18 Sep 2024 12:17:55 -0400 Received: from mail-qv1-f68.google.com ([209.85.219.68]:46576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqxNI-0005jn-0s for 72925@debbugs.gnu.org; Wed, 18 Sep 2024 12:17:53 -0400 Received: by mail-qv1-f68.google.com with SMTP id 6a1803df08f44-6c36ff6e981so50778976d6.1 for <72925@debbugs.gnu.org>; Wed, 18 Sep 2024 09:17:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726676190; x=1727280990; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=PGbi8OiqZj40Y7YAsN1XIao/ajUyuqwQov+nV+sYgyk=; b=ZcTWvpcrc6jMCPE0vv18lJAUOpAKHptxrSIBuOb0V7RzwoNbhwbiE0xClHy5x80Q6c JopAef73Xc3LDLgHRv8h1g7Le04gN2CJPRjG70BdbxF7TZ5FBAiFy7oiONuRJoaVAuSC p59nvuGOVsPxC3RlaGjUQ6q7XTcHp+2TCWc4ByFC/VZMaQNXEuH4vJz5p2ME54aiTdP8 PxIVBfothL+L47QJ3hGNCfO63YsoXlrOELXOiqXGaYRgJOc+uPM1rZG20DrHCa0PMOC+ wsnjr5GESgpfEABBXZ/ZIe2t+UnecZTRKW+/Yrly2ctXIXPnHgadube30Jr3KYn558y0 fuKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726676190; x=1727280990; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PGbi8OiqZj40Y7YAsN1XIao/ajUyuqwQov+nV+sYgyk=; b=DKXfmtaRDfEGxQdt71o/zncYxeyM3mt07h/rEwgf9PtUSgVXu58o5iMdGIud5Ipn1A Bk4aiMJavA1JAay+M3tRHUjUllU7NPdbHAChnn8LHM2LqQunnZwQDQ9dEfkQ+3exlBpG Is61iJYqNqLiuWOBipQtca4OGSB6IFA8ILcSSWEHx+JCyT7HRaHk9O4yEGHPcG+8W7HQ KNnxAwLkaLTdjRWL2M2tFIAp9w65w7topwCQkh3cnLRtjqd7oA+HICsxdn1RamqsP96y z9D+lT7UEQxW4bOGBq3x8Gpwa97ibJkae99UBebM1mFL24sFWqx/Nee1tlG1EtZQ5kqp eyKQ== X-Forwarded-Encrypted: i=1; AJvYcCWYSI4dbYmbgs+PNbc031z1r2PvnmWvV+4KFtdbaYR6zw4ZeX1MDDihyLeSikA/0ahJauKuzQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxT2kzFeCDxmwyrHAuXv+fzLSgIHF90LhWemcqu1CXTcZlpoc11 h0MFew4kfeUynC1EZenvxEwXJaGZM2uYPhKLkEq6Ssc9QAPCrvdJ X-Google-Smtp-Source: AGHT+IF/v0N6JGSNdXy4sWCsNlZtLrrAxWNaATnIhemrErkKidGJSytaEXrXzt3/dKmYmhTzuSf5/Q== X-Received: by 2002:a05:6214:4802:b0:6c5:15dc:df02 with SMTP id 6a1803df08f44-6c573556ea6mr392704936d6.3.1726676190027; Wed, 18 Sep 2024 09:16:30 -0700 (PDT) Received: from gnus (bras-base-mtrlpq0776w-grc-23-65-94-70-53.dsl.bell.ca. [65.94.70.53]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6c58c691deasm45219026d6.80.2024.09.18.09.16.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 09:16:29 -0700 (PDT) From: Suhail Singh In-Reply-To: (Omar Bassam's message of "Wed, 18 Sep 2024 18:34:17 +0300") References: <950a7d3637ddf17be84f52dc2ae0aac2ce4c4be6.1725547778.git.omar.bassam88@gmail.com> <87h6adyua5.fsf_-_@gmail.com> Date: Wed, 18 Sep 2024 12:16:28 -0400 Message-ID: <87a5g5vswz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -8.95 X-Migadu-Queue-Id: 3BDF16184E X-Spam-Score: -8.95 X-TUID: BoOhFY5uRSau Omar Bassam writes: > Thank you for taking the time to look into my patch. Sorry, I'm new to Guix > and to this workflow. So, forgive me if my questions look a bit naive: > 1. What do you mean by reroll count for the patch? Please refer to the man page of git-format-patch and look for --reroll-count : #+begin_quote -v , --reroll-count= Mark the series as the -th iteration of the topic. The output filenames have v prepended to them, and the subject prefix ("PATCH" by default, but configurable via the --subject-prefix option) has ` v` appended to it. E.g. --reroll-count=4 may produce v4-0001-add-makefile.patch file that has "Subject: [PATCH v4 1/20] Add makefile" in it. does not have to be an integer (e.g. "--reroll-count=4.4", or "--reroll-count=4rev2" are allowed), but the downside of using such a reroll-count is that the range-diff/interdiff with the previous version does not state exactly which version the new iteration is compared against. #+end_quote > 2. I looked at the copy-build-system documentation. I'm not sure how it can > be used here. I'm not just updating the shebang. As you can already see in > the patch, I'm doing a lot of string substitutions in the source code > itself because some values are hard coded. That's why I preferred to use > the trivial-build-system to have more control of what I need to substitute. Based on my understanding of the patch you are copying files, updating some references in files, and setting environment variables. I believe all of these are possible via the copy-build-system as well which is described as: #+begin_quote ;; Standard build procedure for simple packages that don't require much ;; compilation, mostly just copying files around. This is implemented as an ;; extension of `gnu-build-system'. #+end_quote If you'd like to learn more, you can grep under ./gnu/packages and look at some instances where it's used. I don't have experience with the trivial-build-system, which is why I wondered. > + (setenv "PREFIX" %output) > + (setenv "JANET_PREFIX" %output) > + (setenv "JANET_LIBPATH" (string-append %output "/lib/janet")) > + (setenv "JANET_MODPATH" (string-append %output "/lib/janet")) What would be a way to test that the above is doing the "correct" thing? Is there a sequence of steps that I can evaluate which will yield a different outcome depending on whether or not the above accomplishes what it intends to? Put another way, what breaks when the above aren't set (and how do I observe that failure)? -- Suhail