From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id IEtmOBvtBGf11gAAqHPOHw:P1 (envelope-from ) for ; Tue, 08 Oct 2024 08:28:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id IEtmOBvtBGf11gAAqHPOHw (envelope-from ) for ; Tue, 08 Oct 2024 10:28:12 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=u2eeJP+8; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=N2MtuOzk; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1728376091; a=rsa-sha256; cv=none; b=It3IRtgh5D74swmj/vSEnVeZiIOmYZNPY+9h1aAZJpgI/t/K0g0K8jqs03WByx4NzpTyrK EgCsuJ2JoiKk4zZdxhwqXsdLps28+cdchKa++VdmKqPyL9VSI3RLzlInXdiLawj3O+tG4H U0zgf9bTs3yKFQhiZIF3C45gocu7jrxWgeZTUUJO7LxzX0U5d5aWNNr6wHXsnHQFGCt/kR bA/BPP3U1DQcIPTQND7i2oqHdIaj4wb+NMT5NKYCIFg/jDitKPwabzoJU1MAMB4SGzUli+ Bpldjzq+QECbTM5kP4JeOxmiTxMMv5d7g8Yq+X4TNxj6mzGzPeLPBEB5CLPOMw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=u2eeJP+8; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=N2MtuOzk; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1728376091; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=eUYxs/CMF/KrnS6mYzrISf244lNTZqh0wbtxWhQmhvw=; b=o7cpq8bIcCFTi4Adr7Vc499Puq5tzRM1luqFFk5xZSOO2oWwe4FM0sN/5GVZ6ySo0Rk1RH u/LF2bt+9lVrPBJODVH5A/qrdoa2lEtHhiCDjEvpJ1L62FaqbIGxSm7Mpas0msMH5pVXoG Pm9yu8GVBGmIBkG/9oha2dt2l2gWP/g8h/2CoB7yX5Rytbt2SRcqDW7rMRIo0dga0Y0U+o 3jHu6tlhSMCUazd2UKkntvTgbnVyhQgTW0yVnSi7PIhBATPQ/guQvk151CCcb8nwcee7eI UTUVR9cnj8fET0J1/Aym5lRdwnJsotUznHnmByVqc3SApF4kjdOBwiHxg5InUg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7A4EB87876 for ; Tue, 08 Oct 2024 10:28:11 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sy5ZV-0006sN-8y; Tue, 08 Oct 2024 04:27:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sy5ZS-0006sE-9I for guix-patches@gnu.org; Tue, 08 Oct 2024 04:27:54 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sy5ZS-0000q0-0A for guix-patches@gnu.org; Tue, 08 Oct 2024 04:27:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=eUYxs/CMF/KrnS6mYzrISf244lNTZqh0wbtxWhQmhvw=; b=u2eeJP+8LM74N5xaL+0JEg+4i6gLCsjILTVxGEPCRda3XEiIVcA1U1l0cEfNXv+kb1PuV81eyxIUrMbA0rPT+1FSHfGaTD8HO4eU4ErTnZhcauVe/DAMiHYsGIpgh+yiaY5AZxV35rQr4EAmwNUqL3RwsvMdZO4dxCU9zW0dILW3TyBFklvXkatbxU1OAMm3uRJ7Gib7b9NUiQH0TrWaYWdnw+nDZdEx1BNJl5F2zBEeIeSiExXWZb1Znya3RuxJXo7zDrvf9F7H0/LlOeCehZQWWQDHqLhYPjmBvdhvG34IntJlFWEhkHpA5z1p/Rc3fyHorbRXiVjjJFjuVyep6g==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sy5Za-0007Ur-AB for guix-patches@gnu.org; Tue, 08 Oct 2024 04:28:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72925] [PATCH v10] gnu: Add jpm. Resent-From: Omar Bassam Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Oct 2024 08:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72925 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Suhail Singh Cc: 72925@debbugs.gnu.org, Omar Bassam Received: via spool by 72925-submit@debbugs.gnu.org id=B72925.172837602328739 (code B ref 72925); Tue, 08 Oct 2024 08:28:02 +0000 Received: (at 72925) by debbugs.gnu.org; 8 Oct 2024 08:27:03 +0000 Received: from localhost ([127.0.0.1]:50816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sy5Yc-0007TI-Rx for submit@debbugs.gnu.org; Tue, 08 Oct 2024 04:27:03 -0400 Received: from mail-wm1-f53.google.com ([209.85.128.53]:47551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sy5Ya-0007SY-Mw for 72925@debbugs.gnu.org; Tue, 08 Oct 2024 04:27:01 -0400 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-42cbb08a1a5so54760305e9.3 for <72925@debbugs.gnu.org>; Tue, 08 Oct 2024 01:26:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728375946; x=1728980746; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=eUYxs/CMF/KrnS6mYzrISf244lNTZqh0wbtxWhQmhvw=; b=N2MtuOzkE2e1VkIY7XU4tiwCntfLoHSg2dYrLHWenj8xLLpBF3aZCMFgiUZ5sKVYMJ orRj8+kYrGJ3+RbgkW972TsyzUCRVyiE2WqrgLseW4ZIqfskUI4QiTMKtFn+H8cPEeD5 bPGYu5jcWiwk91c40lQMd+HxkdcCUtX0bglyTNHngS1vUPcGpTZcfFBzdCmZYKh0qprA msShVp0ASM63HMpss64V06SiOGQ78W5z2ioPDM/llIdbWQBMIaDFTq6lDE82xXbMMWe2 hnt2K0rTPgtuzlH1roWV89He464BmbUvOAc71f6IHG7Qn1lPy8dBegE4odwu6ZnnUtNV J68Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728375946; x=1728980746; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eUYxs/CMF/KrnS6mYzrISf244lNTZqh0wbtxWhQmhvw=; b=crKqQ38RtS3eDZ6ut5J6jzP274Qazy5LCfgSMPzJ2fCwasI/qwii0bS/gdz8BBy7Wf h/JQCt6gHYdaQn6BjPq3uFfczNyKlW+UVD4LM869PVjyTuC0LOkmTiYVQOS/SfC/NMD0 LW6VC7AQiNdu/6UAg00AT6bsBSVjmIf5cXA3Qp0AEc6klHbhMeHlbOkCMCtRHBVfe1N4 ECgIG0vtKYfBuFzI2vHorAZvHlY/WEPT8VAFNtW1e9ImD9JS4FPf+zbDSyoVKckDAHRs T7PDIKBjc/Ngdup+9Lc1SAiTMXLIzqxoySYctR3iKLTO8SA2vsegZhUMvMjBRUOzg788 CRMA== X-Forwarded-Encrypted: i=1; AJvYcCUNqVeKLeKFCdkoPIs/+rWQPlhe2E9FYAGMY1VY3htuFNTvEW1eIEzsjO88D8ChkwabfQ0IJw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy5PxqOYK5uie5WMUi9Jo3BmA+wPpK0JkFWV8DZYYrORlt1vky1 EET61miEn3704zxdfAkXLfZN5Y3HpMJVouJt1cnM4k5FXYaaGhyJ+JUMeGGw X-Google-Smtp-Source: AGHT+IHm9jeKi/DR2K/XJyCLU789w/HIVFiO66ZKXxQQHZHfGdqLEjF69UxSa60XxBi6r/lzhYw6Bg== X-Received: by 2002:a05:600c:6048:b0:42c:df54:1908 with SMTP id 5b1f17b1804b1-42f85ab7dffmr110987695e9.18.1728375945365; Tue, 08 Oct 2024 01:25:45 -0700 (PDT) Received: from omar-Latitude-5540 ([94.156.217.228]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43054b04a9fsm6343245e9.9.2024.10.08.01.25.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2024 01:25:44 -0700 (PDT) From: Omar Bassam X-Google-Original-From: Omar Bassam In-Reply-To: <87y12zh2rx.fsf@gmail.com> (Suhail Singh's message of "Mon, 07 Oct 2024 20:11:30 -0400") References: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87msjh5j5f.fsf@gmail.com> <87bjzxgggw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <8734l86h4l.fsf@gmail.com> <871q0rhiu6.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <877cajiw5x.fsf@gmail.com> <87ttdng1u1.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <875xq3k6ue.fsf@gmail.com> <87ed4rfwgw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87y12zh2rx.fsf@gmail.com> Date: Tue, 08 Oct 2024 11:25:41 +0300 Message-ID: <87a5fff1bu.fsf@omar-Latitude-5540.mail-host-address-is-not-set> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -1.87 X-Spam-Score: -1.87 X-Migadu-Queue-Id: 7A4EB87876 X-Migadu-Scanner: mx12.migadu.com X-TUID: siSjq3c/XQoL Suhail Singh writes: > Omar Bassam writes: > >>>>>>>>> What we need is _some_ mechanism to ensure that when jpm invokes gcc (or >>>>>>>>> g++), the compiler is able to locate the appropriate header files. >>>>>>>>> >>>>>>>>> This should be doable without propagating any other inputs. For example >>>>>>>>> by ensuring that jpm sets appropriate environment variables (such as >>>>>>>>> $CPATH , $C_INCLUDE_PATH , $CPLUS_INCLUDE_PATH etc.) or flags when >>>>>>>>> invoking the compiler. If so, that would be the preferred approach. We >>>>>>>>> only want to propagate those inputs that are strictly necessary. >>>>>>>>> >>>>>>>>> ... >>>>>>>>> >>>>>>>>> I look forward to seeing what you come up with in v11 :) >>> >>> I.e., it's not clear to me that propagating gcc and g++ is necessary. >>> And if the same can be achieved by passing appropriate environment >>> variables, why not? Could you please answer? >>> >>> Regardless, we are in agreement that the propagation of gcc-toolchain is >>> not necessary and should be removed. >>> >> >> I've now removed gcc from the propagated-inputs I've tested passing the >> gcc to jpm using the --cc flag as follows "jpm build --cc=/path/to/gcc". > > Am I understanding correctly that, with v11 in order for the user to be > able to install a Janet package such as "sh", they have to find the > location of gcc being used by jpm and pass that to it? > > If so, why? This is not what I tried to explain above. The jpm package > "knows" the specific version of gcc (and g++) that have been patched in, > so why does it require the user to take additional action? I.e., the > goal, IMHO, should be that in a pure container that contains nss-certs, > one is simply able to run "jpm install -l sh" and it works. > No, the user doesn't need to specify the flag if the gcc package is available in their shell (or pure container shell). I was just testing that you can pass the C flags that you were concerned about from before. I am still not sure if I fully understood your C paths cocern correctly. >> I hope I understood your concern correctly this time. > > I don't believe so. > >> If not, please feel free to add to the patch whatever you think is >> needed as I'm not a C compiling expert. > > Sorry, but I am no C compiling expert either. > > In addition, for the past few exchanges, it's not clear that I am able > to bring value to the discussion. As evidenced by the recent exchanges, > I seem to be struggling with expressing myself effectively. As such, I > will step-away from actively reviewing this issue. > On the contrary, I've learned so much from your comments and I really appreciate your patience. I believe it's my lack of understanding of guix packagin philosophy as this is my first time diving into the source code of Guix. > I hope you are able to get jpm upstreamed with help from jgart and > others more experienced than myself. Thank you, if it ever get upstreamed it will be mostly becuase of your comments, knowledge sharing and patience that I really appreciate. Many Thanks, Omar