From: "Ludovic Courtès" <ludo@gnu.org>
To: Runciter <runciter@whispers-vpn.org>
Cc: 75063@debbugs.gnu.org
Subject: [bug#75063] [PATCH v2] gnu: dict: Add symbols to help users configure FreeDict with dicod.
Date: Wed, 08 Jan 2025 23:15:33 +0100 [thread overview]
Message-ID: <87a5c1t0je.fsf@gnu.org> (raw)
In-Reply-To: <eb6b4319e4a25c06bb48968d9f11779046ab0e52.1735759383.git.runciter@whispers-vpn.org> (runciter@whispers-vpn.org's message of "Wed, 01 Jan 2025 19:23:25 +0000")
Hi,
Runciter <runciter@whispers-vpn.org> skribis:
> * gnu/services/dict.scm: (%dicod-database:freedict): New procedure;
> (dicod-freedict-databases): new variable.
> * doc/guix.texi: (Dictionary Service): Document them.
>
> Signed-off-by: Runciter <runciter@whispers-vpn.org>
[...]
> -The following is an example @code{dicod-service-type} configuration.
> +@deffn {Procedure} %dicod-database:freedict dictionary-name
> +"Returns a record of type @code{dicod-database} for purpose of configuring a
> +database for the FreeDict multilingual dictionary named by the string
> +@var{dictionary-name} into a service of type @code{dicod-service-type}."
> +@end deffn
Could you remove double quotes?
I would add an example, like so: “… named by @var{dictionary-name}, a
string such as @code{"kur-eng"} for the Kurdish-to-English dictionary,
into a service …”.
> +@defvar dicod-freedict-databases
> +A relatively large list of records of type @code{dicod-database}, made
Oops, I guess my message was unclear.
I think the procedure should be called ‘dicod-freedict-database’
(singular); the variable for all the databases should be called
‘%dicod-databases:freedict’ (similar to ‘%dicod-database:gcide’).
Apart from that it looks good to me.
Could you send one last version along these lines?
Thanks,
Ludo’.
next prev parent reply other threads:[~2025-01-08 22:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-24 12:47 [bug#75063] [PATCH 0/2] Easy configuration of FreeDict into dicod-service-type Runciter via Guix-patches via
2024-12-24 13:00 ` [bug#75063] [PATCH 1/2] gnu: dict: Add symbols to help users configure FreeDict with dicod Runciter via Guix-patches via
2024-12-25 21:23 ` Ludovic Courtès
2024-12-24 13:00 ` [bug#75063] [PATCH 2/2] doc: add FreeDict dictionaries to dicod configuration example Runciter via Guix-patches via
2024-12-26 16:22 ` [bug#75063] [PATCH 1/2] gnu: dict: Add symbols to help users configure FreeDict with dicod Runciter via Guix-patches via
2024-12-29 18:35 ` Runciter via Guix-patches via
2025-01-01 19:23 ` [bug#75063] [PATCH v2] " Runciter via Guix-patches via
2025-01-08 22:15 ` Ludovic Courtès [this message]
2025-01-09 14:13 ` Runciter via Guix-patches via
2025-01-09 14:14 ` [bug#75063] [PATCH v3] " Runciter via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5c1t0je.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=75063@debbugs.gnu.org \
--cc=runciter@whispers-vpn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).