unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#75970] [PATCH] gnu: go-github-com-cespare-xxhash-v2: Fix build on aarch64.
@ 2025-01-31 15:11 Roman Scherer
  2025-01-31 15:25 ` [bug#75970] go-github-com-cespare-xxhash-v2 failing " Roman Scherer
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Roman Scherer @ 2025-01-31 15:11 UTC (permalink / raw)
  To: 75970; +Cc: Roman Scherer

* gnu/packages/golang-crypto.scm (go-github-com-cespare-xxhash-v2): Fix build on aarch64.

Change-Id: I348839621b1937618714d7ca5c6a49b291a27e70
---
 gnu/packages/golang-crypto.scm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/golang-crypto.scm b/gnu/packages/golang-crypto.scm
index 75c56684d4..3b0f521244 100644
--- a/gnu/packages/golang-crypto.scm
+++ b/gnu/packages/golang-crypto.scm
@@ -442,7 +442,12 @@ (define-public go-github-com-cespare-xxhash-v2
        (sha256
         (base32 "1f3wyr9msnnz94szrkmnfps9wm40s5sp9i4ak0kl92zcrkmpy29a"))
        (modules '((guix build utils)))
-       (snippet '(delete-file-recursively "xxhashbench"))))
+       (snippet
+        `(begin
+           (delete-file-recursively "xxhashbench")
+           (when ,(target-aarch64?)
+             ;; Fails on aarch64 with: collect2: fatal error: cannot find ‘ld’
+             (delete-file-recursively "dynamic"))))))
     (arguments
      (list
       #:import-path "github.com/cespare/xxhash/v2"

base-commit: bdd6760b8c46e59f86415d67981acb6f77e9ed22
-- 
2.48.1





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#75970] go-github-com-cespare-xxhash-v2 failing on aarch64
  2025-01-31 15:11 [bug#75970] [PATCH] gnu: go-github-com-cespare-xxhash-v2: Fix build on aarch64 Roman Scherer
@ 2025-01-31 15:25 ` Roman Scherer
  2025-02-03 14:14 ` bug#75970: [PATCH] gnu: go-github-com-cespare-xxhash-v2: Fix build " Sharlatan Hellseher
       [not found] ` <handler.75970.D75970.17385920673507.notifdone@debbugs.gnu.org>
  2 siblings, 0 replies; 4+ messages in thread
From: Roman Scherer @ 2025-01-31 15:25 UTC (permalink / raw)
  To: 75970; +Cc: Sharlatan Hellseher

[-- Attachment #1: Type: text/plain, Size: 837 bytes --]


Hi Oleg,

I while ago you helped me adding the Hetzner CLI to Guix. It has now
landed, but unfortunatly I can't build it anymore on my aarch64 system,
because the go-github-com-cespare-xxhash-v2 is failing.

I saw that Ian Eure mentioned something about changes to the go build
system in https://issues.guix.gnu.org/75932.

Not sure if this is related. The only suspicious thing I saw in
go-github-com-cespare-xxhash-v2 is this:

https://github.com/cespare/xxhash/blob/main/dynamic/plugin.go#L1-L2

Nevertheless I now submitted a patch for go-github-com-cespare-xxhash-v2
that removes the dynamic folder on aarch64 which causes the build to
fail. I'm not sure if this is an optional dependency or not, but with
this change I can build the Hetzner CLI again.

Can you help me with this? Do you have any ideas about this?

Thanks, Roman.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 528 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#75970: [PATCH] gnu: go-github-com-cespare-xxhash-v2: Fix build on aarch64.
  2025-01-31 15:11 [bug#75970] [PATCH] gnu: go-github-com-cespare-xxhash-v2: Fix build on aarch64 Roman Scherer
  2025-01-31 15:25 ` [bug#75970] go-github-com-cespare-xxhash-v2 failing " Roman Scherer
@ 2025-02-03 14:14 ` Sharlatan Hellseher
       [not found] ` <handler.75970.D75970.17385920673507.notifdone@debbugs.gnu.org>
  2 siblings, 0 replies; 4+ messages in thread
From: Sharlatan Hellseher @ 2025-02-03 14:14 UTC (permalink / raw)
  To: 75970-done

[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]


Hi Roman,

Thank you for reporting this.

To resolve build for hetznercloud-cli on aarch64-linux I've limited tests
coverage in go-github-com-cespare-xxhash-v2 package with #:tests-subdirs
parameter instead of deleting files as you proposed.

Tested locally
--8<---------------cut here---------------start------------->8---
> ./pre-inst-env guix build --system=aarch64-linux hetznercloud-cli
/gnu/store/vm5dmj6hi3147xxhmwiqc7z94yzx74rk-hetznercloud-cli-1.49.0
--8<---------------cut here---------------end--------------->8---

These commits fixed build hetznercloud-cli on aarch64-linux system and
pushed to master:
--8<---------------cut here---------------start------------->8---
97fee203a54 * master gnu: go-github-com-prometheus-client-golang: Skip one more test.
5b9fa4a27c7 * gnu: go-github-com-cespare-xxhash-v2: Update to 2.3.0.
4ded4c6b713 * gnu: go-github-com-cespare-xxhash-v2: Skip dynamic and benchmark tests.
--8<---------------cut here---------------end--------------->8---

Closing as resolved.

--
Oleg

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#75970] closed ([PATCH] gnu: go-github-com-cespare-xxhash-v2: Fix build on aarch64.)
       [not found] ` <handler.75970.D75970.17385920673507.notifdone@debbugs.gnu.org>
@ 2025-02-03 15:00   ` Roman Scherer
  0 siblings, 0 replies; 4+ messages in thread
From: Roman Scherer @ 2025-02-03 15:00 UTC (permalink / raw)
  To: 75970; +Cc: roman

[-- Attachment #1: Type: text/plain, Size: 3648 bytes --]

References: <877c67kte9.fsf@gmail.com>
	<a85cf4325080efc3974b2b7b8c34d6aa7abac772.1738336212.git.roman@burningswell.com>
	<handler.75970.D75970.17385920673507.notifdone@debbugs.gnu.org>
User-Agent: mu4e 1.12.8; emacs 29.4
Thank you Oleg!

Date: Mon, 03 Feb 2025 16:00:01 +0100

help-debbugs@gnu.org (GNU bug Tracking System) writes:

> Your bug report
>
> #75970: [PATCH] gnu: go-github-com-cespare-xxhash-v2: Fix build on aarch64.
>
> which was filed against the guix-patches package, has been closed.
>
> The explanation is attached below, along with your original report.
> If you require more details, please reply to 75970@debbugs.gnu.org.
>
> --
> 75970: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75970
> GNU Bug Tracking System
> Contact help-debbugs@gnu.org with problems
>
> From: Sharlatan Hellseher <sharlatanus@gmail.com>
> Subject: [PATCH] gnu: go-github-com-cespare-xxhash-v2: Fix build on aarch64.
> To: 75970-done@debbugs.gnu.org
> Date: Mon, 03 Feb 2025 14:14:06 +0000 (45 minutes, 36 seconds ago)
>
>
> Hi Roman,
>
> Thank you for reporting this.
>
> To resolve build for hetznercloud-cli on aarch64-linux I've limited tests
> coverage in go-github-com-cespare-xxhash-v2 package with #:tests-subdirs
> parameter instead of deleting files as you proposed.
>
> Tested locally
> --8<---------------cut here---------------start------------->8---
>> ./pre-inst-env guix build --system=aarch64-linux hetznercloud-cli
> /gnu/store/vm5dmj6hi3147xxhmwiqc7z94yzx74rk-hetznercloud-cli-1.49.0
> --8<---------------cut here---------------end--------------->8---
>
> These commits fixed build hetznercloud-cli on aarch64-linux system and
> pushed to master:
> --8<---------------cut here---------------start------------->8---
> 97fee203a54 * master gnu: go-github-com-prometheus-client-golang: Skip one more test.
> 5b9fa4a27c7 * gnu: go-github-com-cespare-xxhash-v2: Update to 2.3.0.
> 4ded4c6b713 * gnu: go-github-com-cespare-xxhash-v2: Skip dynamic and benchmark tests.
> --8<---------------cut here---------------end--------------->8---
>
> Closing as resolved.
>
> --
> Oleg
>
> ----------
>
> From: Roman Scherer <roman@burningswell.com>
> Subject: [PATCH] gnu: go-github-com-cespare-xxhash-v2: Fix build on aarch64.
> To: guix-patches@gnu.org
> Cc: Roman Scherer <roman@burningswell.com>
> Date: Fri, 31 Jan 2025 16:11:26 +0100
> Date: Fri, 31 Jan 2025 16:11:26 +0100 (2 days, 23 hours, 48 minutes ago)
>
> * gnu/packages/golang-crypto.scm (go-github-com-cespare-xxhash-v2): Fix build on aarch64.
>
> Change-Id: I348839621b1937618714d7ca5c6a49b291a27e70
> ---
>  gnu/packages/golang-crypto.scm | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/golang-crypto.scm b/gnu/packages/golang-crypto.scm
> index 75c56684d4..3b0f521244 100644
> --- a/gnu/packages/golang-crypto.scm
> +++ b/gnu/packages/golang-crypto.scm
> @@ -442,7 +442,12 @@ (define-public go-github-com-cespare-xxhash-v2
>         (sha256
>          (base32 "1f3wyr9msnnz94szrkmnfps9wm40s5sp9i4ak0kl92zcrkmpy29a"))
>         (modules '((guix build utils)))
> -       (snippet '(delete-file-recursively "xxhashbench"))))
> +       (snippet
> +        `(begin
> +           (delete-file-recursively "xxhashbench")
> +           (when ,(target-aarch64?)
> +             ;; Fails on aarch64 with: collect2: fatal error: cannot find ‘ld’
> +             (delete-file-recursively "dynamic"))))))
>      (arguments
>       (list
>        #:import-path "github.com/cespare/xxhash/v2"
>
> base-commit: bdd6760b8c46e59f86415d67981acb6f77e9ed22

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 519 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-02-03 15:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-31 15:11 [bug#75970] [PATCH] gnu: go-github-com-cespare-xxhash-v2: Fix build on aarch64 Roman Scherer
2025-01-31 15:25 ` [bug#75970] go-github-com-cespare-xxhash-v2 failing " Roman Scherer
2025-02-03 14:14 ` bug#75970: [PATCH] gnu: go-github-com-cespare-xxhash-v2: Fix build " Sharlatan Hellseher
     [not found] ` <handler.75970.D75970.17385920673507.notifdone@debbugs.gnu.org>
2025-02-03 15:00   ` [bug#75970] closed ([PATCH] gnu: go-github-com-cespare-xxhash-v2: Fix build on aarch64.) Roman Scherer

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).