unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 29459@debbugs.gnu.org
Subject: [bug#29459] [PATCH] gnu: Add vim-fugitive.
Date: Mon, 27 Nov 2017 15:02:07 +0100	[thread overview]
Message-ID: <878tern7kw.fsf@gnu.org> (raw)
In-Reply-To: <20171126193105.7349-1-efraim@flashner.co.il> (Efraim Flashner's message of "Sun, 26 Nov 2017 21:31:04 +0200")

Hello,

Efraim Flashner <efraim@flashner.co.il> skribis:

> * gnu/packages/vim.scm (vim-fugitive): New variable.

[...]

> +(define-public vim-fugitive
> +  (let ((commit "de6c05720cdf74c0218218d7207f700232a5b6dc")
> +        (revision "1"))
> +    (package
> +      (name "vim-fugitive")
> +      (version (string-append "2.2-" revision "." (string-take commit 7)))

Do we really need to use a snapshot?  If so, please add a comment to
explain.

Otherwise LGTM.

Thanks,
Ludo’.

  parent reply	other threads:[~2017-11-27 14:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-26 19:31 [bug#29459] [PATCH] gnu: Add vim-fugitive Efraim Flashner
2017-11-26 19:31 ` [bug#29460] [PATCH] gnu: Add gama Efraim Flashner
2017-11-26 19:46   ` Jonathan Brielmaier
2017-11-27 14:03   ` Ludovic Courtès
2017-11-27 20:37   ` bug#29460: " Efraim Flashner
2017-11-27 14:02 ` Ludovic Courtès [this message]
2017-11-28  7:30 ` bug#29459: [PATCH] gnu: Add vim-fugitive Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878tern7kw.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=29459@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).