From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eKiUI-0005Rg-IU for guix-patches@gnu.org; Fri, 01 Dec 2017 05:24:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eKiUE-0006Nv-HS for guix-patches@gnu.org; Fri, 01 Dec 2017 05:24:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:58635) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eKiUE-0006Np-DR for guix-patches@gnu.org; Fri, 01 Dec 2017 05:24:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eKiUE-0000Sx-8P for guix-patches@gnu.org; Fri, 01 Dec 2017 05:24:02 -0500 Subject: [bug#28055] [WIP] Add knot tests Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170811210341.10ab9965@lepiller.eu> <87tw17khg0.fsf@elephly.net> <87r2ut27cb.fsf@gnu.org> Date: Fri, 01 Dec 2017 11:23:53 +0100 In-Reply-To: <87r2ut27cb.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 26 Sep 2017 10:27:00 +0200") Message-ID: <878temiw5i.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller Cc: Ricardo Wurmus , 28055@debbugs.gnu.org Julien, Did you have a chance to look into that? TIA, Ludo=E2=80=99. ludo@gnu.org (Ludovic Court=C3=A8s) skribis: > Howdy, > > Ricardo Wurmus skribis: > >>> This patch aims at adding a system test for knot. I've implemented the >>> DNS protocol to be able to communicate with the server and try some >>> queries. Unfortunately, although the server seems to be launched (the >>> first test passes), it then refuses to answer. Do you see anything >>> wrong, or anything I could do to understand why it doesn't pass? >> >> It looks like overkill to implement DNS queries with bytevectors from >> the ground up. Is there not an easier way to make a DNS test? > > It=E2=80=99s a bit overkill indeed=E2=80=A6 but I like it. :-) > > Julien: could you move the DNS code to a new module, say (guix dns), and > then add the Knot test? > > (So first patch adds (guix dns), second patch adds the test.) > > In passing, for (guix dns) it would be nice if you could add docstrings > as you see fit, and attempt to use full words in identifiers (=E2=80=9Cad= dress=E2=80=9D > rather than =E2=80=9Caddr=E2=80=9D, =E2=80=9Cresolve=E2=80=9D rather than= =E2=80=9Cresolv=E2=80=9D, etc.=C2=B9). > > This looks really nice, thanks for working on it! > > Ludo=E2=80=99. > > =C2=B9 https://www.gnu.org/software/guix/manual/html_node/Formatting-Code= .html